acts_as_list 0.9.14 → 0.9.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9c9b9604fc6198654f18e08d86d1d9b036fa2430
-  data.tar.gz: 9a3bd7ece52927226cfdd073f9071525189f0f07
+  metadata.gz: a9a0291b66db99525acb7519c4f07f6213807fab
+  data.tar.gz: 2bd62327801108c1b2e352b60334457a2c61f5ec
 SHA512:
-  metadata.gz: e9ba06d872a758fc9a0f7e32cb7439b6db5f59742a6c0b407a8be43915309f84df7e4c740ca56f0be99e78937bfb1522104ee6a90b025598497c952eaeba3e52
-  data.tar.gz: 14581f4471d860d9619e9a84a1762b785f83b3d1b4856dfd1439ff72f680a73000ab68f87fb1e9b9629394f49d730e26d447b67af474d4e0f085b6f5642b0903
+  metadata.gz: 712b360a8fd332f72fd8ecc3df598f0bdc42d048a14c2662e26f0001af55dbb0c75848cfec246ac2f446eaff3152d7007fc5b7234464b27d4cebda202223e44e
+  data.tar.gz: cc181d9cd3b8644796aebe0ce6e09ebf166fc89970c5617bd56c968a19ac18c3c97f5e8a60d78ac39011b74ab9e09804414844eb18e191052bb3bc9f8a082adb

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Change Log
 
+## [v0.9.14](https://github.com/swanandp/acts_as_list/tree/v0.9.14) (2018-06-05)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.13...v0.9.14)
+
+**Closed issues:**
+
+- `insert\_at` saves invalid ActiveRecord objects [\#311](https://github.com/swanandp/acts_as_list/issues/311)
+
+**Merged pull requests:**
+
+- \#311 Don't insert invalid ActiveRecord objects [\#312](https://github.com/swanandp/acts_as_list/pull/312) ([seanabrahams](https://github.com/seanabrahams))
+
 ## [v0.9.13](https://github.com/swanandp/acts_as_list/tree/v0.9.13) (2018-06-05)
 [Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.12...v0.9.13)
 

data/lib/acts_as_list/active_record/acts/no_update.rb

@@ -96,7 +96,7 @@ module ActiveRecord
           end
 
           def applied_to?(klass)
-            extracted_klasses.any? { |k| k == klass }
+            !(klass.ancestors & extracted_klasses).empty?
           end
 
           private

data/lib/acts_as_list/version.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '0.9.14'
+      VERSION = '0.9.15'
     end
   end
 end

data/test/test_no_update_for_subclasses.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require 'helper'
+
+class TodoItem < ActiveRecord::Base
+  acts_as_list
+end
+
+class SubTodoItem < TodoItem; end
+
+class NoUpdateForSubclassesTestCase < Minitest::Test
+  def setup
+    ActiveRecord::Base.connection.create_table :todo_items do |t|
+      t.column :position, :integer
+      t.column :type, :string
+    end
+
+    ActiveRecord::Base.connection.schema_cache.clear!
+    [TodoItem, SubTodoItem].each(&:reset_column_information)
+    super
+  end
+
+  def teardown
+    teardown_db
+    super
+  end
+end
+
+class NoUpdateForSubclassesTest < NoUpdateForSubclassesTestCase
+  def setup
+    super
+    @item_1, @item_2 = (1..2).map do |counter|
+      SubTodoItem.create!(position: counter)
+    end
+  end
+
+  def test_update
+    @item_1.update_attributes(position: 2)
+    assert_equal 2, @item_1.reload.position
+    assert_equal 1, @item_2.reload.position
+  end
+
+  def test_no_update_for_subclass_instances_with_no_update_on_superclass
+    TodoItem.acts_as_list_no_update { @item_1.update_attributes(position: 2) }
+
+    assert_equal 2, @item_1.reload.position
+    assert_equal 2, @item_2.reload.position
+  end
+
+  def test_no_update_for_subclass_instances_with_no_update_on_subclass
+    SubTodoItem.acts_as_list_no_update { @item_1.update_attributes(position: 2) }
+
+    assert_equal 2, @item_1.reload.position
+    assert_equal 2, @item_2.reload.position
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.9.14
+  version: 0.9.15
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-05 00:00:00.000000000 Z
+date: 2018-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -92,6 +92,7 @@ files:
 - test/test_list.rb
 - test/test_no_update_for_extra_classes.rb
 - test/test_no_update_for_scope_destruction.rb
+- test/test_no_update_for_subclasses.rb
 homepage: http://github.com/swanandp/acts_as_list
 licenses:
 - MIT
@@ -132,3 +133,4 @@ test_files:
 - test/test_list.rb
 - test/test_no_update_for_extra_classes.rb
 - test/test_no_update_for_scope_destruction.rb
+- test/test_no_update_for_subclasses.rb