acts_as_list 0.9.9 → 0.9.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6d2515099c8746c438ada6bfd3307841f7a66d7
-  data.tar.gz: 3d5980d4d52abd7957daef5f851caceb967fd7e1
+  metadata.gz: 6a5fd4ed86fc8761d3281f89b396aa5062d2efae
+  data.tar.gz: 5caf258018d36923b25c1cf4b21829b506de2feb
 SHA512:
-  metadata.gz: b9bc5985bcccdd1f02cd4f5f814d5abba57745c29c28ea158a95de849f4e36954a9a944919fbefe418af4518a32d58746a0427474a4055bbe44672d8e4b54e94
-  data.tar.gz: 048b80713d0cf58cbd717d337d58869ae0b5c09704c1a40a9503e6d05a4979be8ee517d9dc2c1877445d2c0194854f5c01a5ad220d8210414ca1ba80afed2fc6
+  metadata.gz: 206f7896be7a435f3330af74f2737256c1fd30a2a54ecd7900e369bec037e8a0317a14771d1cfe80405852a42bb6cd7570b518c9d43d98e18fc983b692a3f475
+  data.tar.gz: de4fd257055e8aa86e6bbf1c0aa5d9358b91592465cba7a44661219a916f94a68555b02dd33718a3a2e69e3b79f1533020317ad00043ce77f4bf071c72f57f65

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Change Log
 
+## [Unreleased](https://github.com/swanandp/acts_as_list/tree/HEAD)
+
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.9...HEAD)
+
+**Closed issues:**
+
+- Why does acts\_as\_list override rails validation on it's own field? [\#269](https://github.com/swanandp/acts_as_list/issues/269)
+
+## [v0.9.9](https://github.com/swanandp/acts_as_list/tree/v0.9.9) (2017-10-03)
+[Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.8...v0.9.9)
+
+**Merged pull requests:**
+
+- Added fixed values option for scope array [\#286](https://github.com/swanandp/acts_as_list/pull/286) ([hooverlunch](https://github.com/hooverlunch))
+
 ## [v0.9.8](https://github.com/swanandp/acts_as_list/tree/v0.9.8) (2017-09-28)
 [Full Changelog](https://github.com/swanandp/acts_as_list/compare/v0.9.7...v0.9.8)
 

data/lib/acts_as_list/active_record/acts/list.rb

@@ -234,7 +234,7 @@ module ActiveRecord
         # has been set manually using position=, not necessarily the top or bottom of the list:
 
         def add_to_list_top
-          if not_in_list? || internal_scope_changed? && !position_changed || default_position?
+          if assume_default_position?
             increment_positions_on_all_items
             self[position_column] = acts_as_list_top
           else
@@ -249,7 +249,7 @@ module ActiveRecord
         end
 
         def add_to_list_bottom
-          if not_in_list? || internal_scope_changed? && !position_changed || default_position?
+          if assume_default_position?
             self[position_column] = bottom_position_in_list.to_i + 1
           else
             increment_positions_on_lower_items(self[position_column], id)
@@ -262,6 +262,12 @@ module ActiveRecord
           true
         end
 
+        def assume_default_position?
+          not_in_list? ||
+          persisted? && internal_scope_changed? && !position_changed ||
+          default_position?
+        end
+
         # Overwrite this method to define the scope of the list changes
         def scope_condition() {} end
 

data/lib/acts_as_list/active_record/acts/no_update.rb

@@ -7,13 +7,13 @@ module ActiveRecord
           base.extend ClassMethods
         end
 
-        class ArrayTypeError < SyntaxError
+        class ArrayTypeError < ArgumentError
           def initialize
             super("The first argument must be an array")
           end
         end
 
-        class DisparityClassesError < NotImplementedError
+        class DisparityClassesError < ArgumentError
           def initialize
             super("The first argument should contain ActiveRecord or ApplicationRecord classes")
           end

data/lib/acts_as_list/version.rb

@@ -1,7 +1,7 @@
 module ActiveRecord
   module Acts
     module List
-      VERSION = '0.9.9'
+      VERSION = '0.9.10'
     end
   end
 end

data/test/shared_list.rb

@@ -124,6 +124,18 @@ module Shared
       assert_equal [$default_position, 1, 2, 3, 4, 5], pos_list
     end
 
+    def test_insert_at_after_dup
+      new1 = ListMixin.create(parent_id: 20)
+      new2 = ListMixin.create(parent_id: 20)
+      new3 = ListMixin.create(parent_id: 20)
+
+      duped = new1.dup
+      duped.save
+      [new1, new2, new3, duped].map(&:reload)
+
+      assert_equal [1, 2, 3, 4], [duped.pos, new1.pos, new2.pos, new3.pos]
+    end
+
     def test_delete_middle
       assert_equal [1, 2, 3, 4], ListMixin.where(parent_id: 5).order('pos').map(&:id)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.9.9
+  version: 0.9.10
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-03 00:00:00.000000000 Z
+date: 2017-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord