acts_as_footprintable 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5511b19bf736e594da831847c7e5680ed541f45
-  data.tar.gz: 587ada66643a68366b0099661d9a3f420f373f76
+  metadata.gz: '0836653de448c2d10bb14e4e2d3bd6f0dc584ce3'
+  data.tar.gz: f8a02be5d569784ff93fe363774e1e3de4fd8900
 SHA512:
-  metadata.gz: 1b3ee4db822262a0e47e15d49959b50552bb26b7c088163fb2006341e96fc62a5a897c2d48f2b5919eca9ca9eb7d2c070e05b34efd6ff0e7edaee0856c24e02c
-  data.tar.gz: 266229cf82bb0245dd70a330a527cff8619ef19734fdf59b4f010eadc383eb18336b5e7bd6b68f076e0b6acc9751ae1ebd1bc41425cf248fb07d6edd0d9db063
+  metadata.gz: a3b349f2dafb4fb541669e2944c9737c774ca75ac380cd578ddab47db8fb489d3b2209a228a334ec655d5dab3453191e7dbf9cbf9db85975d1d58568fe61ba6d
+  data.tar.gz: e61673ab9a1e77f4881ee3dbe6719319eba203b3d4d5e7a8fe77767a7702eb1ff8b22b4c3fd8af430fa89062c4b159a66c16cf933bc997442d9bb874a69f9e35

data/lib/acts_as_footprintable/footprinter.rb

@@ -41,6 +41,8 @@ module ActsAsFootprintable
       recent_footprints = target.group("#{table_name}.footprintable_id, #{table_name}.footprintable_type").
           select("#{table_name}.footprintable_id, #{table_name}.footprintable_type, MAX(#{table_name}.created_at) AS created_at")
       recent_footprints_conditions = recent_footprints.map{ |recent_footprint| recent_footprint.attributes.select{ |_, v| !v.nil?} }
+      return [] if recent_footprints_conditions.first.nil?
+
       columns = recent_footprints_conditions.first.keys.map{|column| "#{table_name}.#{column}" }.join(',')
       values = recent_footprints_conditions.map { |row|
         "(#{row.values.map{|value| ActiveRecord::Base::sanitize(value)}.join(',')})"

data/lib/acts_as_footprintable/version.rb

@@ -1,4 +1,4 @@
 # coding: utf-8
 module ActsAsFootprintable
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/footprinter_spec.rb

@@ -13,43 +13,50 @@ describe ActsAsFootprintable::Footprinter do
   end
 
   describe "ユーザーのアクセス履歴を" do
+    let!(:user_1) { User.create!(:name => "user_1") }
     before do
-      @user = User.create!(:name => "user")
       (1..5).each do |index|
         footprintable = Footprintable.create!(:name => "footprintable#{index}")
         second_footprintable = SecondFootprintable.create!(:name => "second_footprintable#{index}")
         3.times do
-          footprintable.leave_footprints @user
-          second_footprintable.leave_footprints @user
+          footprintable.leave_footprints user_1
+          second_footprintable.leave_footprints user_1
         end
       end
     end
 
     context "対象のモデル毎に" do
       it "取得できること" do
-        expect(@user.access_histories_for(Footprintable).count).to eq 5
-        expect(@user.access_histories_for(Footprintable).map{|footprint| footprint.footprintable.name}).to eq (1..5).to_a.reverse.map{|index| "footprintable#{index}"}
+        expect(user_1.access_histories_for(Footprintable).count).to eq 5
+        expect(user_1.access_histories_for(Footprintable).map{|footprint| footprint.footprintable.name}).to eq (1..5).to_a.reverse.map{|index| "footprintable#{index}"}
       end
 
       it "件数を絞り込めること" do
-        expect(@user.access_histories_for(Footprintable, 3).count).to eq 3
-        expect(@user.access_histories_for(Footprintable, 3).map{|footprint| footprint.footprintable.name}).to eq (3..5).to_a.reverse.map{|index| "footprintable#{index}"}
+        expect(user_1.access_histories_for(Footprintable, 3).count).to eq 3
+        expect(user_1.access_histories_for(Footprintable, 3).map{|footprint| footprint.footprintable.name}).to eq (3..5).to_a.reverse.map{|index| "footprintable#{index}"}
       end
     end
 
     context "全てのモデルを通じて" do
       it "取得できること" do
-        expect(@user.access_histories.count).to eq 10
+        expect(user_1.access_histories.count).to eq 10
         footprintable_names = (1..5).to_a.reverse.inject([]) do |results, index|
           results.push "second_footprintable#{index}"
           results.push "footprintable#{index}"
           results
         end
-        expect(@user.access_histories.map{|footprint| footprint.footprintable.name}).to eq footprintable_names
+        expect(user_1.access_histories.map{|footprint| footprint.footprintable.name}).to eq footprintable_names
       end
 
       it "件数を絞り込める事" do
-        expect(@user.access_histories(3).count).to eq 3
+        expect(user_1.access_histories(3).count).to eq 3
+      end
+    end
+
+    context 'アクセス履歴のないユーザーの場合' do
+      let!(:user_2) { User.create!(:name => "user_2") }
+      it '件数が0件であること' do
+        expect(user_2.access_histories_for(Footprintable).count).to eq 0
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_footprintable
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Toyoaki Oko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-10 00:00:00.000000000 Z
+date: 2017-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler