acts_as_feedable 1.0.0 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 116380fff364f58a7d7678b357567ba848dd8907
+  data.tar.gz: df7304ee85e6e67ee2f885f286303dceb4946c1b
+SHA512:
+  metadata.gz: cbc51c0326344b1fceb393f2d1575cf88fc3ec5bca20cf1cd75f58958bf9923779d65a0c8d6c9bed1018cb97782181380a773a0b0b1c61ae483706474f7a48b9
+  data.tar.gz: 4c5cd6c9380dd5907fd292c3ed6daaba159db8cbb77427548ae7af9f5d5e6837d8082e1819f46d697529397e477232765e1db821eb79fec2066f62e2da4e53ac

data/README.rdoc

@@ -41,7 +41,7 @@ When a feedable is deleted, one of three things happen:
 
 If the feedable is not being aggregated, there are two options:
 * We simply delete all related feeds to avoid problems that would occur because feed permissions are proxies of the destroyed object.
-* If the +keep_feeds_when_destroyed+ flag is set, we can add a destruction feed and inherit permissions from the feed's scoping object instead.
+* If a feed_initiator is set, we can add a destruction feed and inherit permissions from the feed's scoping object instead.
 
 == Assumptions
 

data/app/models/feed.rb

@@ -4,9 +4,9 @@ class Feed < ActiveRecord::Base
   belongs_to :feedable, :polymorphic => true
   belongs_to :scoping_object, :polymorphic => true
   
-  has_many :feed_aggregated_components, :dependent => :destroy, :order => 'feed_aggregated_components.updated_at DESC'
+  has_many :feed_aggregated_components, lambda { order 'feed_aggregated_components.updated_at DESC' }, :dependent => :destroy
   
-  default_scope order('feeds.updated_at DESC')
+  default_scope lambda { order('feeds.updated_at DESC') }
 
   # Used to group feeds by the day they occurred
   def date

data/lib/feedable/acts_as_feedable.rb

@@ -3,7 +3,6 @@ module Feedable #:nodoc:
     module ActMethod
       # Configuration options are:
       #
-      # * +keep_feeds_when_destroyed+ - specifies whether to keep the feeds when a feedable is destroyed. This should only be done if the feedable is public or is scoped to another feedable.
       # * +target_name+ - specifies how to get the name of the target (used by the view to store the name of the primary object the feed links to). (default is nil)
       # * +scoping_object?+ - Boolean - If true, this object will become the scoping object for all feedables descending from it. eg. a Project is a scoping object for all discussions, comments, and writeboards within the project.
       # * +parent+ - Specifies the code to execute to traverse up the feedable chain in search of any scoping objects
@@ -26,9 +25,7 @@ module Feedable #:nodoc:
         include InstanceMethods unless included_modules.include?(InstanceMethods)
         
         # Sanity Check
-        options.assert_valid_keys(:scoping_object?, :parent, :keep_feeds_when_destroyed, :target_name, :delegate, :aggregate)
-        
-        raise 'target_name option must be set if the keep_feeds_when_destroyed option is used' if options.key?(:keep_feeds_when_destroyed) && !options.key?(:target_name)
+        options.assert_valid_keys(:scoping_object?, :parent, :target_name, :delegate, :aggregate)
         
         options[:delegate].assert_valid_keys(:actions, :references) if options[:delegate].present?
         raise 'actions option must be set if the delegate option is used' if options[:delegate].is_a?(Hash) && options[:delegate][:actions].blank?
@@ -38,15 +35,11 @@ module Feedable #:nodoc:
         raise 'action option must be set if the aggregate option is used' if options[:aggregate].is_a?(Hash) && options[:aggregate][:action].blank?
         raise 'references option must be set if the aggregate option is used' if options[:aggregate].is_a?(Hash) && options[:aggregate][:references].blank?
         
-        options.reverse_merge!(:keep_feeds_when_destroyed => false, :delegate => {}, :aggregate => {})
+        options.reverse_merge!(:delegate => {}, :aggregate => {})
         
         self.feed_options = options
         
         class_eval <<-EOV
-        
-          def keep_feeds_when_destroyed?
-            #{options[:keep_feeds_when_destroyed]}
-          end
           
           def feedable
             if delegating?
@@ -93,8 +86,8 @@ module Feedable #:nodoc:
       def self.extended(base)
         base.after_create :add_created_feed
         base.after_update :add_updated_feed
-        base.before_destroy :setup_destroyed_feed_if_keeping_feeds
-        base.after_destroy :add_destroyed_feed, :destroy_scoped_feeds
+        base.before_destroy :add_destroyed_feed
+        base.after_destroy :destroy_scoped_feeds
         
         base.cattr_accessor :feed_options
         base.has_many :feeds, :as => :feedable
@@ -226,24 +219,23 @@ module Feedable #:nodoc:
       
       # Creates a feed about the deletion of the feedable. 
       # If the feed isn't aggregated then it deletes all existing feeds related to that object.
+      #
+      # Note: Create the destroyed feed before the feedable is destroyed so it gets the correct permission mappings
       def add_destroyed_feed                  
         if aggregating?
           update_aggregate_feed(:removed) if feed_initiator_id
         elsif delegating?
           create_feed_with_defaults(:action => delegate_action_for('destroyed')) if feed_initiator_id
-        elsif !keep_feeds_when_destroyed?
+        elsif feed_initiator_id
+          raise 'target_name option must be set when destroying with feed' unless self.class.feed_options.key?(:target_name)
+          create_feed_with_defaults(:action => 'destroyed')
+        else
           Feed.destroy_all(:feedable_type => self.class.to_s, :feedable_id => id)
         end
+
         clear_initiator
       end
       
-      # Create the destroyed feed before the feedable is destroyed so it gets the correct permission mappings
-      def setup_destroyed_feed_if_keeping_feeds
-        if keep_feeds_when_destroyed? && feed_initiator_id  
-          create_feed_with_defaults(:action => 'destroyed')
-        end
-      end
-      
       # Destroy all feeds which are scoped to the feedable.
       # This will prevent feeds from not rendering because the feedable has been destroyed.
       def destroy_scoped_feeds

data/lib/feedable/joinable_extensions.rb

@@ -25,12 +25,12 @@ module JoinableExtensions
 
   def self.extend_membership
     Membership.class_eval do
+      before_destroy :ensure_feed_creation
+
       acts_as_feedable :parent => 'joinable', :delegate => {:references => 'user', :actions => {:created => 'joined', :destroyed => 'left'}}
 
       private
 
-      before_destroy :ensure_feed_creation
-
       def ensure_feed_creation
         with_feed(initiator) if initiator.present?
       end
@@ -39,6 +39,9 @@ module JoinableExtensions
 
   def self.extend_membership_invitation
     MembershipInvitation.class_eval do
+      before_create :ensure_feed_creation
+      before_destroy :ensure_feed_creation
+
       acts_as_feedable :parent => 'joinable', :delegate => {:references => 'user', :actions => {:created => 'invited', :destroyed => 'cancelled_invite'}}
 
       attr_accessor :no_default_feed
@@ -55,9 +58,6 @@ module JoinableExtensions
         destroy_with_feed(user)
       end
 
-      before_create :ensure_feed_creation
-      before_destroy :ensure_feed_creation
-
       # Don't create a destroyed feed if the user is accepting a membership invitation or a membership request exists for this User.
       # In that case, a membership was created, and this invitation should be 'invisible' to the Users and the UI. Thus no feeds should be created.
       def ensure_feed_creation

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_feedable
 version: !ruby/object:Gem::Version
-  version: 1.0.0
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Ryan Wallace
@@ -10,8 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-30 00:00:00.000000000 Z
-dependencies: []
+date: 2013-08-09 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.0'
 description: Allows objects to create feeds which describe them. These feeds can then
   be used in a "Facebook-style" News Feed.
 email: technical@rrnpilot.org
@@ -27,26 +40,25 @@ files:
 - README.rdoc
 homepage: http://github.com/rrn/acts_as_feedable
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Allows objects to create feeds which describe them
 test_files: []