acts_as_featured 0.1.2 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b5abfb21cb04f69de8a6811788c18a486f94bcb8
+  data.tar.gz: 630a07ca79f5185b98262e9d56dfb097a39d403d
+SHA512:
+  metadata.gz: c6afbf45288be429b84f87ec319992cb8062cc1c67a842ea7d13d76215f56ae8fd44858ebfb2bedde134e5a757a65ef8ed23c445ef6fd4c05d49bed0ab044be1
+  data.tar.gz: 61c2269947d40967273026d52cfa124d3606372a060fd6364bbe51a4f906140af65affd58f561a4461a8ca575ec0dd0366ac1b95d6b397b591585cec4e0e3d82

data/Gemfile

@@ -1,8 +1,3 @@
-source :rubygems
-
-gem 'rspec', '~> 2.6.0'
-gem 'sqlite3'
-gem 'sqlite3-ruby', :require => 'sqlite3'
-gem 'activerecord', :require => 'active_record'
+source 'https://rubygems.org'
 
 gemspec

data/LICENSE.txt

@@ -0,0 +1,22 @@
+Copyright (c) 2015 Brandan Lennox
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.markdown

@@ -38,4 +38,4 @@ Make sure you run `bundle install` to get the development dependencies first.
 License
 -------
 
-See MIT-LICENSE.
+See LICENSE.txt.

data/acts_as_featured.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |s|
   s.files = %w{
     acts_as_featured.gemspec
     Gemfile
-    MIT-LICENSE
+    LICENSE.txt
     README.markdown
 
     lib/acts_as_featured.rb
@@ -32,8 +32,7 @@ Gem::Specification.new do |s|
 
   s.require_paths = ["lib"]
 
-  s.add_dependency "activerecord", ">= 3.0.0"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "sqlite3"
-  s.add_development_dependency "sqlite3-ruby"
+  s.add_dependency "activerecord", "~> 4.2.0"
+  s.add_development_dependency "rspec", "~> 3.2.0"
+  s.add_development_dependency "sqlite3", "~> 1.3.10"
 end

data/lib/acts_as_featured.rb

@@ -36,8 +36,8 @@ module ActsAsFeatured
       self.featured_attribute_scope = options[:scope] || false
 
       if scope_name = options[:create_scope]
-        scope_name = attribute if scope_name === true
-        scope scope_name, where(attribute => true).limit(1)
+        scope_name = attribute if scope_name == true
+        scope scope_name, -> { where(attribute => true).limit(1) }
       end
 
       before_save :remove_featured_from_other_records
@@ -52,15 +52,14 @@ private
   # featured, we should clear that status on other records before saving this one.
   def remove_featured_from_other_records
     if scope && send(featured_attribute)
-      # I hope I find a better way to do this
-      scope.update_all(["#{featured_attribute} = ?", false], "id != #{id || 0}")
+      scope.where.not(id: id || -1).update_all(featured_attribute => false)
     end
   end
 
   # <tt>after_save</tt> callback. If this save will result in no featured, just
   # make the first record featured.
   def add_featured_to_first_record
-    if scope && scope.count(:conditions => { featured_attribute => true }) == 0
+    if scope && scope.where(featured_attribute => true).none?
       scope.first.update_attribute(featured_attribute, true)
     end
   end
@@ -68,9 +67,9 @@ private
   # <tt>before_destroy</tt> callback. If we destroy the featured, make the first
   # unfeaturedmain the featured. If this was the last record, don't do anything.
   def add_featured_to_first_record_if_featured
-    if scope && send(featured_attribute) && scope.count > 1
-      new_main = scope.find(:first, :conditions => { featured_attribute => false })
-      new_main.update_attribute(featured_attribute, true) unless new_main.nil?
+    if scope && send(featured_attribute) && scope.many?
+      new_main = scope.where(featured_attribute => false).first
+      new_main.update(featured_attribute => true) if new_main
     end
   end
 

data/lib/acts_as_featured/version.rb

@@ -1,3 +1,3 @@
 module ActsAsFeatured
-  VERSION = '0.1.2'
+  VERSION = '0.2.0'
 end

data/spec/acts_as_featured_spec.rb

@@ -1,8 +1,8 @@
-require File.join(File.dirname(__FILE__), 'spec_helper')
+require 'spec_helper'
 
-describe ActsAsFeatured do
+RSpec.describe ActsAsFeatured do
   def featured(model)
-    model.find_all_by_featured(true)
+    model.where(featured: true)
   end
 
   describe "unscoped" do
@@ -16,9 +16,9 @@ describe ActsAsFeatured do
 
     it 'should leave featured status alone when saving the currently featured thingy' do
       originally_featured = Thingy.create(:featured => true)
-      featured(Thingy).first.should == originally_featured
+      expect(featured(Thingy).first).to eq(originally_featured)
       originally_featured.save
-      featured(Thingy).first.should == originally_featured
+      expect(featured(Thingy).first).to eq(originally_featured)
     end
 
     it 'should remove featured status from the currently featured thingy when setting it on another thingy' do
@@ -31,9 +31,9 @@ describe ActsAsFeatured do
       originally_featured.reload
       will_be_featured.reload
 
-      featured(Thingy).should have(1).item
-      originally_featured.featured?.should be_false
-      will_be_featured.featured?.should be_true
+      expect(featured(Thingy).count).to eq(1)
+      expect(originally_featured).not_to be_featured
+      expect(will_be_featured).to be_featured
     end
 
     it 'should set another thingy to be featured when removing featured status from the featured thingy' do
@@ -44,8 +44,8 @@ describe ActsAsFeatured do
       originally_featured.save!
       originally_featured.reload
 
-      featured(Thingy).should have(1).item
-      originally_featured.featured?.should be_false
+      expect(featured(Thingy).count).to eq(1)
+      expect(originally_featured).not_to be_featured
     end
 
     it 'should set another thingy to be featured when destroying the featured thingy' do
@@ -54,7 +54,7 @@ describe ActsAsFeatured do
 
       originally_featured.destroy
 
-      featured(Thingy).should have(1).item
+      expect(featured(Thingy).count).to eq(1)
     end
   end
 
@@ -73,35 +73,35 @@ describe ActsAsFeatured do
       f1 = aggregator1.scoped_thingies.create(:featured => true)
       f2 = aggregator2.scoped_thingies.create(:featured => true)
 
-      featured(ScopedThingy).should have(2).items
+      expect(featured(ScopedThingy).count).to eq(2)
 
-      f1.update_attribute(:featured, false)
+      f1.update_attributes(:featured => false)
 
-      featured(ScopedThingy).should have(2).items
-      aggregator2.scoped_thingies.find_by_featured(true).should == f2
+      expect(featured(ScopedThingy).count).to eq(2)
+      expect(aggregator2.scoped_thingies.find_by_featured(true)).to eq(f2)
     end
 
     it 'should not explode when the scope is nil' do
       expect {
         ScopedThingy.create!(:featured => true)
-        featured(ScopedThingy).should have(1).item
+        expect(featured(ScopedThingy).count).to eq(1)
       }.not_to raise_error
     end
   end
 
   describe "named scope" do
     it 'should add a default named scope' do
-      DefaultNamedScopeThingy.should respond_to(:featured)
+      expect(DefaultNamedScopeThingy).to respond_to(:featured)
     end
 
     it 'should add a custom named scope' do
-      CustomNamedScopeThingy.should respond_to(:special)
+      expect(CustomNamedScopeThingy).to respond_to(:special)
     end
 
     it 'should return the featured thingy from the named scope' do
       3.times { DefaultNamedScopeThingy.create!(:featured => false) }
       t = DefaultNamedScopeThingy.create!(:featured => true)
-      DefaultNamedScopeThingy.featured.first.should == t
+      expect(DefaultNamedScopeThingy.featured.first).to eq(t)
     end
   end
 end

data/spec/models.rb

@@ -33,7 +33,7 @@ ActiveRecord::Schema.define(:version => 1) do
   end
 
   create_table :thingy_aggregators, :force => true do |t|
-    t.timestamps
+    t.timestamps null: false
   end
 
   create_table :scoped_thingies, :force => true do |t|

metadata

@@ -1,94 +1,69 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: acts_as_featured
-version: !ruby/object:Gem::Version 
-  hash: 31
-  prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 2
-  version: 0.1.2
+version: !ruby/object:Gem::Version
+  version: 0.2.0
 platform: ruby
-authors: 
+authors:
 - Brandan Lennox
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-01-28 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-01-28 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activerecord
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        - 0
-        version: 3.0.0
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.2.0
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 4.2.0
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.2.0
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: sqlite3
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.10
   type: :development
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: sqlite3-ruby
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  type: :development
-  version_requirements: *id004
-description: Designates an attribute on this model to indicate "featuredness," where only one record within a given scope may be featured at a time.
-email: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.3.10
+description: Designates an attribute on this model to indicate "featuredness," where
+  only one record within a given scope may be featured at a time.
+email:
 - brandan@bclennox.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- acts_as_featured.gemspec
+files:
 - Gemfile
-- MIT-LICENSE
+- LICENSE.txt
 - README.markdown
+- acts_as_featured.gemspec
 - lib/acts_as_featured.rb
 - lib/acts_as_featured/version.rb
 - spec/acts_as_featured_spec.rb
@@ -96,38 +71,28 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/bclennox/acts_as_featured
 licenses: []
-
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: acts_as_featured
-rubygems_version: 1.8.15
+rubygems_version: 2.4.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Designate a Rails model attribute as unique within a scope
-test_files: 
+test_files:
 - spec/acts_as_featured_spec.rb
 - spec/models.rb
 - spec/spec_helper.rb

data/MIT-LICENSE

@@ -1,21 +0,0 @@
-The MIT License
-
-Copyright (c) 2009 Brandan Lennox
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.