acts_as_favoritor 4.0.2 → 4.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba4bae7bff5166a5903eccb9ed03fdc8905844309dac8b509d805dc945f09a4e
-  data.tar.gz: 61061b39d5f29094fe329c00aac91df4988667522c945f859c4762381da4a117
+  metadata.gz: 45ca952d9906033e84ecc6ff24aca3934457d803c51f979d59c561847b1d61d6
+  data.tar.gz: 941c85b77b52b66360a6ba7df70227c2e7cc32fc5fe0230f6191e2d20e6afd3e
 SHA512:
-  metadata.gz: eb97712eb98769614cd99a910633ec0b397feec7d55282f42884915c8246732f0b1b611ace2dae13c5360c998ba49f3ac02b0c9a8a7421b9ac2a3e57714493e0
-  data.tar.gz: 726d2a2aec78589821dabc017d5f53b8a142d961a3caa21eae436d5d6cbda4b231d613305ae8099aae4340addc09be508b68d09479b104d199c3fc586ec1c0cc
+  metadata.gz: bae098e81f7b219469fd3e2a18446914f46fe9ba65edc58f8f36ecd1ade9393f9a877ea8b96795abb4bd7324357fac01bdf2910a630a58828b9c5a984914076c
+  data.tar.gz: 0adfa2859658a591c472279295197c7c97bf3af1157210e992fafa384fc0dd083c6e7f3b791395b84e0638b25ff25c8ab25a20ee04996ec1975fe75df0b0b1f1

data/README.md

@@ -1,7 +1,5 @@
 # acts_as_favoritor
 
-[![Gem Version](https://badge.fury.io/rb/acts_as_favoritor.svg)](https://badge.fury.io/rb/acts_as_favoritor) ![Travis](https://travis-ci.org/jonhue/acts_as_favoritor.svg?branch=master)
-
 acts_as_favoritor is a Rubygem to allow any ActiveRecord model to associate any other model including the option for multiple relationships per association with scopes.
 
 You are able to differentiate followers, favorites, watchers, votes and whatever else you can imagine through a single relationship. This is accomplished by a double polymorphic relationship on the Favorite model. There is also built in support for blocking/un-blocking favorite records as well as caching.
@@ -20,6 +18,7 @@ You are able to differentiate followers, favorites, watchers, votes and whatever
   * [Caching](#caching)
 * [Configuration](#configuration)
 * [Testing](#testing)
+* [Release](#release)
 * [To do](#to-do)
 * [Contributing](#contributing)
   * [Semantic versioning](#semantic-versioning)
@@ -263,8 +262,6 @@ end
 
 ## Testing
 
-Tests are written with Shoulda on top of `Test::Unit` with Factory Girl being used instead of fixtures. Tests are run using rake.
-
 1. Fork this repository
 2. Clone your forked git locally
 3. Install dependencies
@@ -281,6 +278,17 @@ Tests are written with Shoulda on top of `Test::Unit` with Factory Girl being us
 
 ---
 
+## Release
+
+1. Review breaking changes and deprecations in `CHANGELOG.md`
+2. Change the gem version in `lib/acts_as_favoritor/version.rb`
+3. Reset `CHANGELOG.md`
+4. Create a pull request to merge the changes into `master`
+5. After the pull request was merged, create a new release listing the breaking changes and commits on `master` since the last release.
+6. The release workflow will publish the gems to RubyGems and the GitHub Package Registry
+
+---
+
 ## To do
 
 We use [GitHub projects](https://github.com/jonhue/acts_as_favoritor/projects/1) to coordinate the work on this project.

data/lib/acts_as_favoritor/favoritor.rb

@@ -151,9 +151,9 @@ module ActsAsFavoritor
 
         favoritable.favoritable_score[scope] =
           (favoritable.favoritable_score[scope] || 0) - 1
-        # rubocop:disable Metrics/LineLength
-        favoritable.favoritable_score.delete(scope) unless favoritable.favoritable_score[scope].positive?
-        # rubocop:enable Metrics/LineLength
+        unless favoritable.favoritable_score[scope].positive?
+          favoritable.favoritable_score.delete(scope)
+        end
         favoritable.save!
       end
       # rubocop:enable Metrics/AbcSize

data/lib/acts_as_favoritor/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ActsAsFavoritor
-  VERSION = '4.0.2'
+  VERSION = '4.0.3'
 end

data/lib/generators/acts_as_favoritor_generator.rb

@@ -13,7 +13,8 @@ class ActsAsFavoritorGenerator < Rails::Generators::Base
     if ActiveRecord::Base.timestamped_migrations
       Time.now.utc.strftime('%Y%m%d%H%M%S')
     else
-      format('%.3d', current_migration_number(dirname) + 1)
+      format('%<migration_number>.3d',
+             migration_number: current_migration_number(dirname) + 1)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_favoritor
 version: !ruby/object:Gem::Version
-  version: 4.0.2
+  version: 4.0.3
 platform: ruby
 authors:
 - Jonas Hübotter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-17 00:00:00.000000000 Z
+date: 2019-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -159,7 +159,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="