acts_as_executor 1.0.0.rc3 → 1.0.0.rc5

data/README.markdown

@@ -1,6 +1,6 @@
 # acts_as_executor
 
-acts_as_executor seamlessly integrates Java’s Executor framework with JRuby on Rails, enabling an application to use executors in a familiar Rails’eque way.
+acts_as_executor seamlessly integrates Java’s Executor framework with Ruby on Rails, enabling an application to use executors in a familiar Rails’eque way.
 
 [RubyGems][ruby_gems] | [GitHub][github] | [Travis CI][travis_ci] | [RubyDoc][ruby_doc] | [Wiki][wiki]
 

data/acts_as_executor.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.email       = ["philostler@gmail.com"]
   s.homepage    = "https://github.com/philostler/acts_as_executor"
   s.summary     = %q{Java Executor framework integration for Rails}
-  s.description = %q{Seamlessly integrates Java's Executor framework with JRuby on Rails}
+  s.description = %q{Seamlessly integrates Java's Executor framework with Ruby on Rails}
 
   s.files = Dir[".rspec"] +
             Dir["acts_as_executor.gemspec"] +

data/lib/acts_as_executor/executor/model/instance_methods.rb

@@ -13,6 +13,7 @@ module ActsAsExecutor
 
           # Validations
           base.validates :name, :presence => true, :uniqueness => true
+          base.validates :max_tasks, :presence => true, :if => :schedulable?
           base.validates :max_tasks, :numericality => { :only_integer => true, :greater_than_or_equal_to => 1 }, :allow_nil => true
         end
 

data/lib/acts_as_executor/task/model/instance_methods.rb

@@ -31,8 +31,8 @@ module ActsAsExecutor
             instance = instantiate executable, arguments
 
             self.future = executor.send(:execute, instance, id.to_s, schedule, start, every, units)
-            future.done_handler = method :done_handler
-          rescue Exception => exception
+            future.done_handler = method :done_handler unless executor.send(:schedulable?)
+          rescue RuntimeError => exception
             executor.send(:log).error log_message executor.name, "creating", id.to_s, executable, "encountered an unexpected exception. " + exception.to_s
           end
         end

data/lib/acts_as_executor/version.rb

@@ -1,3 +1,3 @@
 module ActsAsExecutor
-  VERSION = "1.0.0.rc3"
+  VERSION = "1.0.0.rc5"
 end

data/spec/acts_as_executor_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe ActsAsExecutor do
-	it { ActsAsExecutor::VERSION.should == "1.0.0.rc3" }
+	it { ActsAsExecutor::VERSION.should == "1.0.0.rc5" }
 
   describe "#rails_initialized?" do
     context "when rails initialized" do

data/spec/support/blueprints.rb

@@ -2,9 +2,10 @@ InstanceSupportMethods.blueprint do
 end
 
 Executor.blueprint do
-  id        { "#{sn}" }
-  name      { "name#{sn}" }
-  max_tasks { 1 }
+  id          { "#{sn}" }
+  name        { "name#{sn}" }
+  max_tasks   { 1 }
+  schedulable { false }
 end
 
 ExecutorTask.blueprint do

data/spec/task/model/instance_methods_spec.rb

@@ -23,7 +23,33 @@ describe ActsAsExecutor::Task::Model::InstanceMethods do
       @model.send(:future).should == future
     end
 
-    context "when any exception is thrown" do
+    it "should set done handler on future" do
+      future = double "Future"
+      future.stub :done_handler=
+
+      @model.should_receive(:instantiate).and_return @executable
+      @model.executor.should_receive(:execute).with(@executable, @model.id.to_s, @model.schedule, @model.start, @model.every, @model.units).and_return future
+      future.should_receive(:done_handler=).with @model.method(:done_handler)
+
+      @model.send :enqueue
+    end
+
+    context "when executor is schedulable" do
+      before(:each) { @model = ExecutorTask.make(:executor => Executor.make(:schedulable => true)) }
+
+      it "should not set done handler on future" do
+        future = double "Future"
+        future.stub :done_handler=
+
+        @model.should_receive(:instantiate).and_return @executable
+        @model.executor.should_receive(:execute).with(@executable, @model.id.to_s, @model.schedule, @model.start, @model.every, @model.units).and_return future
+        future.should_not_receive :done_handler=
+
+        @model.send :enqueue
+      end
+    end
+
+    context "when runtime exception is thrown" do
       it "should log exception" do
         exception = RuntimeError.new
 

metadata

@@ -2,7 +2,7 @@
 name: acts_as_executor
 version: !ruby/object:Gem::Version 
   prerelease: 6
-  version: 1.0.0.rc3
+  version: 1.0.0.rc5
 platform: ruby
 authors: 
   - Phil Ostler
@@ -10,7 +10,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-22 00:00:00 Z
+date: 2011-10-24 00:00:00 +01:00
+default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
     name: activemodel
@@ -67,7 +68,7 @@ dependencies:
             version: "2.6"
     type: :development
     version_requirements: *id005
-description: Seamlessly integrates Java's Executor framework with JRuby on Rails
+description: Seamlessly integrates Java's Executor framework with Ruby on Rails
 email: 
   - philostler@gmail.com
 executables: []
@@ -125,6 +126,7 @@ files:
   - spec/task/model/instance_support_methods_spec.rb
   - spec/validators/class_exists_validator_spec.rb
   - spec/validators/class_subclasses_validator_spec.rb
+has_rdoc: true
 homepage: https://github.com/philostler/acts_as_executor
 licenses: []
 
@@ -148,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.5.1
 signing_key: 
 specification_version: 3
 summary: Java Executor framework integration for Rails