acts_as_elo 0.2.0 → 1.0.0

data/README.md

@@ -29,6 +29,6 @@ bob.elo_rank # => 1200
 jack.elo_rank # => 1200
 
 bob.elo_win!(jack)
-bob.elo_rank # => 1205
-jack.elo_rank # => 1995
+bob.elo_rank # => 1215
+jack.elo_rank # => 1985
 ```

data/acts_as_elo.gemspec

@@ -2,7 +2,7 @@
 $:.push File.expand_path('../lib', __FILE__)
 Gem::Specification.new do |s|
   s.name        = 'acts_as_elo'
-  s.version     = '0.2.0'
+  s.version     = '1.0.0'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['tjbladez']
   s.email       = ['nick@tjbladez.net']

data/lib/acts_as_elo/acts/elo.rb

@@ -10,8 +10,16 @@ module Acts
       # Available options are:
       # * default_rank - change the starting rank
       # * one_way - limits update of the rank to only self
+      # * proficiency_map - hash that has two keys
+      #    * rank_limits  - array of two elements, ranks that limit categories of
+      #                     player proficiency. Between novice and intermediate; intermediate and pro.
+      #                     Defaults: 1299, 2399
+      #    * coefficients - proficiency coefficient for each category.
+      #                     Defaults: 30 for novice, 15 for intermediate, 10 for a pro
       def acts_as_elo(opts = {})
-        default_rank =  opts[:default_rank] || 1200
+        default_rank    =  opts[:default_rank] || 1200
+        proficiency_map =  opts[:proficiency_map] || {:coefficients => [30, 15, 10],
+                                                      :rank_limits  => [1299, 2399] }
 
         unless opts.empty?
           class << self
@@ -33,7 +41,10 @@ module Acts
             define_method(:elo_rank) do
               @elo_rank ||= default_rank
             end
+          end
 
+          define_method(:elo_proficiency_map) do
+            proficiency_map
           end
         end
 
@@ -63,8 +74,17 @@ module Acts
           send_opts = {one_way: true}
 
           # Formula from: http://en.wikipedia.org/wiki/Elo_rating_system
-          diff      = (opponent.elo_rank.to_f - elo_rank.to_f).abs
-          expected  = 1 / (1 + 10 ** (diff / 400))
+          diff        = opponent.elo_rank.to_f - elo_rank.to_f
+          expected    = 1 / (1 + 10 ** (diff / 400))
+          coefficient = elo_proficiency_map[:coefficients][1]
+
+          if elo_rank < elo_proficiency_map[:rank_limits].first
+            coefficient = elo_proficiency_map[:coefficients].first
+          end
+
+          if elo_rank > elo_proficiency_map[:rank_limits].last
+            coefficient = elo_proficiency_map[:coefficients].last
+          end
 
           if opts[:result] == :win
             points = 1
@@ -79,7 +99,7 @@ module Acts
 
           opponent.elo_update(self, send_opts) unless one_way
 
-          self.elo_rank = (elo_rank + 10*(points-expected)).round
+          self.elo_rank = (elo_rank + coefficient*(points-expected)).round
         rescue Exception => e
           puts "Exception: #{e.message}"
         end

data/test/advance_test.rb

@@ -31,15 +31,55 @@ context "User with many questions" do
     hookup { topic.questions.each {|q| q.elo_rank = 1200 }}
     hookup { topic.questions.first.elo_lose!(topic)}
 
-    asserts(:elo_rank).equals(1205)
-    asserts("questions have their ranks updated"){ topic.questions.map(&:elo_rank)}.equals([1195, 1200])
+    asserts(:elo_rank).equals(1215)
+    asserts("questions have their ranks updated"){ topic.questions.map(&:elo_rank)}.equals([1185, 1200])
   end
 
   context "when question is answered incorrectly" do
     hookup { topic.questions.each {|q| q.elo_rank = 1200 }}
     hookup { topic.questions.first.elo_win!(topic) }
 
-    asserts(:elo_rank).equals(1195)
-    asserts("questions have their ranks updated"){ topic.questions.map(&:elo_rank)}.equals([1205, 1200])
+    asserts(:elo_rank).equals(1185)
+    asserts("questions have their ranks updated"){ topic.questions.map(&:elo_rank)}.equals([1215, 1200])
   end
-end
+end
+
+class ProfessionalPlayer
+  include Acts::Elo
+  acts_as_elo :default_rank => 2400
+end
+
+class IntermediatePlayer
+  include Acts::Elo
+  acts_as_elo :default_rank => 2000
+end
+
+context "Professional playing against the intermediate player" do
+  setup { [ProfessionalPlayer.new, IntermediatePlayer.new] }
+
+  asserts("default ranks are 2500 and 1200") {
+    topic.map(&:elo_rank)
+  }.equals([2400, 2000])
+
+  context "when professional wins" do
+    hookup {topic.first.elo_rank = 2400}
+    hookup {topic.last.elo_rank = 2000}
+
+    hookup {topic.first.elo_win!(topic.last)}
+
+    asserts("professional is barely rewarded") {topic.first.elo_rank}.equals(2401)
+    asserts("intermediate barely loses rank") {topic.last.elo_rank}.equals(1999)
+  end
+  context "when intermediate player wins" do
+    hookup {topic.first.elo_rank = 2400}
+    hookup {topic.last.elo_rank = 2000}
+
+    hookup {topic.last.elo_win!(topic.first)}
+
+    asserts("professional loses some rank") {topic.first.elo_rank}.equals(2391)
+    asserts("intermediate rewarded greatly") {topic.last.elo_rank}.equals(2014)
+  end
+end
+
+
+

data/test/basic_test.rb

@@ -3,14 +3,14 @@ require Pathname.new('.') + 'helper'
 
 class Player
   include Acts::Elo
-  
+
   acts_as_elo
 end
 
 
 context "Two players are opponents of each other" do
   setup { [Player.new, Player.new] }
-  
+
   asserts("default ranks are 1200") {
     topic.map(&:elo_rank)
   }.equals([1200, 1200])
@@ -18,21 +18,21 @@ context "Two players are opponents of each other" do
   context "when first one wins" do
     hookup {topic.each {|pl| pl.elo_rank = 1200 }}
     hookup {topic.first.elo_win!(topic.last)}
-    
-    asserts("ranks are updated") {topic.map(&:elo_rank)}.equals([1205, 1195])
+
+    asserts("ranks are updated") {topic.map(&:elo_rank)}.equals([1215, 1185])
   end
 
   context "when first one loses" do
-    hookup {topic.each {|pl| pl.elo_rank = 1200 }}    
+    hookup {topic.each {|pl| pl.elo_rank = 1200 }}
     hookup {topic.first.elo_lose!(topic.last)}
-    
-    asserts("ranks are updated") {topic.map(&:elo_rank)}.equals([1195, 1205])
+
+    asserts("ranks are updated") {topic.map(&:elo_rank)}.equals([1185, 1215])
   end
 
   context "when they draw" do
-    hookup {topic.each {|pl| pl.elo_rank = 1200 }}    
+    hookup {topic.each {|pl| pl.elo_rank = 1200 }}
     hookup {topic.first.elo_draw!(topic.last)}
-    
+
     asserts("ranks are updated") {topic.map(&:elo_rank)}.equals([1200, 1200])
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_elo
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-09 00:00:00.000000000Z
+date: 2012-03-12 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70327763632440 !ruby/object:Gem::Requirement
+  requirement: &70227977617200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70327763632440
+  version_requirements: *70227977617200
 - !ruby/object:Gem::Dependency
   name: riot
-  requirement: &70327763631380 !ruby/object:Gem::Requirement
+  requirement: &70227977616580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70327763631380
+  version_requirements: *70227977616580
 description: Provides sophisticated yet easy to understand ranking system with minimum
   changes to the system
 email: