acts_as_dag 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a7a921e4428cd9076f8185484e4ba74d1be9f39
-  data.tar.gz: bb3b20517f05e2b7c0ab292e3339be5439ca67a4
+  metadata.gz: 20958e9a99961c9a9e024c2a38d0ca18f2d4edf9
+  data.tar.gz: 47fa5205930fda7ef2d272060c1fd762ed5ac5eb
 SHA512:
-  metadata.gz: 60def06e6d20971d87279cfead7e62a71095065249f57f33ecdedd87d4c449c4eea3ee3281b396866e6f47cdf7b98f0e8b1f6c2f9abc2c6acd5115c869c34299
-  data.tar.gz: 1207ee4bb868befd019226da0c3427e40f890a549153f6bdae623b119b54a6111e7c78df6b5b25070da9c2b647950ec77b70d5cca873756c3c98f923eb9aa31f
+  metadata.gz: ee43e1f45b2e1a342d68af770fd77dacdababb279e1cf304ecc77c4273c523ba20084faf6a36b682933b337db6dafcd856f792cf28f7188d42223e149bbd9679
+  data.tar.gz: 674b7382f83397b73749a83487454302ccc1a1b9c086141c7fc63d5efd58d1dd53fd46ac4c81510a127c6c8e03c473c788d0101e01f62e0b4ecde334b614334e

data/README.rdoc

@@ -3,3 +3,26 @@
 Adds Directed Acyclic Graph functionality to ActiveRecord
 
 Used by RRN data mapper to setup link and descendant database tables
+
+## Installation
+
+### Migration
+
+```ruby
+class CreateActsAsDagTables < ActiveRecord::Migration
+  def change
+    create_table "acts_as_dag_descendants", :force => true do |t|
+      t.string :category_type
+      t.references :ancestor
+      t.references :descendant
+      t.integer :distance
+    end
+
+    create_table "acts_as_dag_links", :force => true do |t|
+      t.string :category_type
+      t.references :parent
+      t.references :child
+    end
+  end
+end
+```

data/lib/acts_as_dag/acts_as_dag.rb

@@ -56,11 +56,11 @@ module ActsAsDAG
       #  \ /
       #   D
       #
-      has_many :ancestors,        lambda { order("#{descendant_class.table_name}.distance DESC") }, :through => :ancestor_links, :source => :ancestor
-      has_many :descendants,      lambda { order("#{descendant_class.table_name}.distance ASC") }, :through => :descendant_links, :source => :descendant
+      has_many :ancestors,        :through => :ancestor_links, :source => :ancestor
+      has_many :descendants,      :through => :descendant_links, :source => :descendant
 
-      has_many :ancestor_links,   lambda { where options[:link_conditions] }, :class_name => descendant_class, :foreign_key => 'descendant_id', :dependent => :delete_all
-      has_many :descendant_links, lambda { where options[:link_conditions] }, :class_name => descendant_class, :foreign_key => 'ancestor_id', :dependent => :delete_all
+      has_many :ancestor_links,   lambda { where(options[:link_conditions]).order("distance DESC") }, :class_name => descendant_class, :foreign_key => 'descendant_id', :dependent => :delete_all
+      has_many :descendant_links, lambda { where(options[:link_conditions]).order("distance ASC") }, :class_name => descendant_class, :foreign_key => 'ancestor_id', :dependent => :delete_all
 
       has_many :parents,          :through => :parent_links, :source => :parent
       has_many :children,         :through => :child_links, :source => :child

data/spec/acts_as_dag_spec.rb

@@ -86,15 +86,15 @@ describe 'acts_as_dag' do
         @dad.add_child(@child)
         @grandpa.add_child(@dad)
 
-        @grandpa.ancestor_of?(@child).should be_true
-        @child.descendant_of?(@grandpa).should be_true
-        @child.ancestor_of?(@grandpa).should be_false
-        @grandpa.descendant_of?(@child).should be_false
+        @grandpa.ancestor_of?(@child).should be_truthy
+        @child.descendant_of?(@grandpa).should be_truthy
+        @child.ancestor_of?(@grandpa).should be_falsy
+        @grandpa.descendant_of?(@child).should be_falsy
       end
 
       it "should be a root node immediately after saving" do
         @grandpa.parents.should be_empty
-        @grandpa.root?.should be_true
+        @grandpa.root?.should be_truthy
       end
 
       it "should be a child if it has a parent" do
@@ -153,8 +153,8 @@ describe 'acts_as_dag' do
       end
 
       it "should be able to determine whether one category is an ancestor of the other by inspecting the name" do
-        ActsAsDAG::HelperMethods.should_descend_from?(@totem_pole, @big_totem_pole).should be_true
-        ActsAsDAG::HelperMethods.should_descend_from?(@big_totem_pole, @totem_pole).should be_false
+        ActsAsDAG::HelperMethods.should_descend_from?(@totem_pole, @big_totem_pole).should be_truthy
+        ActsAsDAG::HelperMethods.should_descend_from?(@big_totem_pole, @totem_pole).should be_falsy
       end
 
       it "should be able to determine the number of matching words in two categories names" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_dag
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Nicholas Jakobsen
@@ -56,7 +56,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Adds directed acyclic graph functionality to ActiveRecord.