acts_as_brand_new_copy 1.0.0 → 1.0.1

data/.travis.yml

@@ -1,5 +1,9 @@
 language: ruby
 rvm:
-  - "1.8.7"
   - "1.9.3"
+  - "2.0.0"
 script: bundle exec rspec spec
+before_install:
+  - curl -O http://mirrors.kernel.org/ubuntu/pool/main/s/sqlite3/libsqlite3-0_3.7.13-1_amd64.deb
+  - curl -O http://mirrors.kernel.org/ubuntu/pool/main/s/sqlite3/sqlite3_3.7.13-1_amd64.deb
+  - sudo dpkg -i libsqlite3-0_3.7.13-1_amd64.deb sqlite3_3.7.13-1_amd64.deb

data/README.md

@@ -5,24 +5,9 @@
 
 Copy an active record with its associated records are not easy.
 
-For example, if we have defined these classes:
+For example, if we have defined following classes:
 
 ```ruby
-class StudentTeacherAssignment < ActiveRecord::Base
-  belongs_to :teacher
-  belongs_to :student
-end
-
-class GradeTeacherAssignment < ActiveRecord::Base
-  belongs_to :grade
-  belongs_to :teacher
-end
-
-class GradeStudentAssignment < ActiveRecord::Base
-  belongs_to :grade
-  belongs_to :student
-end
-
 class Grade < ActiveRecord::Base
   has_and_belongs_to_many :teachers, :join_table => ::GradeTeacherAssignment.table_name
   has_and_belongs_to_many :students, :join_table => ::GradeStudentAssignment.table_name
@@ -48,7 +33,7 @@ class Score < ActiveRecord::Base
 end
 ```
 
-Can you copy a grade with its teachers and students to another grade in a few lines of code?
+Can you copy a grade with its teachers and students to another grade in a few lines of code, keeping the relationships between teachers and students?
 To me, it's no, consequently acts_as_brand_new_copy was born.
 
 ## Usage

data/lib/acts_as_brand_new_copy.rb

@@ -5,18 +5,16 @@ module ActsAsBrandNewCopy
 
   class BrandNewCopyBuilder
 
-    def initialize(hash_origin, hash_copy)
-      @hash_origin  = hash_origin
-      @hash_copy    = hash_copy
+    def initialize(serialized_hash)
+      @hash_origin  = serialized_hash
+      @hash_copy    = JSON.parse(serialized_hash.to_json) # a way to do deep clone
       @save_order   = calculate_save_order
       @instances    = extract_instances
       @queue        = prepare_copy_queue
       @full_context = {
-        :root_hash_origin => @hash_origin,
-        :root_hash_copy   => @hash_copy,
-        :save_order       => @save_order,
-        :save_queue       => @queue,
-        :instances        => @instances
+        :save_order => @save_order,
+        :save_queue => @queue,
+        :instances  => @instances
       }
     end
 
@@ -44,6 +42,13 @@ module ActsAsBrandNewCopy
       @instances.values
     end
 
+    def new_id(klass_name, old_id)
+      copy_object = find_object_by_old_id(klass_name, old_id)
+      return nil if copy_object.nil?
+      raise 'copy object not saved to db!' if copy_object['id'] == copy_object['id_before_copy']
+      copy_object['id']
+    end
+
     private
 
     def invoke_callback_recursively(hash_origin_array, callbacks)
@@ -203,7 +208,7 @@ module ActsAsBrandNewCopy
 
     def do_insert(klass, columns, hash_copies)
       connection = klass.connection
-      values_string = hash_copies.map do |hash_copy|
+      value_list = hash_copies.map do |hash_copy|
         quoted_copy_values = columns.map do |column|
           case column.name
           when 'updated_at', 'created_at'
@@ -212,9 +217,12 @@ module ActsAsBrandNewCopy
             connection.quote(hash_copy[column.name], column)
           end
         end
-        "(#{quoted_copy_values.join(',')})"
-      end.join(',')
-      result = connection.execute("INSERT INTO #{klass.table_name} (#{columns.map(&:name).join(',')}) VALUES #{values_string}")
+        "(#{quoted_copy_values.join(', ')})"
+      end
+      column_list = columns.map do |column|
+        connection.quote_column_name(column.name)
+      end
+      result = connection.execute("INSERT INTO #{connection.quote_table_name(klass.table_name)} (#{column_list.join(', ')}) VALUES #{value_list.join(', ')}")
       connection.last_inserted_id(result)
     end
 
@@ -245,13 +253,6 @@ module ActsAsBrandNewCopy
       @instances[object_key(klass_name, old_id)]
     end
 
-    def new_id(klass_name, old_id)
-      copy_object = find_object_by_old_id(klass_name, old_id)
-      return nil if copy_object.nil?
-      raise 'copy object not saved to db!' if copy_object['id'] == copy_object['id_before_copy']
-      copy_object['id']
-    end
-
     def update_object_by_old_id(klass_name, old_id, new_attributes)
       copy_object = find_object_by_old_id(klass_name, old_id)
       new_attributes.each_pair do |key, value|
@@ -425,14 +426,13 @@ module ActsAsBrandNewCopy
 
     eager_loaded_self = self.class.includes(final_options[:associations]).find(id)
 
-    hash_origin = eager_loaded_self.serialize_hash_for_copy(final_options[:associations])
-    hash_copy   = JSON.parse(hash_origin.to_json) # a way to do deep clone
+    serialized_hash = eager_loaded_self.serialize_hash_for_copy(final_options[:associations])
 
-    builder = BrandNewCopyBuilder.new(hash_origin, hash_copy)
+    builder = BrandNewCopyBuilder.new(serialized_hash)
     builder.invoke_callback(final_options[:callbacks])
     builder.save
 
-    return hash_copy['id']
+    return builder.new_id(self.class.name, self.id)
   end
 end
 

data/lib/acts_as_brand_new_copy/version.rb

@@ -1,3 +1,3 @@
 module ActsAsBrandNewCopy
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_brand_new_copy
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-03 00:00:00.000000000 Z
+date: 2013-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler