acts_as_archival 0.6.0 → 0.6.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 175bbdb26230acbbbee4329bda6dd6bfc6eae3d5
+  data.tar.gz: d07f9da7b94fa39b6768cb369e20f7f84ddd4585
+SHA512:
+  metadata.gz: 995e99fa5c849235e10b5b7588cf1fa62fcb97271833ca941462d832769fd32ffbefd02f3d0f9dbacdb6bd0bb3c0bfd65b2fd6ea08425d937cd7e42aa82ecc27
+  data.tar.gz: 00f416f9999d273e490d56aad4309f3b639518a4868c904fb79d7f3a747b0c6b70df4c108646e8b91205ffc14d7f77d594d069c6bb912b4c0ee04cf92bd2f81c

data/.gitignore

@@ -4,7 +4,7 @@
 bin
 vendor/bundle
 *.gem
-Gemfile.lock
+*emfile.lock
 pkg/*
 .DS_Store
 *.sqlite3

data/Appraisals

@@ -0,0 +1,11 @@
+appraise "rails-3" do
+  gem "rails", ">= 3.0.0", "< 4.0"
+end
+
+appraise "rails-4" do
+  gem "rails", "~> 4.0.0"
+end
+
+appraise "rails-4.1" do
+  gem "rails", "~> 4.1.0"
+end

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changes!
 
+## 0.6.1
+* Fix deprecation warnings on Rails 4.1
+* Test suite now runs against multiple versions of Rails
+* Fully automated test suite setup
+
 ## 0.6.0
 * **BREAKING CHANGE** (possibly): Some refactoring to modern gem module idioms instead of old school plugins
 * Officially support PostgreSQL

data/README.md

@@ -120,14 +120,12 @@ to conditionally add the functionality to older Rails installations.
 
 ## Testing
 
-Because this plugin makes use of transactions we're testing it (mostly) on sqlite. Running the tests should be as easy as:
+Running the tests should be as easy as:
 
 ```  bash
-bundle                               # if this fails you might need to install/configure some databases
-test/script/db_setup                 # makes the databases with the correct permissions (for mySQL)
-createuser -D -A -P archival_tester  # makes user for PostgreSQL; answer the password prompt with "perspicacious"
-createdb -O archival_tester aaa_test # makes db for PostgreSQL and sets owner to our test user
-rake
+script/setup                 # bundles, makes databases with permissions
+rake                         # run tests on latest Rails
+appraisal rake               # run tests on all versions of Rails
 ```
 
 ## Help Wanted
@@ -151,7 +149,7 @@ ActsAsParanoid and PermanentRecords were both inspirations for this:
 * Dave Woodward
 * Miles Sterrett
 * James Hill
-* Marten Claes
+* Maarten Claes
 
 Thanks!
 

data/acts_as_archival.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |gem|
                      "Dave Woodward",
                      "Miles Sterrett",
                      "James Hill",
-                     "Marten Claes"]
+                     "Maarten Claes"]
   gem.email       = ["joel@expectedbehavior.com",
                      "michael@expectedbehavior.com",
                      "matt@expectedbehavior.com",
@@ -29,15 +29,16 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency "activerecord"
 
+  gem.add_development_dependency "appraisal"
   gem.add_development_dependency "assertions-eb"
   gem.add_development_dependency "rake"
   gem.add_development_dependency "mysql2"
   gem.add_development_dependency "sqlite3"
   gem.add_development_dependency "pg"
-  gem.add_development_dependency "highline"
   gem.add_development_dependency "rr"
   gem.add_development_dependency "database_cleaner"
 
+
   gem.description = <<-END
 *Atomic archiving/unarchiving for ActiveRecord-based apps*
 

data/gemfiles/rails_3.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", ">= 3.0.0", "< 4.0"
+
+gemspec :path => "../"

data/gemfiles/rails_4.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.1.0"
+
+gemspec :path => "../"

data/gemfiles/rails_4.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.0.0"
+
+gemspec :path => "../"

data/lib/acts_as_archival/version.rb

@@ -1,3 +1,3 @@
 module ActsAsArchival
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/lib/expected_behavior/acts_as_archival.rb

@@ -23,7 +23,7 @@ module ExpectedBehavior
           scope :archived_from_archive_number, lambda { |head_archive_number| where(['archived_at IS NOT NULL AND archive_number = ?', head_archive_number]) }
 
           callbacks = ['archive','unarchive']
-          define_callbacks *[callbacks, {:terminator => 'result == false'}].flatten
+          define_callbacks *[callbacks, {:terminator => lambda { |_, result| result == false }}].flatten
           callbacks.each do |callback|
             eval <<-end_callbacks
               def before_#{callback}(*args, &blk)

data/script/db_setup

@@ -0,0 +1,51 @@
+#!/usr/bin/env ruby
+require "bundler/setup"
+require "yaml"
+
+STDOUT.sync = true
+
+DB_CONFIG = YAML.load(File.read(File.join(File.dirname(__FILE__), "..", "test", "database.yml")))
+
+def execute_mysql(statement, password = nil)
+  password_option = if password.to_s.size > 0
+    "-p'#{password}'"
+  end
+  command = %Q{echo '#{statement}' | mysql -u root #{password_option}}
+  puts command
+  system(command)
+end
+
+def execute_postgres(statement)
+  command = %Q{echo "#{statement}" | psql postgres}
+  puts command
+  system(command)
+end
+
+def setup_mysql
+  mysql_root_password = nil
+  if !execute_mysql("SHOW DATABASES;", mysql_root_password)
+    loop do
+      print "MySQL root password to setup '#{DB_CONFIG["mysql"]["database"]}': "
+      mysql_root_password = gets.chomp
+      if execute_mysql("SHOW DATABASES;", mysql_root_password)
+        break
+      end
+    end
+  end
+
+  config = DB_CONFIG["mysql"]
+  execute_mysql("DROP DATABASE IF EXISTS #{config["database"]};", mysql_root_password)
+  execute_mysql("CREATE DATABASE #{config["database"]};", mysql_root_password)
+  execute_mysql(%Q{GRANT ALL ON `#{config["database"]}`.* TO `#{config["username"]}` IDENTIFIED BY "#{config["password"]}";}, mysql_root_password)
+end
+
+def setup_postgres
+  config = DB_CONFIG["pg"]
+  execute_postgres(%Q{DROP DATABASE IF EXISTS #{config["database"]};})
+  execute_postgres(%Q{DROP ROLE IF EXISTS #{config["username"]};})
+  execute_postgres(%Q{CREATE ROLE #{config["username"]} WITH PASSWORD '#{config["password"]}' LOGIN;})
+  execute_postgres(%Q{CREATE DATABASE #{config["database"]} WITH OWNER #{config["username"]};})
+end
+
+setup_mysql
+setup_postgres

data/script/setup

@@ -0,0 +1,6 @@
+#!/bin/sh
+set -e
+cd "`dirname \"$0\"`/.."
+
+bundle install
+script/db_setup

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_archival
 version: !ruby/object:Gem::Version
-  version: 0.6.0
-  prerelease: 
+  version: 0.6.1
 platform: ruby
 authors:
 - Joel Meador
@@ -13,180 +12,152 @@ authors:
 - Dave Woodward
 - Miles Sterrett
 - James Hill
-- Marten Claes
+- Maarten Claes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: assertions-eb
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: assertions-eb
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: mysql2
+  name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: mysql2
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pg
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: highline
+  name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! '*Atomic archiving/unarchiving for ActiveRecord-based apps*
-
+description: |
+  *Atomic archiving/unarchiving for ActiveRecord-based apps*
 
   We had the problem that acts_as_paranoid and similar plugins/gems always work on
-
   a record by record basis and made it very difficult to restore records
-
   atomically (or archive them, for that matter).
 
-
   Because the archive and unarchive methods are in transactions, and every
-
   archival record involved gets the same archive number upon archiving, you can
-
   easily restore or remove an entire set of records without having to worry about
-
   partial deletion or restoration.
 
-
   Additionally, other plugins generally screw with how destroy/delete work.  We
-
-  don''t because we actually want to be able to destroy records.
-
-'
+  don't because we actually want to be able to destroy records.
 email:
 - joel@expectedbehavior.com
 - michael@expectedbehavior.com
@@ -198,14 +169,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
+- Appraisals
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
 - acts_as_archival.gemspec
+- gemfiles/rails_3.gemfile
+- gemfiles/rails_4.1.gemfile
+- gemfiles/rails_4.gemfile
 - init.rb
 - lib/acts_as_archival.rb
 - lib/acts_as_archival/version.rb
@@ -214,6 +188,8 @@ files:
 - lib/expected_behavior/association_operation/archive.rb
 - lib/expected_behavior/association_operation/base.rb
 - lib/expected_behavior/association_operation/unarchive.rb
+- script/db_setup
+- script/setup
 - test/ambiguous_table_test.rb
 - test/associations_test.rb
 - test/basic_test.rb
@@ -242,33 +218,31 @@ files:
 - test/responds_test.rb
 - test/schema.rb
 - test/scope_test.rb
-- test/script/db_setup
 - test/test_helper.rb
 - test/through_association_test.rb
 - test/transaction_test.rb
 homepage: http://github.com/expectedbehavior/acts_as_archival
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Atomic archiving/unarchiving for ActiveRecord-based apps
 test_files:
 - test/ambiguous_table_test.rb
@@ -299,7 +273,6 @@ test_files:
 - test/responds_test.rb
 - test/schema.rb
 - test/scope_test.rb
-- test/script/db_setup
 - test/test_helper.rb
 - test/through_association_test.rb
 - test/transaction_test.rb

data/test/script/db_setup

@@ -1,57 +0,0 @@
-#!/usr/bin/env ruby
-require "bundler/setup"
-require "yaml"
-require 'highline/import'
-
-def read_database_config
-  database_file = File.join(File.dirname(__FILE__), "/../", "database.yml")
-  $DB_CONFIG = YAML.load(File.read(database_file))["mysql"]
-end
-
-def get_root_password
-  $ROOT_PW = ask("Provide root mySQL password to setup '#{$DB_CONFIG["database"]}': ") { |q| q.echo = false}
-  if !$ROOT_PW || $ROOT_PW.nil?
-    puts "error reading password"
-    exit 4
-  end
-end
-
-def check_root_password
-  password_check = "echo 'show databases;' | mysql -u root -p'#{$ROOT_PW}' > /dev/null"
-  unless system password_check
-    puts "incorrect password"
-    exit 7
-  end
-end
-
-def execute_mysql(message, statement, user = nil, password = nil)
-  puts message
-  `echo '#{statement}' | mysql -u #{user} -p'#{password}'`
-end
-
-def drop_existing(db, user, pass)
-  drop_statement   = "drop database if exists #{db};"
-  execute_mysql("dropping #{db}", drop_statement, user, pass)
-end
-
-def create_db(db, user, pass)
-  create_statement =  "create database #{db};"
-  execute_mysql("creating #{db}", create_statement, user, pass)
-end
-
-def grant_permission_on_db(db, user, pass)
-  grant_statement  =  "grant all on `#{db}`.* to `#{$DB_CONFIG["username"]}`@`localhost` identified by \"#{$DB_CONFIG["password"]}\";"
-  execute_mysql("granting on #{db}", grant_statement, user, pass)
-end
-
-read_database_config
-get_root_password
-check_root_password
-
-db   = $DB_CONFIG["database"]
-user = "root"
-pass = $ROOT_PW
-
-drop_existing(db, user, pass)
-create_db(db, user, pass)
-grant_permission_on_db(db, user, pass)