acts_as_account 3.4.0 → 3.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82e0a5a2dcd250ad8d0aa7231550b853a20afa4a74f93676099cdcf756826516
-  data.tar.gz: 0fdacf00679d364e12680d1862fad056fc7c8334c1c4b0078dce9a6d23219b19
+  metadata.gz: f273511f34e3a338870be2d7f3c1337917913b210b70f4237f4c206cc13a380e
+  data.tar.gz: e472770750dd7277e8d7343dc057ae1c289d19abc80ca0c812d9ca22efeaf9a1
 SHA512:
-  metadata.gz: 58987a63a27f2d97fe7e1d961431981e79846c213806c3364dd5ea0e42944d334b7b41d47188e361157736f341308174dd6b5f41a29ffc9e59fc63262cad8daa
-  data.tar.gz: d16e37c26e92810328ee1e60fa16135f4a6740b51e931d10bba3bdb6b56e6fed30b8610191c439570c0473bae2b441844c731b71d935993d18c25d2612c75f06
+  metadata.gz: f4e102e34de51ac78effb0d97fb80c4af26d37c3749de3545acf0ea6566e560720bdbfc7ec64572e2cdc811bc7db23681ceb4f9cc323dffab024056bd3feb31e
+  data.tar.gz: fe1dabd0b53ff1f8a06e23b046794b7c504ed2e862d454f430174643386aaa51cae1c33faf19ffa14a2d3f5d7df3063b331bca74c9c43b376ae58b905392916d

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changes
 
+## 2024-10-28 v3.4.1
+
+* Improved account management features:
+  * Update `Journal.current.transfer` to return a boolean value indicating success.
+  * Modify `transfer()` method in `lib/acts_as_account/journal.rb` to
+    check the result of `postings.model.insert_all`.
+  * Validate the transfer result in `german_date_time_to_local` and `When /^I
+    transfer ...$` step definitions.
+
 ## 2024-10-28 v3.4.0
 
 * Improve Journaling for Transfer Operations:

data/VERSION

@@ -1 +1 @@
-3.4.0
+3.4.1

data/acts_as_account.gemspec

@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
-# stub: acts_as_account 3.4.0 ruby lib
+# stub: acts_as_account 3.4.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "acts_as_account".freeze
-  s.version = "3.4.0".freeze
+  s.version = "3.4.1".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]

data/features/step_definitions/account_steps.rb

@@ -74,13 +74,13 @@ When /^I transfer (-?\d+) € from (\w+)'s account to (\w+)'s account$/ do |amou
   @from_account = User.find_by_name(from).account
   @to_account = User.find_by_name(to).account
   @previous_account_attributes = [@from_account.attributes, @to_account.attributes]
-  Journal.current.transfer(amount.to_i, @from_account, @to_account, @reference, @valuta)
+  Journal.current.transfer(amount.to_i, @from_account, @to_account, @reference, @valuta) == true
 end
 
 When /^I transfer (\d+) € from global (\w+) account to global (\w+) account$/ do |amount, from, to|
   from_account = Account.for(from)
   to_account = Account.for(to)
-  Journal.current.transfer(amount.to_i, from_account, to_account, @reference, @valuta)
+  Journal.current.transfer(amount.to_i, from_account, to_account, @reference, @valuta) == true
 end
 
 Then /^the balance\-sheet should be:$/ do |table|

data/lib/acts_as_account/journal.rb

@@ -52,10 +52,12 @@ module ActsAsAccount
         posting1 = build_posting(-amount,  from_account,   to_account, reference, valuta)
         posting2 = build_posting( amount,    to_account, from_account, reference, valuta)
 
-        postings.model.insert_all([ posting1.attributes, posting2.attributes ])
+        result = postings.model.insert_all([ posting1.attributes, posting2.attributes ])
 
         update_attributes_on(from_account, -amount)
         update_attributes_on(to_account,    amount)
+
+        !!result
       end
     end
 

data/lib/acts_as_account/version.rb

@@ -1,6 +1,6 @@
 module ActsAsAccount
   # ActsAsAccount version
-  VERSION         = '3.4.0'
+  VERSION         = '3.4.1'
   VERSION_ARRAY   = VERSION.split('.').map(&:to_i) # :nodoc:
   VERSION_MAJOR   = VERSION_ARRAY[0] # :nodoc:
   VERSION_MINOR   = VERSION_ARRAY[1] # :nodoc:

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts_as_account
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 3.4.1
 platform: ruby
 authors:
 - Thies C. Arntzen, Norman Timmler, Matthias Frick, Phillip Oertel