acts-as-taggable-on 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b46e80f19a5c7de71ec448bd0700ef672ea9639
-  data.tar.gz: d7c19bc3aec73a2b5d1ff08ad18cb9c85e61225c
+  metadata.gz: 293f131bdbea6f4836774fa5a51d51f54f4d03ef
+  data.tar.gz: fe26f8ea9c83126f6ce380ebc2bccce14ade746d
 SHA512:
-  metadata.gz: 4ac4317c1fa00caa6f048d4958d830da83bae5a48d8fd2f4018918319069e9e0311b99318cfe337fcd8d23f9c37055484e1c40c1ab0ecda2c256d361315b0848
-  data.tar.gz: 7e29cf71dfce65f2ac65d0a10972c6b26344398278c53b088b9069ec728955e697389f496b25a8f57fd521b6349aaa2ef827caab78bf8a00c7416c9be43c21e5
+  metadata.gz: 7a95962db54233536581ce55114d886fb907f90efc9743c67049f8284e2c0eac4f6d7dd19868689bc0721363fec7987dba927b8467f4aec8d1ec7bbd5a3b8482
+  data.tar.gz: f04b6dc48e1642c0bb0f6f3879913f5bd9fe7e9851842e5865d775994cd069c699e2ccbdeca393487b82485a5c195fd2125250062e684c12ff2c7241580900f2

data/.travis.yml

@@ -1,6 +1,7 @@
 rvm:
   - 1.9.3
   - 2.0.0
+  - 2.1.0
 env:
   - DB=sqlite3
   - DB=mysql

data/CHANGELOG.md

@@ -4,12 +4,33 @@ Each change should fall into categories that would affect whether the release is
 
 As such, a _Feature_ would map to either major or minor. A _bug fix_ to a patch.  And _misc_ is either minor or patch, the difference being kind of fuzzy for the purposes of history.  Adding tests would be patch level.
 
-### Master [changes](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.0.0...master)
+### Master [changes](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.0.1...master)
 
 * Breaking Changes
 * Features
 * Fixes
+  * [@rafael #406 Dirty attributes not correctly derived](https://github.com/mbleigh/acts-as-taggable-on/pull/406)
+  * [@bzbnhang #440 Did not respect strict_case_match](https://github.com/mbleigh/acts-as-taggable-on/pull/440)
+  * [@znz #456 Fix breaking encoding of tag](https://github.com/mbleigh/acts-as-taggable-on/pull/456)
 * Misc
+  * [@billychan #386 Add parse:true instructions to README](https://github.com/mbleigh/acts-as-taggable-on/pull/386)
+  * [@seuros #449 Improve README/UPGRADING/post install docs](https://github.com/mbleigh/acts-as-taggable-on/pull/449)
+  * [@seuros #452 Remove I18n deprecation warning in specs](https://github.com/mbleigh/acts-as-taggable-on/pull/452)
+  * [@seuros #453 Test against Ruby 2.1 on Travis CI](https://github.com/mbleigh/acts-as-taggable-on/pull/453)
+  * [@takashi #454 Clarify example in docs](https://github.com/mbleigh/acts-as-taggable-on/pull/454)
+
+### [3.0.1 / 2014-01-08](https://github.com/mbleigh/acts-as-taggable-on/compare/v3.0.0...v3.0.1)
+
+* Fixes
+  * [@rafael #406 Dirty attributes not correctly derived](https://github.com/mbleigh/acts-as-taggable-on/pull/406)
+  * [@bzbnhang #440 Did not respect strict_case_match](https://github.com/mbleigh/acts-as-taggable-on/pull/440)
+  * [@znz #456 Fix breaking encoding of tag](https://github.com/mbleigh/acts-as-taggable-on/pull/456)
+* Misc
+  * [@billychan #386 Add parse:true instructions to README](https://github.com/mbleigh/acts-as-taggable-on/pull/386)
+  * [@seuros #449 Improve README/UPGRADING/post install docs](https://github.com/mbleigh/acts-as-taggable-on/pull/449)
+  * [@seuros #452 Remove I18n deprecation warning in specs](https://github.com/mbleigh/acts-as-taggable-on/pull/452)
+  * [@seuros #453 Test against Ruby 2.1 on Travis CI](https://github.com/mbleigh/acts-as-taggable-on/pull/453)
+  * [@takashi #454 Clarify example in docs](https://github.com/mbleigh/acts-as-taggable-on/pull/454)
 
 ### [3.0.0 / 2014-01-01](https://github.com/mbleigh/acts-as-taggable-on/compare/v2.4.1...v3.0.0)
 

data/CONTRIBUTING.md

@@ -0,0 +1,44 @@
+# How to contribute:
+
+## Bug reports / Issues
+
+  * Is something broken or not working as expected? Check for an existing issue or [create a new one](https://github.com/mbleigh/acts-as-taggable-on/issues/new)
+  * IMPORTANT: Include the version of the gem, if you've install from git, what Ruby and Rails you are running, etc.
+
+## Code
+
+1. [Fork and clone the repo](https://help.github.com/articles/fork-a-repo)
+2. Install the gem dependencies: `bundle install`
+3. Make the changes you want and back them up with tests.
+  * [Run the tests](https://github.com/mbleigh/acts-as-taggable-on#testing) (`bundle exec rake spec`)
+4. Update the CHAGELOG.md file with your changes and give yourself credit
+5. Commit and create a pull request with details as to what has been changed and why
+  * Use well-described, small (atomic) commits.
+  * Include links to any relevant github issues.
+  * *Don't* change the VERSION file.
+6. Extra Credit: [Confirm it runs and tests pass on the rubies specified in the travis config](.travis.yml). I will otherwise confirm it runs on these.
+
+How I handle pull requests:
+
+* If the tests pass and the pull request looks good, I will merge it.
+* If the pull request needs to be changed,
+  * you can change it by updating the branch you generated the pull request from
+    * either by adding more commits, or
+    * by force pushing to it
+  * I can make any changes myself and manually merge the code in.
+
+### Commit Messages
+
+* [A Note About Git Commit Messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
+* [http://stopwritingramblingcommitmessages.com/](http://stopwritingramblingcommitmessages.com/)
+* [ThoughtBot style guide](https://github.com/thoughtbot/guides/tree/master/style#git)
+
+### About Pull Requests (PR's)
+
+* [All Your Open Source Code Are Belong To Us](http://www.benjaminfleischer.com/2013/07/30/all-your-open-source-code-are-belong-to-us/)
+* [Using Pull Requests](https://help.github.com/articles/using-pull-requests)
+* [Github pull requests made easy](http://www.element84.com/github-pull-requests-made-easy.html)
+
+## Documentation
+
+* Update the wiki

data/README.md

@@ -21,7 +21,7 @@ Versions 2.x are compatible with Ruby 1.8.7+ and Rails 3.
 
 Versions 2.4.1 and up are compatible with Rails 4 too (thanks to arabonradar and cwoodcox).
 
-Versions 3.x (currently unreleased) are compatible with Ruby 1.9.3+ and Rails 3 and 4.  There is a [release candidate you may try](http://rubygems.org/gems/acts_as_taggable_on).
+Versions >= 3.x are compatible with Ruby 1.9.3+ and Rails 3 and 4.
 
 For an up-to-date roadmap, see https://github.com/mbleigh/acts-as-taggable-on/issues/milestones
 
@@ -35,48 +35,100 @@ gem 'acts-as-taggable-on'
 
 and bundle:
 
-```ruby
+```shell
 bundle
 ```
 
 #### Post Installation
 
-```shell
-# For the latest versions
-rake railties:install:migrations FROM=acts_as_taggable_on_engine db:migrate
+Install migrations
 
-# For versions 2.4.1 and earlier
+```shell
+# For the latest versions :
+rake acts_as_taggable_on_engine:install:migrations
+# For versions 2.4.1 and earlier :
 rails generate acts_as_taggable_on:migration
+```
+
+Review the generated migrations then migrate :
+```shell
 rake db:migrate
 ```
 
 #### Upgrading
 
-see [UPGRADING](UPGRADING)
+see [UPGRADING](UPGRADING.md)
 
 ## Usage
 
+Setup
+
 ```ruby
 class User < ActiveRecord::Base
-  # Alias for acts_as_taggable_on :tags
-  acts_as_taggable
+  acts_as_taggable # Alias for acts_as_taggable_on :tags
   acts_as_taggable_on :skills, :interests
 end
 
 @user = User.new(:name => "Bobby")
-@user.tag_list = "awesome, slick, hefty"      # this should be familiar
-@user.skill_list = "joking, clowning, boxing" # but you can do it for any context!
+```
+
+Add and remove a single tag
+
+```ruby
+@user.tag_list.add("awesomer")   # add a single tag. alias for <<
+@user.tag_list.remove("awesome") # remove a single tag
+```
+
+Add and remove multiple tags in an array
+
+```ruby
+@user.tag_list.add("awesomer", "slicker")
+@user.tag_list.remove("awesome", "slick")
+```
+
+You can also add and remove tags in format of String. This would
+be convenient in some cases such as handling tag input param in a String.
+
+Pay attention you need to add `parse: true` as option in this case.
+
+You may also want to take a look at delimiter in the string. The default
+is comma `,` so you don't need to do anything here. However, if you made
+a change on delimiter setting, make sure the string will match. See
+[configuration](#configuration) for more about delimiter.
+
+```ruby
+@user.tag_list.add("awesomer, slicker", parse: true)
+@user.tag_list.remove("awesome, slick", parse: true)
+```
+
+You can also add and remove tags by direct assignment. Note this will
+remove existing tags so use it with attention.
+
+```ruby
+@user.tag_list = "awesome, slick, hefty"
+@user.tags
+# => [<Tag name:"awesome">,<Tag name:"slick">,<Tag name:"hefty">]
+```
+
+With the defined context in model, you have multiple new methods at disposal
+to manage and view the tags in the context. For example, with `:skill` context
+these methods are added to the model: `skill_list`(and `skill_list.add`, `skill_list.remove`
+`skill_list=`), `skills`(plural), skill_counts
+
+
+```ruby
+@user.skill_list = "joking, clowning, boxing"
+
+@user.skills
+# => [<Tag name:"joking">,<Tag name:"clowning">,<Tag name:"boxing">]
 
-@user.tags                                    # => [<Tag name:"awesome">,<Tag name:"slick">,<Tag name:"hefty">]
-@user.skills                                  # => [<Tag name:"joking">,<Tag name:"clowning">,<Tag name:"boxing">]
-@user.skill_list                              # => ["joking","clowning","boxing"] as TagList
+@user.skill_list.add("coding")
 
-@user.tag_list.remove("awesome")              # remove a single tag
-@user.tag_list.remove("awesome, slick")       # works with arrays too
-@user.tag_list.add("awesomer")                # add a single tag. alias for <<
-@user.tag_list.add("awesomer, slicker")       # also works with arrays
+@user.skill_list
+# => ["joking","clowning","boxing", "coding"]
 
-User.skill_counts                             # => [<Tag name="joking" count=2>,<Tag name="clowning" count=1>...]
+User.skill_counts
+# => [<Tag name="joking" count=2>,<Tag name="clowning" count=1>...]
 ```
 
 To preserve the order in which tags are created use `acts_as_ordered_taggable`:
@@ -128,7 +180,7 @@ User.tagged_with(['awesome, cool'], :on => :tags, :any => true).tagged_with(['sm
 
 You can also use `:wild => true` option along with `:any` or `:exclude` option. It will looking for `%awesome%` and `%cool%` in sql.
 
-__Tip:__ `User.tagged_with([])` or '' will return `[]`, but not all records.
+__Tip:__ `User.tagged_with([])` or `User.tagged_with('')` will return `[]`, but not all records.
 
 ### Relationships
 

data/{UPGRADING → UPGRADING.md}

@@ -2,6 +2,6 @@ When upgrading
 
 Re-run the migrations generator
 
-    rake railties:install:migrations FROM=acts_as_taggable_on_engine db:migrate
+    rake acts_as_taggable_on_engine:install:migrations
 
 It will create any new migrations and skip existing ones

data/acts-as-taggable-on.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
-  if File.exists?('UPGRADING')
-    gem.post_install_message = File.read('UPGRADING')
+  if File.exists?('UPGRADING.md')
+    gem.post_install_message = File.read('UPGRADING.md')
   end
 
   gem.add_runtime_dependency 'rails', ['>= 3', '< 5']

data/lib/acts_as_taggable_on/acts_as_taggable_on/core.rb

@@ -307,7 +307,7 @@ module ActsAsTaggableOn::Taggable
       end
 
       def process_dirty_object(context,new_list)
-        value = new_list.is_a?(Array) ? new_list.join(', ') : new_list
+        value = new_list.is_a?(Array) ? ActsAsTaggableOn::TagList.new(new_list) : new_list
         attrib = "#{context.to_s.singularize}_list"
 
         if changed_attributes.include?(attrib)

data/lib/acts_as_taggable_on/tag.rb

@@ -100,7 +100,11 @@ module ActsAsTaggableOn
       private
 
       def comparable_name(str)
-        as_8bit_ascii(str).downcase
+        if ActsAsTaggableOn.strict_case_match
+          as_8bit_ascii(str)
+        else
+          as_8bit_ascii(str).downcase
+        end
       end
 
       def binary
@@ -109,7 +113,7 @@ module ActsAsTaggableOn
 
       def as_8bit_ascii(string)
         if defined?(Encoding)
-          string.to_s.force_encoding('BINARY')
+          string.to_s.dup.force_encoding('BINARY')
         else
           string.to_s.mb_chars
         end

data/lib/acts_as_taggable_on/version.rb

@@ -1,4 +1,4 @@
 module ActsAsTaggableOn
-  VERSION = '3.0.0'
+  VERSION = '3.0.1'
 end
 

data/spec/acts_as_taggable_on/tag_spec.rb

@@ -72,16 +72,30 @@ describe ActsAsTaggableOn::Tag do
       ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("AWESOME").should == [@tag]
     end
 
+    it "should find by name case sensitive" do
+      ActsAsTaggableOn.strict_case_match = true
+      expect {
+        ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("AWESOME")
+      }.to change(ActsAsTaggableOn::Tag, :count).by(1)  
+    end
+
     it "should create by name" do
-      lambda {
+      expect {
         ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("epic")
-      }.should change(ActsAsTaggableOn::Tag, :count).by(1)
+      }.to change(ActsAsTaggableOn::Tag, :count).by(1)
+    end
+
+    it "should find or create by name case sensitive" do
+      ActsAsTaggableOn.strict_case_match = true
+      expect {
+        ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("AWESOME", 'awesome').map(&:name).should == ["AWESOME", "awesome"]
+      }.to change(ActsAsTaggableOn::Tag, :count).by(1)
     end
 
     it "should find or create by name" do
-      lambda {
+      expect {
         ActsAsTaggableOn::Tag.find_or_create_all_with_like_by_name("awesome", "epic").map(&:name).should == ["awesome", "epic"]
-      }.should change(ActsAsTaggableOn::Tag, :count).by(1)
+      }.to change(ActsAsTaggableOn::Tag, :count).by(1)
     end
 
     it "should return an empty array if no tags are specified" do
@@ -180,6 +194,13 @@ describe ActsAsTaggableOn::Tag do
       ActsAsTaggableOn::Tag.named('cool').should include(@tag)
       ActsAsTaggableOn::Tag.named('cool').should_not include(uppercase_tag)
     end
+
+    it "should not change enconding" do
+      name = "\u3042"
+      original_encoding = name.encoding
+      ActsAsTaggableOn::Tag.find_or_create_with_like_by_name(name)
+      name.encoding.should == original_encoding
+    end
   end
 
   describe "name uniqeness validation" do

data/spec/acts_as_taggable_on/taggable_spec.rb

@@ -562,6 +562,22 @@ describe "Taggable" do
         it 'does not show any changes to the taggable item' do
           @taggable.changes.should == {}
         end
+
+        context "and using a delimiter different from a ','" do
+          before do
+            @old_delimiter = ActsAsTaggableOn.delimiter
+            ActsAsTaggableOn.delimiter = ';'
+          end
+
+          after do
+            ActsAsTaggableOn.delimiter = @old_delimiter
+          end
+
+          it 'does not show any changes to the taggable item when using array assignments' do
+            @taggable.tag_list = ["awesome", "epic"]
+            @taggable.changes.should == {}
+          end
+        end
       end
     end
 

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ $LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
 require 'logger'
 
 require File.expand_path('../../lib/acts-as-taggable-on', __FILE__)
+I18n.enforce_available_locales = true
 require 'ammeter/init'
 
 unless [].respond_to?(:freq)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: acts-as-taggable-on
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Michael Bleigh
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-01 00:00:00.000000000 Z
+date: 2014-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -129,12 +129,13 @@ files:
 - .travis.yml
 - Appraisals
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - Guardfile
 - LICENSE.md
 - README.md
 - Rakefile
-- UPGRADING
+- UPGRADING.md
 - acts-as-taggable-on.gemspec
 - db/migrate/1_acts_as_taggable_on_migration.rb
 - db/migrate/2_add_missing_unique_indices.rb
@@ -185,7 +186,7 @@ post_install_message: |
 
   Re-run the migrations generator
 
-      rake railties:install:migrations FROM=acts_as_taggable_on_engine db:migrate
+      rake acts_as_taggable_on_engine:install:migrations
 
   It will create any new migrations and skip existing ones
 rdoc_options: []