activevalidators 5.0.1 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b7fa6eefd00b8ff0eeacbc73ef6e7c640be026737347898862a7ab42a0c2b86
-  data.tar.gz: 9ed8128e768f17580d472228fb17ac8b212d8bb40589715d9bc8d7b1cba861c1
+  metadata.gz: e28fd41e5406e9d587414ae53528c6ab0ea6542950b16ba990a6f51f120bd192
+  data.tar.gz: 55add0e3513f0fe48f4924322e06456f4481ec4ce213be561b24cacd5342ebd0
 SHA512:
-  metadata.gz: ad2aaf9b651037fbbbff1cfa6a52e3c5f47e6df4d4e05fc4211596ac81dad935538badac4982eb98efb0cf8098a557dbb494990145466ee570ca1488b6d68996
-  data.tar.gz: f67a9456f140e2551d3006242342a003ae7b8b26d6e7bb76528e2950c8b7662c544b5678d75e653b3c5ead7f957b39c206b8bd546118183c5563bf1c18c19739
+  metadata.gz: '0866bce8c7f7d4bbb327681eb31b185534c5322533281e2adf56919dd6fbb6ca2d1315500a88b0b85d89b9524ff83b5435c3df41a164cab0c5f4154e07f52332'
+  data.tar.gz: 065aea8ed9dc5f4581163ec02e92a25671e548714c05b90b6e229b0af8856795fe07c2a4037beea6d2a9a0332bc840a6ee56682d75994b32fb8f543ac8075802

data/.circleci/config.yml

@@ -0,0 +1,84 @@
+version: 2
+
+shared: &shared
+  working_directory: ~/repo
+  steps:
+    - checkout
+
+    # Download and cache dependencies
+    - restore_cache:
+        keys:
+          - v1-dependencies-{{ checksum "Gemfile.lock" }}
+          # fallback to using the latest cache if no exact match is found
+          - v1-dependencies-
+
+    - run:
+        name: install dependencies
+        command: |
+          bundle install --jobs=4 --retry=3 --path vendor/bundle
+
+    - save_cache:
+        paths:
+          - ./vendor/bundle
+        key: v1-dependencies-{{ checksum "Gemfile.lock" }}
+
+    # run tests!
+    - run:
+        name: run tests
+        command: bundle exec rake
+
+jobs:
+  # RAILS_VERSION=5.1.6
+  "ruby-2.4/rails-5.1.6":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.4
+    environment:
+      RAILS_VERSION=5.1.6
+
+  "ruby-2.5/rails-5.1.6":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.5
+    environment:
+      RAILS_VERSION=5.1.6
+
+  "ruby-2.6/rails-5.1.6":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.6
+    environment:
+      RAILS_VERSION=5.1.6
+
+  # RAILS_VERSION=5.2.2
+  "ruby-2.4/rails-5.2.2":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.4
+    environment:
+      RAILS_VERSION=5.2.2
+
+  "ruby-2.5/rails-5.2.2":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.5
+    environment:
+      RAILS_VERSION=5.2.2
+
+  "ruby-2.6/rails-5.2.2":
+    <<: *shared
+    docker:
+      - image: circleci/ruby:2.6
+    environment:
+      RAILS_VERSION=5.2.2
+
+workflows:
+  version: 2
+  build:
+    jobs:
+      - "ruby-2.4/rails-5.1.6"
+      - "ruby-2.5/rails-5.1.6"
+      - "ruby-2.6/rails-5.1.6"
+      - "ruby-2.4/rails-5.2.2"
+      - "ruby-2.5/rails-5.2.2"
+      - "ruby-2.6/rails-5.2.2"

data/AUTHORS.md

@@ -0,0 +1,33 @@
+# Authors
+
+In alphabetical order:
+
+  * Abe Fehr
+  * Alyssa Ross
+  * Brian Moseley
+  * Cédric FABIANSKI
+  * Etienne Depaulis
+  * Franck Verrot
+  * Garrett Bjerkhoel
+  * Guten
+  * Igor Fedoronchuk
+  * John
+  * Julien Fusco
+  * Kevin Sołtysiak
+  * Kris Windham
+  * Manuel Menezes de Sequeira
+  * Oriol Gual
+  * Paco Guzmán
+  * Pierre-Baptiste Béchu
+  * Radovan Šmitala
+  * Ray Krueger
+  * Renato Riccieri
+  * Richard Michael
+  * Rob Zuber
+  * Serj L
+  * Stefan Kracht
+  * William Howard
+  * Zachary Porter
+  * daslicious
+  * dewski
+  * lukas

data/ChangeLog.md

@@ -9,6 +9,18 @@
 ## CHANGES
 
 
+# 5.1.0
+
+## BREAKING CHANGES
+
+## DEPRECATION
+
+## CHANGES
+
+ * Ditch Travis CI in favor or CircleCI
+ * Disallow business numbers from SIN validation
+
+
 # 5.0.1
 
 ## CHANGES

data/README.md

@@ -1,4 +1,4 @@
-# ActiveValidators [![Travis](https://secure.travis-ci.org/franckverrot/activevalidators.png)](http://travis-ci.org/franckverrot/activevalidators)
+# ActiveValidators [![CircleCI](https://circleci.com/gh/franckverrot/activevalidators.svg?style=svg)](https://circleci.com/gh/franckverrot/activevalidators)
 
 # Description
 
@@ -124,7 +124,7 @@ Exhaustive list of supported validators and their implementation:
 * `respond_to` : generic Ruby `respond_to`
 * `siren` : [SIREN](http://fr.wikipedia.org/wiki/SIREN) company numbers in France
 * `slug`  : based on `ActiveSupport::String#parameterize`
-* `sin` : Social Insurance Number (only for Canada). You may also allow permanent resident cards (such cards start with '9'): `:sin => {:country => :canada, :country_options => {allow_permanent_residents: true}}`
+* `sin` : Social Insurance Number (only for Canada). You may also allow permanent resident cards (such cards start with '9') or business numbers (such numbers start with '8'): `:sin => {:country => :canada, :country_options => {allow_permanent_residents: true, allow_business_numbers: true}}`
 * `ssn` : Social Security Number (only for USA).
 * `tracking_number`: based on a set of predefined masks
 * `twitter` : based on a regular expression
@@ -176,18 +176,11 @@ Lots of improvements can be made:
 
 ## Contributors
 
-* Franck Verrot
-* Oriol Gual
-* Paco Guzmán
-* Garrett Bjerkhoel
-* Renato Riccieri Santos Zannon
-* Brian Moseley
-* Travis Vachon
-* Rob Zuber
-* Manuel Menezes de Sequeira
-* Serj L aka Loremaster
-* Pierre-Baptiste Béchu
+Please checkout [AUTHORS.md](authors) to see who contributed.  Get involved!
+
 
 ## Copyright
 
 Copyright (c) 2010-2018 Franck Verrot. MIT LICENSE. See LICENSE for details.
+
+[authors]: https://github.com/franckverrot/activevalidators/blob/master/AUTHORS.md

data/activevalidators.gemspec

@@ -1,9 +1,9 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'activevalidators'
-  s.version     = '5.0.1'
+  s.version     = '5.1.0'
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ['Franck Verrot', 'Paco Guzmán', 'Oriol Gual', 'Garrett Bjerkhoel', 'Renato Riccieri Santos Zannon', 'Brian Moseley', 'Serj L aka Loremaster']
+  s.authors     = ['Franck Verrot']
   s.email       = ['franck@verrot.fr']
   s.homepage    = 'http://github.com/franckverrot/activevalidators'
   s.summary     = %q{Collection of ActiveModel/ActiveRecord validations}

data/lib/active_validators/active_model/validations/sin_validator.rb

@@ -20,28 +20,31 @@ module ActiveModel
     # The Social Insurance Number is a nine-digit number in the format "AAA BBB CCC".
     # The number is divided into three parts.
     # AAA - is the first, BBB - is the second and the CCC is the third.
-    # Numbers that begin with the number "9" are issued to temporary residents who are not Canadian citizens
+    # Numbers that begin with the number "9" are issued to temporary residents who are not Canadian citizens.
+    # Numbers that begin with the number "8" are issued to businesses as "Business Numbers".
     # More details: http://en.wikipedia.org/wiki/Social_Insurance_Number
     #
     # Possible flags:
     #   allow_permanent_residents - citizens with cars, which begins with "9" are valid. By default it is false.
+    #   allow_business_numbers - business numbers, which begins with "8" are valid. By default it is false.
     #
-    #   validates :sin, :sin => {:country => :canada, :country_options => {:allow_permanent_residents => true}}
+    #   validates :sin, :sin => {:country => :canada, :country_options => {:allow_permanent_residents => true, :allow_business_numbers => true}}
     class SinValidatorCanada
       def initialize(str_value, options)
         @sin = str_value.gsub(/\D/, '') # keep only integers
         @allow_permanent_residents = false
+        @allow_business_numbers = false
 
         country_options = options.fetch(:country_options, {})
         allow_permanent_residents = country_options.fetch(:allow_permanent_residents, :nil)
+        allow_business_numbers = country_options.fetch(:allow_business_numbers, :nil)
 
-        if allow_permanent_residents == true
-          @allow_permanent_residents = true
-        end
+        @allow_permanent_residents = true if allow_permanent_residents == true
+        @allow_business_numbers = true if allow_business_numbers == true
       end
 
       def valid?
-        size_is?(9) && is_not_full_of_zeroes && allow_permanent_residents? && LuhnChecker.valid?(@sin)
+        size_is?(9) && is_not_full_of_zeroes && allow_permanent_residents? && allow_business_numbers? && LuhnChecker.valid?(@sin)
       end
 
       def size_is?(count)
@@ -61,6 +64,12 @@ module ActiveModel
           true
         end
       end
+
+      def allow_business_numbers?
+        business_indentifier = '8'
+
+        !(@allow_business_numbers == false && @sin.start_with?(business_indentifier))
+      end
     end
   end
 end

data/script/generate_authors

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+cat << EOF > AUTHORS.md
+# Authors
+
+In alphabetical order:
+
+EOF
+
+git log --pretty=format:"  * %an" | sort -u >> AUTHORS.md

data/test/validations/date_test.rb

@@ -9,10 +9,15 @@ ActiveValidators.activate(:date)
 # [on Github](https://github.com/codegram/date_validator)
 describe "Date Validation" do
   it "finds the translations" do
-    TestRecord.validates :start_date, :date => {:before => :end_date }
-    d = TestRecord.new(:start_date => Time.now, :end_date => Time.now - 1)
+    d = build_date_record
 
     refute d.valid?
     refute_includes d.errors.to_s, 'translation missing'
   end
+
+  def build_date_record
+    TestRecord.reset_callbacks(:validate)
+    TestRecord.validates :start_date, :date => { :before => :end_date }
+    TestRecord.new(:start_date => Time.now, :end_date => Time.now - 1)
+  end
 end

data/test/validations/email_test.rb

@@ -110,6 +110,7 @@ describe "Email Validation" do
     end
   end
 
+  before { TestRecord.reset_callbacks(:validate) }
   it "checks validity of the arguments" do
     [3, "foo", 1..6].each do |wrong_argument|
       assert_raises(ArgumentError,"Not a callable object #{wrong_argument.inspect}") do

data/test/validations/sin_test.rb

@@ -34,6 +34,11 @@ describe "SIN validations" do
         subject.valid?.must_equal false
       end
 
+      it "rejects valid business numbers by default" do
+        subject = build_sin_record({:sin => '897 454 286'}, {:country => :canada })
+        subject.valid?.must_equal false
+      end
+
       it "rejects invalid sin for permanent residents" do
         subject = build_sin_record({:sin => '123 456 789'}, {:country => :canada })
         subject.valid?.must_equal false
@@ -56,6 +61,12 @@ describe "SIN validations" do
                                    {:country => :canada, :country_options => { allow_permanent_residents: true } })
         subject.valid?.must_equal true
       end
+
+      it "accept valid business numbers when flag is provided" do
+        subject = build_sin_record({:sin => '897 454 286'},
+                                   {:country => :canada, :country_options => { allow_business_numbers: true } })
+        subject.valid?.must_equal true
+      end
     end
   end
 

metadata

@@ -1,16 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: activevalidators
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.1.0
 platform: ruby
 authors:
 - Franck Verrot
-- Paco Guzmán
-- Oriol Gual
-- Garrett Bjerkhoel
-- Renato Riccieri Santos Zannon
-- Brian Moseley
-- Serj L aka Loremaster
 autorequire: 
 bindir: bin
 cert_chain:
@@ -40,7 +34,7 @@ cert_chain:
   akLQjJWKHQCzyqDChJHRGhlxyVFKP2JwqFgzE3p1l64JArsb7BEqhpoBPXMwlChE
   HgzCBTsCU0syQBb1s6lBz2HrWA4=
   -----END CERTIFICATE-----
-date: 2018-12-21 00:00:00.000000000 Z
+date: 2019-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -181,8 +175,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
-- ".travis.yml"
+- AUTHORS.md
 - ChangeLog.md
 - Gemfile
 - LICENSE
@@ -218,6 +213,7 @@ files:
 - lib/active_validators/active_model/validations/url_validator.rb
 - lib/active_validators/one_nine_shims/one_nine_string.rb
 - lib/activevalidators.rb
+- script/generate_authors
 - test/test_helper.rb
 - test/validations/barcode_test.rb
 - test/validations/credit_card_test.rb
@@ -257,8 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 3.0.0.beta1
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Collection of ActiveModel/ActiveRecord validations

data/.travis.yml

@@ -1,10 +0,0 @@
-language: ruby
-rvm:
-  - 2.4.4
-  - 2.5.3
-  - ruby-head
-before_install:
-  - gem install bundler
-env:
-  - "RAILS_VERSION=5.2.2"
-  - "RAILS_VERSION=5.1.6"