activestorage-tencent_cos 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 348b2ef87c38baa18adc32994643d32a16ca7d1394bd5b44cd164163eb8e2646
-  data.tar.gz: e36d6cd2d493beaea1dd58188ed252e33dd9473a9797a564a42b9326fa27ae3e
+  metadata.gz: 23f78ce53915c90a661addc8521d5832f9038b6e336dd46f40b58faf1989f4f7
+  data.tar.gz: 7a9a73d48927d790327a42795d870757d06fe34b1ae8079dd94d713350a5d830
 SHA512:
-  metadata.gz: 0c8e24008019e8543bd391ec8eeff8d1ff2928c8b6ddf063751ce61757ed2dc5acbc1a0d5846ee70f7239b40cb64f8cab7c7e6cd85c8f43b96ab55053c68437f
-  data.tar.gz: 1043a7284e7d81856d0f1066a029fca8003b14fd0a84fa22bbbdf9badb26e51d1e095d2e8b4f24167d6390a50836e114a4add6e68d3ac1a15144ac00960154c6
+  metadata.gz: 143af6bad5873afe9c8d133bc5b50734d994dc0b20519c247a394ffd0dcfbb305738030ed785fc7f9c5bd2a19d26774b4ea7e5fff0ecc10cc7e48ac20150eb82
+  data.tar.gz: 81ff34f1b624f213cda72d5c8dda499e5071721e84cf5f4025389f9f2082c11a4bdd91bc070680a3f6a66df5c6a7788e0e6359a6330f109e66433e829134ff73

data/README.md

@@ -7,7 +7,6 @@ It is important to note that this library is still in early stages and is curren
 - only public read bucket is support(HTTP caching purpose)
 - direct upload only
 - delete variants have not yet been implemented
-- download have not yet been implemented
 
 
 ## Usage

data/lib/active_storage/service/tencent_cos_service.rb

@@ -13,8 +13,17 @@ module ActiveStorage
       raise NotImplementedError
     end
 
-    def download(key)
-      raise NotImplementedError
+    def download(key, &block)
+      uri  = URI(url_for(key))
+      if block_given?
+        instrument :streaming_download, key: key do
+          Net::HTTP.get_response(uri, &block)
+        end
+      else
+        instrument :download, key: key do
+          Net::HTTP.get(uri)
+        end
+      end
     end
 
     def download_chunk(key, range)
@@ -94,7 +103,8 @@ module ActiveStorage
       end
 
       def path_for(key)
-        "/#{key}"
+        prefix = config.fetch(:prefix, '')
+        "#{prefix}/#{key}"
       end
 
       def host

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activestorage-tencent_cos
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - ''
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-11 00:00:00.000000000 Z
+date: 2018-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activestorage