activestorage-cloudinary-service 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dabc2d19ae96fc59d1da3098a2c57bde025d181
-  data.tar.gz: 22502fdb687f935395f06e98237daa1ca2c98ed9
+  metadata.gz: b50dae378cf0139e357b729556b67dc4c54d5145
+  data.tar.gz: 1abc550178e3e9d0185d6054ac6e106b93856785
 SHA512:
-  metadata.gz: f8bc1c8c87d28083ede0fd36330c0c38b296e2cfc7e47faecccf91e3d04c066195d8c5f2158bf7343d91c1c0283c5cb91f0176e62e58e23968e2c424539c7942
-  data.tar.gz: d7479eb0533d704fb94b91a15d0cca6db0194479a40fec5bdcc7022856c92c45a2db104de37890c9460e37717704f086a00245df2a30312d90dab032ee62f03d
+  metadata.gz: '038120527a18e575f83ecd25affec02642e2a1ca9436188441dca8e835a01526bc02b0898e0a5d075c2155a670748950dc0d1027242f4db6e7022d5b29b34e00'
+  data.tar.gz: c56153d54fb3f1e195d828904292d3afdf0d30ee16a663979a97bb7959857dc9775422dd585442ba688513aaebf03d23503f39f489df9b1f710d5e54a071d1dd

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    activestorage-cloudinary-service (0.2.0)
+    activestorage-cloudinary-service (0.2.1)
 
 GEM
   remote: https://rubygems.org/
@@ -112,7 +112,7 @@ DEPENDENCIES
   cloudinary (~> 1.8.2)
   pry (~> 0.11.3)
   rake (~> 10.0)
-  rspec (~> 3.7.0)
+  rspec (~> 3.7)
 
 BUNDLED WITH
    1.16.2

data/activestorage-cloudinary-service.gemspec

@@ -23,5 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.16'
   spec.add_development_dependency 'pry', '~> 0.11.3'
   spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.7.0'
+  spec.add_development_dependency 'rspec', '~> 3.7'
 end

data/lib/active_storage/service/cloudinary_service.rb

@@ -19,7 +19,7 @@ module ActiveStorage
       # Cloudinary.config_from_url(url)
     end
 
-    def upload(key, io, checksum: nil)
+    def upload(key, io, checksum: nil, **)
       instrument :upload, key: key, checksum: checksum do
         Cloudinary::Uploader.upload(io, public_id: key, resource_type: 'auto')
       end

data/lib/active_storage/service/download_utils.rb

@@ -6,37 +6,23 @@ module DownloadUtils
     url = URI.parse(source)
     http, req = setup_connection(url)
 
-    # content_length = http.request_head(url).content_length
-    # upper_limit = content_length + (content_length % chunk_size)
-    # offset = 0
-    #
-    # parts = (content_length / chunk_size.to_f).ceil
-
-    # http.start do |agent|
-    #   parts.times do |part|
-    #     req.range = (part * chunk_size)...((part + 1) * chunk_size)
-    #     chunk = agent.request(req).body
-    #     yield chunk.force_encoding(Encoding::BINARY)
-    #   end
-    # end
+    content_length = http.request_head(url).content_length
+    upper_limit = content_length + (content_length % chunk_size)
+    offset = 0
 
     http.start do |agent|
-      agent.request(req) do |resp|
-        resp.read_body { |chunk| yield chunk.force_encoding(Encoding::BINARY) }
-      end
+      while offset < upper_limit
+        lim = (offset + chunk_size)
+        # QUESTION: is it relevant to set the last chunk
+        # to the exact remaining bytes
+        # lim = content_length if lim > content_length
+        req.range = (offset..lim)
 
-      # while offset < upper_limit
-      #   lim = (offset + chunk_size)
-      #   # QUESTION: is it relevant to set the last chunk
-      #   # to the exact remaining bytes
-      #   # lim = content_length if lim > content_length
-      #   req.range = (offset..lim)
-      #
-      #   chunk = agent.request(req).body
-      #   yield chunk.force_encoding(Encoding::BINARY)
-      #
-      #   offset += chunk_size + 1
-      # end
+        chunk = agent.request(req).body
+        yield chunk.force_encoding(Encoding::BINARY)
+
+        offset += chunk_size + 1
+      end
     end
   end
 

data/lib/active_storage/service/version.rb

@@ -1,5 +1,5 @@
 module ActiveStorage
   module CloudinaryService
-    VERSION = '0.2.1'.freeze
+    VERSION = '0.2.2'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activestorage-cloudinary-service
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Osmond Oscar
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-11 00:00:00.000000000 Z
+date: 2018-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: '3.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: '3.7'
 description: 
 email:
 - oskarromero3@gmail.com