activerecord_views 0.0.12 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1bc9898154793aaeadd3252f3ae9f691dd43669f
-  data.tar.gz: fdea9d04caa3e922a45725436532f9db48d175d8
+  metadata.gz: f3c9db1b593bf137570cde8f2e4fcaf6837aa414
+  data.tar.gz: 81143c5d6e77cfe47971b9bca74dde2f8a1c3847
 SHA512:
-  metadata.gz: 4658c236510c130b3f197beaf66d04f569c7b8fae0861e4ea32e4205172ea6c2213ea30ce13750025745dbe287bf714900e1b5e426ce5c439ad9a2ec3540933e
-  data.tar.gz: 47f78f0aaafcddf3186f1c3f7574d141e74955e2d211a1cdb406cf0e1382b8609f8214f2e1769ac84ac0562d781a01cad752073870f29fb9c3443e4498ef1e87
+  metadata.gz: fcf258e4d370ee70ad3a96488271d206ec7e8fe27dce4c123b9a176a10d12cd06cf2c1f3d7f2c21446a98045015967cbc4130d8414e48db0b9d1081e8afb6691
+  data.tar.gz: 684a7373b1167ab08a20f565e7f33c93cc5420e85ec34186488af74f36772672927dcaa993198273d83f568fd05ffae05eaf2c8a40d55096a80af1ea9785ac8d

data/README.markdown

@@ -121,6 +121,8 @@ AccountBalance.refresh_view!
 AccountBalance.view_populated? # => true
 ```
 
+ActiveRecordViews records when a view was last refreshed. This is often useful for giving users an idea of how stale data. To retrieve this timestamp, call `.refreshed_at` on the model:
+
 PostgreSQL 9.4 supports refreshing materialized views concurrently. This allows other processes to continue reading old cached data while the view is being updated. To use this feature you must have define a unique index on the materialized view:
 
 ```sql

data/lib/active_record_views/checksum_cache.rb

@@ -22,8 +22,12 @@ module ActiveRecordViews
         @connection.execute "ALTER TABLE active_record_views ADD COLUMN options json NOT NULL DEFAULT '{}';"
       end
 
+      if table_exists && !@connection.column_exists?('active_record_views', 'refreshed_at')
+        @connection.execute "ALTER TABLE active_record_views ADD COLUMN refreshed_at timestamp;"
+      end
+
       unless table_exists
-        @connection.execute "CREATE TABLE active_record_views(name text PRIMARY KEY, class_name text NOT NULL UNIQUE, checksum text NOT NULL, options json NOT NULL DEFAULT '{}');"
+        @connection.execute "CREATE TABLE active_record_views(name text PRIMARY KEY, class_name text NOT NULL UNIQUE, checksum text NOT NULL, options json NOT NULL DEFAULT '{}', refreshed_at timestamp);"
       end
     end
 

data/lib/active_record_views/extension.rb

@@ -48,7 +48,10 @@ module ActiveRecordViews
           raise ArgumentError, 'invalid concurrent option'
         end
 
-        connection.execute "REFRESH MATERIALIZED VIEW#{' CONCURRENTLY' if concurrent} #{connection.quote_table_name self.table_name};"
+        connection.transaction do
+          connection.execute "REFRESH MATERIALIZED VIEW#{' CONCURRENTLY' if concurrent} #{connection.quote_table_name self.table_name};"
+          connection.execute "UPDATE active_record_views SET refreshed_at = current_timestamp AT TIME ZONE 'UTC' WHERE name = #{connection.quote self.table_name};"
+        end
       end
 
       def view_populated?
@@ -64,6 +67,18 @@ module ActiveRecordViews
 
         ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES.include?(value)
       end
+
+      def refreshed_at
+        value = connection.select_value(<<-SQL.squish)
+          SELECT refreshed_at
+          FROM active_record_views
+          WHERE name = #{connection.quote self.table_name};
+        SQL
+
+        if value
+          ActiveSupport::TimeZone['UTC'].parse(value)
+        end
+      end
     end
   end
 end

data/lib/active_record_views/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordViews
-  VERSION = '0.0.12'
+  VERSION = '0.0.13'
 end

data/spec/active_record_views_checksum_cache_spec.rb

@@ -62,7 +62,7 @@ describe ActiveRecordViews::ChecksumCache do
       end
     end
 
-    context 'existing table without options' do
+    context 'existing table without options or refreshed at timestamp' do
       before do
         connection.execute 'CREATE TABLE active_record_views(name text PRIMARY KEY, class_name text NOT NULL UNIQUE, checksum text NOT NULL);'
 
@@ -71,14 +71,17 @@ describe ActiveRecordViews::ChecksumCache do
       end
 
       it 'upgrades the table without losing data' do
-        expect(ActiveRecord::Base.connection).to receive(:execute).with("ALTER TABLE active_record_views ADD COLUMN options json NOT NULL DEFAULT '{}';").once.and_call_original
-
         expect(connection.column_exists?('active_record_views', 'options')).to eq false
+        expect(connection.column_exists?('active_record_views', 'refreshed_at')).to eq false
         expect(ActiveRecordViews.view_exists?(connection, 'test_view')).to eq true
 
+        expect(ActiveRecord::Base.connection).to receive(:execute).with("ALTER TABLE active_record_views ADD COLUMN options json NOT NULL DEFAULT '{}';").once.and_call_original
+        expect(ActiveRecord::Base.connection).to receive(:execute).with("ALTER TABLE active_record_views ADD COLUMN refreshed_at timestamp;").once.and_call_original
+
         ActiveRecordViews::ChecksumCache.new(connection)
 
         expect(connection.column_exists?('active_record_views', 'options')).to eq true
+        expect(connection.column_exists?('active_record_views', 'refreshed_at')).to eq true
         expect(ActiveRecordViews.view_exists?(connection, 'test_view')).to eq true
       end
     end

data/spec/active_record_views_extension_spec.rb

@@ -149,8 +149,14 @@ describe ActiveRecordViews::Extension do
         }.to raise_error ActiveRecord::StatementInvalid, /materialized view "materialized_view_test_models" has not been populated/
 
         expect(MaterializedViewTestModel.view_populated?).to eq false
+        expect(MaterializedViewTestModel.refreshed_at).to eq nil
+
         MaterializedViewTestModel.refresh_view!
+
         expect(MaterializedViewTestModel.view_populated?).to eq true
+        expect(MaterializedViewTestModel.refreshed_at).to be_a ActiveSupport::TimeWithZone
+        expect(MaterializedViewTestModel.refreshed_at.zone).to eq 'UTC'
+        expect(MaterializedViewTestModel.refreshed_at).to be_within(1.second).of Time.now
 
         expect(MaterializedViewTestModel.first!.id).to eq 123
 
@@ -182,8 +188,18 @@ describe ActiveRecordViews::Extension do
       end
       MaterializedViewConcurrentRefreshTestModel.refresh_view!
 
-      expect(ActiveRecord::Base.connection).to receive(:execute).with('REFRESH MATERIALIZED VIEW "materialized_view_refresh_test_models";').once.and_call_original
-      expect(ActiveRecord::Base.connection).to receive(:execute).with('REFRESH MATERIALIZED VIEW CONCURRENTLY "materialized_view_concurrent_refresh_test_models";').once.and_call_original
+      [
+        'BEGIN',
+        'REFRESH MATERIALIZED VIEW "materialized_view_refresh_test_models";',
+        "UPDATE active_record_views SET refreshed_at = current_timestamp AT TIME ZONE 'UTC' WHERE name = 'materialized_view_refresh_test_models';",
+        'COMMIT',
+        'BEGIN',
+        'REFRESH MATERIALIZED VIEW CONCURRENTLY "materialized_view_concurrent_refresh_test_models";',
+        "UPDATE active_record_views SET refreshed_at = current_timestamp AT TIME ZONE 'UTC' WHERE name = 'materialized_view_concurrent_refresh_test_models';",
+        'COMMIT',
+      ].each do |sql|
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(sql).once.and_call_original
+      end
 
       MaterializedViewRefreshTestModel.refresh_view!
       MaterializedViewConcurrentRefreshTestModel.refresh_view! concurrent: true
@@ -194,8 +210,18 @@ describe ActiveRecordViews::Extension do
         is_view 'SELECT 1 AS id;', materialized: true, unique_columns: [:id]
       end
 
-      expect(ActiveRecord::Base.connection).to receive(:execute).with('REFRESH MATERIALIZED VIEW "materialized_view_auto_refresh_test_models";').once.and_call_original
-      expect(ActiveRecord::Base.connection).to receive(:execute).with('REFRESH MATERIALIZED VIEW CONCURRENTLY "materialized_view_auto_refresh_test_models";').once.and_call_original
+      [
+        'BEGIN',
+        'REFRESH MATERIALIZED VIEW "materialized_view_auto_refresh_test_models";',
+        "UPDATE active_record_views SET refreshed_at = current_timestamp AT TIME ZONE 'UTC' WHERE name = 'materialized_view_auto_refresh_test_models';",
+        'COMMIT',
+        'BEGIN',
+        'REFRESH MATERIALIZED VIEW CONCURRENTLY "materialized_view_auto_refresh_test_models";',
+        "UPDATE active_record_views SET refreshed_at = current_timestamp AT TIME ZONE 'UTC' WHERE name = 'materialized_view_auto_refresh_test_models';",
+        'COMMIT',
+      ].each do |sql|
+        expect(ActiveRecord::Base.connection).to receive(:execute).with(sql).once.and_call_original
+      end
 
       MaterializedViewAutoRefreshTestModel.refresh_view! concurrent: :auto
       MaterializedViewAutoRefreshTestModel.refresh_view! concurrent: :auto

data/spec/active_record_views_spec.rb

@@ -42,6 +42,7 @@ describe ActiveRecordViews do
           'class_name' => 'Test',
           'checksum' => Digest::SHA1.hexdigest('select 1 as id'),
           'options' => '{"materialized":true,"dependencies":[]}',
+          'refreshed_at' => nil,
         }
       ]
     end

data/spec/tasks_spec.rb

@@ -11,6 +11,6 @@ describe 'rake db:structure:dump' do
     sql = File.read('spec/internal/db/structure.sql')
     FileUtils.rm_f 'spec/internal/db/structure.sql'
 
-    expect(sql).to match /COPY active_record_views.+test_view\tTestView/m
+    expect(sql).to match(/COPY active_record_views.+test_view\tTestView/m)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_views
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.13
 platform: ruby
 authors:
 - Jason Weathered
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-24 00:00:00.000000000 Z
+date: 2015-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -155,7 +155,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
 summary: Automatic database view creation for ActiveRecord