activerecord_save_many 0.7.1 → 0.8.0

data/Rakefile

@@ -11,7 +11,7 @@ begin
     gem.homepage = "http://github.com/trampoline/activerecord_save_many"
     gem.authors = ["mccraigmccraig"]
     gem.add_dependency "activerecord_execute_raw", ">= 0.1.0"
-    gem.add_development_dependency "rspec", ">= 1.2.9"
+    gem.add_development_dependency "rspec", ">= 1.2.8"
     gem.add_development_dependency "yard", ">= 0"
     gem.add_development_dependency "rr", ">= 0.10.5"
     # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings

data/VERSION

@@ -1 +1 @@
-0.7.1
+0.8.0

data/lib/activerecord_save_many/save_many.rb

@@ -57,6 +57,22 @@ module ActiveRecord
         @save_many_max_rows || ActiveRecord::SaveMany::default_max_rows
       end
 
+      def set_create_timestamps(timestamp, instance)
+        if instance.record_timestamps
+          instance.write_attribute('created_at', timestamp) if instance.respond_to?(:created_at) && instance.created_at.nil?
+          instance.write_attribute('created_on', timestamp) if instance.respond_to?(:created_on) && instance.created_on.nil?
+          instance.write_attribute('updated_at', timestamp) if instance.respond_to?(:updated_at) && instance.updated_at.nil?
+          instance.write_attribute('updated_on', timestamp) if instance.respond_to?(:updated_on) && instance.updated_on.nil?
+        end
+      end
+
+      def set_update_timestamps(timestamp, instance)
+        if instance.record_timestamps
+          instance.write_attribute('updated_at', timestamp) if instance.respond_to?(:updated_at)
+          instance.write_attribute('updated_on', timestamp) if instance.respond_to?(:updated_on)
+        end
+      end
+
       def save_many(values, options={})
         Functions::check_options(ActiveRecord::SaveMany::OPTIONS_KEYS , options)
         return if values.nil? || values.empty?
@@ -67,14 +83,17 @@ module ActiveRecord
         max_rows = options[:max_rows] || save_many_max_rows
         batches = Functions::slice_array(max_rows, values)
 
+        timestamp = Time.now
         batches.each do |rows|
           rows = rows.map do |obj|
             if obj.is_a? ActiveRecord::Base
               obj.send( :callback, :before_save )
               if obj.id
                 obj.send( :callback, :before_update)
+                set_update_timestamps(timestamp, obj)
               else
                 obj.send( :callback, :before_create )
+                set_create_timestamps(timestamp, obj)
               end
               raise "#{obj.errors.full_messages.join(', ')}" if !obj.valid?
             end

data/spec/activerecord_save_many_spec.rb

@@ -107,10 +107,62 @@ module ActiveRecord
       k2.save_many_max_rows.should == 100
     end
 
+    describe "set_create_timestamps" do
+      it "should set creation timestamps" do
+        k = new_ar_class("Foo") {
+          attr_accessor :created_at
+          attr_accessor :created_on
+          attr_accessor :updated_at
+          attr_accessor :updated_on
+          def write_attribute(name,value)
+            self.send(name+"=", value)
+          end
+        }
+        kinst = k.new
+        stub(kinst).record_timestamps{true}
+
+        t = Time.now
+        k.set_create_timestamps(t,kinst)
+        kinst.created_at.should == t
+        kinst.created_on.should == t
+        kinst.updated_at.should == t
+        kinst.updated_on.should == t
+      end
+    end
+
+    describe "set_update_timestamps" do
+      it "should set update timestamps" do
+        k = new_ar_class("Foo") {
+          attr_accessor :created_at
+          attr_accessor :created_on
+          attr_accessor :updated_at
+          attr_accessor :updated_on
+          def write_attribute(name,value)
+            self.send(name+"=", value)
+          end
+        }
+        kinst = k.new
+        stub(kinst).record_timestamps{true}
+
+        t = Time.now
+        k.set_update_timestamps(t,kinst)
+        kinst.created_at.should == nil
+        kinst.created_on.should == nil
+        kinst.updated_at.should == t
+        kinst.updated_on.should == t
+      end
+    end
+
     # argh. am i really testing the correct sql is generated ?
     describe "save_many" do
       def new_ar_stub(classname, column_names, tablename, match_sql)
-        k=new_ar_class(classname)
+        k=new_ar_class(classname) {
+          attr_accessor :created_at
+          attr_accessor :updated_at
+          def write_attribute(name,value)
+            self.send(name+"=", value)
+          end
+        }
         stub(k).table_name{tablename}
         cns = column_names.map{|cn| col=Object.new ; stub(col).name{cn} ; col}
         stub(k).columns{cns}
@@ -135,6 +187,8 @@ module ActiveRecord
         end
         mock(kinst).valid?(){valid}
 
+        mock(kinst).record_timestamps(){true}
+
         field_hash.keys.each{ |key|
           mock(kinst).[](key){field_hash[key]}
         }
@@ -145,6 +199,8 @@ module ActiveRecord
         k=new_ar_stub("Foo", [:foo, :bar], "foos", "insert into foos (foo,bar) values ('foofoo','barbar')")
         kinst = new_ar_inst(k, nil, true, {:foo=>"foofoo", :bar=>"barbar"})
         k.save_many([kinst])
+        kinst.created_at.should_not == nil
+        kinst.updated_at.should_not == nil
       end
 
       it "should generate extended insert sql for all model columns with existing objects" do

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
-  - 7
-  - 1
-  version: 0.7.1
+  - 8
+  - 0
+  version: 0.8.0
 platform: ruby
 authors: 
 - mccraigmccraig
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-17 00:00:00 +00:00
+date: 2010-05-11 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -41,8 +41,8 @@ dependencies:
         segments: 
         - 1
         - 2
-        - 9
-        version: 1.2.9
+        - 8
+        version: 1.2.8
   type: :development
   version_requirements: *id002
 - !ruby/object:Gem::Dependency