activerecord_csv_importer 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f2dda1af501f14aedbe3f83187fd5f809da764e
-  data.tar.gz: 7efbf3e7a9db826d2d7219ef8b57e68e31807b89
+  metadata.gz: 44eb851d750d0fbaa869e101d8e8ea82cff78155
+  data.tar.gz: 930a65e74c117c66c03780f9580e3a8544887cd9
 SHA512:
-  metadata.gz: 11fde7090c4d650e99c0423ca5b8896d53184fb38fc9b4601747fb9879cb26449f7c85a0db18b82bb840f72cde469013f3c6ab8560c439bcb7cc95134242d790
-  data.tar.gz: fe7af3a43bcddb619102b0069cf385bc3386dffa8e4e7de00c5612afce6275092f0636ad8610493ce858fd053ca43b506ca10090ebaffa9405e96c5e8a8429cb
+  metadata.gz: 7704ec50b0940aadd89bb55b971df9eee9fc68d08cd022a414d095a0741e1b7b2c46e86bf2e61b5602e536fc41f60dd3de7ca63d6452b20aaa48b0f4fa30049a
+  data.tar.gz: 7c5363eddd44dc8b86807af76592434719bbd2d6c275787a745431760f24eedb9fbf4fc12974e45cb0d4444bdb62b88250547ff51c7951cae76ae3777dc49808

data/README.md

@@ -1,11 +1,8 @@
 # ActiveRecordCSVImporter
 
-Using bulk inserts, the goal for ActiveRecordCSVImporter is to speed up the processing of large CSV filed
+ActiveRecordCSVImporter is a modified version CSVImporter, which uses activerecord-import to speed up processing.
 
-## Differences from CSVImporter
-
-The key difference with ActiveRecordCSVImporter is the removal of callback support, since that is incompatible with bulk inserts.
-Additional config options are available instead to deal with batching and duplicate index support.
+The key difference with CSVImporter is the removal of callback support, since that is incompatible with bulk inserts. Additional config options are available instead to deal with batching and index conflicts.
 
 It is compatible with ActiveRecord and any Databases supported by activerecord-import.
 
@@ -323,6 +320,10 @@ You can handle exotic encodings with the `encoding` option.
 ImportUserCSV.new(content: "メール,氏名".encode('SJIS'), encoding: 'SJIS:UTF-8')
 ```
 
+## TODO
+  - Add ability to configure activerecord-import validate: Bool option.
+  - Allow setting a default attribute on columns.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/console` for an interactive prompt that will allow you to experiment.
@@ -331,7 +332,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/activerecord_csv_importer.
+Bug reports and pull requests are welcome on GitHub at https://github.com/desheikh/activerecord_csv_importer.
 
 ## License
 

data/lib/activerecord_csv_importer/header.rb

@@ -15,10 +15,16 @@ module ActiveRecordCSVImporter
       end
     end
 
+    # original csv column names
     def columns_with_definition_names
       columns.select(&:definition).map(&:name)
     end
 
+    # mapped column names
+    def column_definition_names
+      column_definitions.map(&:name).map(&:to_s)
+    end
+
     def column_name_for_model_attribute(attribute)
       column = columns.find { |c|
         c.definition.attribute == attribute if c.definition
@@ -53,9 +59,5 @@ module ActiveRecordCSVImporter
         column_definition.match?(name)
       }
     end
-
-    def column_definition_names
-      column_definitions.map(&:name).map(&:to_s)
-    end
   end
 end

data/lib/activerecord_csv_importer/row.rb

@@ -33,7 +33,7 @@ module ActiveRecordCSVImporter
       if column_definition.to && column_definition.to.is_a?(Proc)
         column_definition.to.call(csv_value)
       else
-        column_definition.attribute
+        csv_value
       end
     end
   end

data/lib/activerecord_csv_importer/version.rb

@@ -1,3 +1,3 @@
 module ActiveRecordCSVImporter
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_csv_importer
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Zulfiqar Ali
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-11-12 00:00:00.000000000 Z
+date: 2016-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus