activerecord_chronological_records 0.1.0 → 0.2.0

data/README.md

@@ -23,14 +23,14 @@ This will assume you have `start_date` and `end_date` columns on the model. To c
 Following scopes are defined at class level that return all records matching specific condition:
 
 * `Class.current` - records valid at current date
-* `Class.at(date)` - records valid at given date
+* `Class.effective_at(date)` - records valid at given date
 
 ### Instance methods
 
 Following instance methods are defined for navigation between versions or record. Can return nil if no version matches the condition.
 
 * `instance.current` - version of instance valid at current date
-* `instance.at(date)` - version of instance valid at given date
+* `instance.effective_at(date)` - version of instance valid at given date
 * `instance.earliest` - first version of record
 * `instance.latest` - last version of record
 * `instance.previous` - version before the one method is being called on

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.2.0

data/activerecord_chronological_records.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "activerecord_chronological_records"
-  s.version = "0.1.0"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Toms Mikoss"]
-  s.date = "2012-11-12"
+  s.date = "2012-11-13"
   s.description = "Provides a set of helper methods for dealing with chronological records that have common primary key and date columns denoting when the record is active (example: Oracle EBS tables)."
   s.email = "toms.mikoss@gmail.com"
   s.extra_rdoc_files = [

data/lib/activerecord_chronological_records.rb

@@ -7,26 +7,26 @@ module ActiverecordChronologicalRecords
     end
 
     self.instance_eval <<-EOS
-      def at(date)
-        where("#{start_column} <= :date AND (#{end_column} >= :date OR #{end_column} IS NULL)", :date => date)
+      def effective_at(date)
+        where("(#{start_column} <= :date OR #{start_column} IS NULL) AND (#{end_column} >= :date OR #{end_column} IS NULL)", :date => date)
       end
 
       def current
-        at(Time.now)
+        effective_at(Time.now)
       end
 EOS
 
     self.class_eval <<-EOS
-      def at(date)
-        #{self}.at(date).where(:#{primary_key} => self.#{primary_key}).first
+      def effective_at(date)
+        #{self}.effective_at(date).where(:#{primary_key} => self.#{primary_key}).first
       end
 
       def current
-        at(Time.now)
+        effective_at(Time.now)
       end
 
       def current?
-        #{start_column}.to_time <= Time.now && #{end_column}.to_time >= Time.now
+        (#{start_column}.blank? || #{start_column}.to_time <= Time.now) && (#{end_column}.blank? || #{end_column}.to_time >= Time.now)
       end
 
       def earliest
@@ -38,11 +38,11 @@ EOS
       end
 
       def previous
-        at(#{start_column} - 1.day)
+        effective_at(#{start_column} - 1.day)
       end
 
       def next
-        at(#{end_column} + 1.day)
+        effective_at(#{end_column} + 1.day)
       end
 EOS
   end

data/spec/activerecord_chronological_records_spec.rb

@@ -16,14 +16,14 @@ describe "ActiverecordChronologicalRecords" do
 
   shared_examples "scopes" do
     specify { Employee.current.all.should eq [@current_record] }
-    specify { Employee.at(Date.today).all.should eq [@current_record] }
-    specify { Employee.at(Date.today - 2.months).all.should eq [@first_record] }
-    specify { Employee.at(Date.today + 2.months).all.should eq [@last_record] }
+    specify { Employee.effective_at(Date.today).all.should eq [@current_record] }
+    specify { Employee.effective_at(Date.today - 2.months).all.should eq [@first_record] }
+    specify { Employee.effective_at(Date.today + 2.months).all.should eq [@last_record] }
   end
 
   shared_examples "navigation methods" do
     specify { @first_record.current.should eq @current_record }
-    specify { @first_record.at(Date.today).should eq @current_record }
+    specify { @first_record.effective_at(Date.today).should eq @current_record }
     specify { @current_record.earliest.should eq @first_record }
     specify { @current_record.latest.should eq @last_record }
     specify { @current_record.previous.should eq @first_record }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord_chronological_records
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-12 00:00:00.000000000 Z
+date: 2012-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -144,7 +144,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -609177617
+      hash: -126950927
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: