activerecord 4.0.3 → 4.0.4.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6db6e96ad6545b979c2f76d92bce1f6062e5f3b7
-  data.tar.gz: d8195989b1dc14af19653ff60158301d1bacb0d9
+  metadata.gz: 8d61ddb97baf7a76460c7ccde98f0b6697fef69e
+  data.tar.gz: 5231097ee413082d2d8070067b837f5971ef651b
 SHA512:
-  metadata.gz: ac29a96f859a590c33dfdcd670342b133a4871f1db0b19c5d3c31b6fe0ca3e54b97aef90995a0b8d32e71028bcdfb1abdeb4b2d3a5ae8af94eeb6c80ab127424
-  data.tar.gz: 11b902aa9480022875b6e268f7819b5af03e8fa99009d342aa1348924bfaf829f730cd916330c0e5e707c4cd478f841ef56a75093b8c020d829c90d2b60b1381
+  metadata.gz: 9383667f82e9d122da7073559dd03af930e0fd890a606536c7d8af5393c810fbc216e5edb9a8dd53c061f4b0725ea83fd54cb730493569ddca222b1322044450
+  data.tar.gz: 8f8e3aab398e7d3da678e26934736cef358d9979f6b374800f5524abfc3a0e81053f651aead561ff0d36a030b6fac14252c646fbd882a1940a20a2ff44a54d97

data/CHANGELOG.md

@@ -1,3 +1,415 @@
+## Rails 4.0.4 ##
+
+*   Only save has_one associations if record has changes.
+    Previously after save related callbacks, such as `#after_commit`, were triggered when the has_one
+    object did not get saved to the db.
+
+    *Alan Kennedy*
+
+*   Fixed STI classes not defining an attribute method if there is a
+    conflicting private method defined on its ancestors.
+
+    Fixes #11569.
+
+    *Godfrey Chan*
+
+*   Fix validation on uniqueness of empty association.
+
+    *Evgeny Li*
+
+*   Perform necessary deeper encoding when hstore is inside an array.
+
+    Fixes #11135.
+
+    *Josh Goodall*, *Genadi Samokovarov*
+
+*   Properly detect if a connection is still active before using it
+    in multi-threaded environments.
+
+    Fixes #12867.
+
+    *Kevin Casey*, *Matthew Draper*, *William (B.J.) Snow Orvis*
+
+*   When inverting add_index use the index name if present instead of
+    the columns.
+
+    If there are two indices with matching columns and one of them is
+    explicitly named then reverting the migration adding the named one
+    would instead drop the unnamed one.
+
+    The inversion of add_index will now drop the index by its name if
+    it is present.
+
+    *Hubert Dąbrowski*
+
+*   Make sure transaction state gets reset after a commit operation on the record.
+
+    If a new transaction was open inside a callback, the record was loosing track
+    of the transaction level state, and it was leaking that state.
+
+    Fixes #12566.
+
+    *arthurnn*
+
+*   PostgreSQL implementation of `SchemaStatements#index_name_exists?`.
+
+    The database agnostic implementation does not detect with indexes that are
+    not supported by the ActiveRecord schema dumper. For example, expressions
+    indexes would not be detected.
+
+    Fixes #11018.
+
+    *Jonathan Baudanza*
+
+*   Parsing PostgreSQL arrays with empty strings now works correctly.
+
+    Previously, if you tried to parse `{"1","","2","","3"}` the result
+    would be `["1","2","3"]`, removing the empty strings from the array,
+    which would be incorrect. Now it will correctly produce `["1","","2","","3"]`
+    as the result of parsing the above PostgreSQL array.
+
+    Fixes #13907.
+
+    *Maurício Linhares*
+
+*   Fix regressions on `select_*` methods.
+    When `select_*` methods receive a `Relation` object, they should be able to get the arel/binds from it.
+    Also fix regressions on select_rows that was ignoring the binds.
+
+    Fixes #7538, #12017, #13731, #12056.
+
+    *arthurnn*
+
+*   Correctly send an user provided statement to a `lock!()` call.
+
+        person.lock! 'FOR SHARE NOWAIT'
+        # Before: SELECT * ... LIMIT 1 FOR UPDATE
+        # After: SELECT * ... LIMIT 1 FOR SHARE NOWAIT
+
+    Fixes #13788.
+
+    *Maurício Linhares*
+
+*   Active Record objects can now be correctly dumped, loaded and dumped again without issues.
+
+    Previously, if you did `YAML.dump`, `YAML.load` and then `YAML.dump` again
+    in an ActiveRecord model that used serialization it would fail at the last
+    dump due to the fields not being correctly serialized before being dumped
+    to YAML. Now it is possible to dump and load the same object as many times
+    as needed without any issues.
+
+    Fixes #13861.
+
+    *Maurício Linhares*
+
+*   `has_one` and `belongs_to` accessors don't add ORDER BY to the queries anymore.
+
+    Since Rails 4.0, we add an ORDER BY in the `first` method to ensure consistent results
+    among different database engines. But for singular associations this behavior is not needed
+    since we will have one record to return. As this ORDER BY option can lead some performance
+    issues we are removing it for singular associations accessors.
+
+    Fixes #12623.
+
+    *Rafael Mendonça França*
+
+*   Fail early with "Primary key not included in the custom select clause"
+    in `find_in_batches`.
+
+    Before this patch, the exception was raised after the first batch was
+    yielded to the block. This means that you only get it, when you hit the
+    `batch_size` treshold. This could shadow the issue in development.
+
+    *Alexander Balashov*
+
+*   ActiveRecord states are now correctly restored after a rollback for
+    models that did not define any transactional callbacks (i.e.
+    `after_commit`, `after_rollback` or `after_create`).
+
+    Fixes #13744.
+
+    *Godfrey Chan*
+
+*   Add back `#yaml_initialize` method for Syck deserialization
+
+    `ActiveRecord::Core#yaml_initialize` has been added back to support deserialization using
+    the Syck engine. This is to facilitate migration from Syck to Psych. Serialization support
+    will not been restored for Syck, Psych should be used to serialize YAML once its been
+    parsed with Syck.
+
+    *Blake Mesdag*, *arthurnn*
+
+*   Make `touch` fire the `after_commit` and `after_rollback` callbacks.
+
+    *Harry Brundage*
+
+*   Don't try to get the subclass if the inheritance column doesn't exist
+
+    The `subclass_from_attrs` method is called even if the column specified by
+    the `inheritance_column` setting doesn't exist. This prevents setting associations
+    via the attributes hash if the association name clashes with the value of the setting,
+    typically `:type`. This worked previously in Rails 3.2.
+
+    *Ujjwal Thaakar*
+
+*   Fix bug in `becomes!` when changing from the base model to a STI sub-class.
+
+    Fixes #13272.
+
+    *the-web-dev*, *Yves Senn*
+
+*   Initialize version on Migration objects so that it can be used in a migration,
+    and it will be included in the announce message.
+
+    *Dylan Thacker-Smith*
+
+*   `change_table` now uses the current adapter's `update_table_definition`
+    method to retrieve a specific table definition.
+    This ensures that `change_table` and `create_table` will use
+    similar objects.
+
+    Fixes #13577 and #13503.
+
+    *Nishant Modak*, *Prathamesh Sonpatki*, *Rafael Mendonça França*
+
+*   Fixed ActiveRecord::Store nil conversion TypeError when using YAML coder.
+    In case the YAML passed as paramter is nil, uses an empty string.
+
+    Fixes #13570.
+
+    *Thales Oliveira*
+
+*   Fix presence validator for association when the associated record responds to `to_a`.
+
+    *gmarik*
+
+*   Fix bug in `belongs_to` association with `touch: true`.
+    Associated records are no longer touched, when they are already destroyed.
+
+    Fixes #13445.
+
+    Example:
+
+        # Given Comment has belongs_to :post, touch: true
+        comment.post.destroy
+        comment.destroy # no longer touches post
+
+    *Paul Nikitochkin*
+
+*   Fixed `update_column`, `update_columns`, and `update_all` to correctly serialize
+    values for `array`, `hstore` and `json` column types in PostgreSQL.
+
+    Fixes #12261.
+
+    *Tadas Tamosauskas*, *Carlos Antonio da Silva*
+
+*   Do not consider PostgreSQL array columns as number or text columns.
+
+    The code uses these checks in several places to know what to do with a
+    particular column, for instance AR attribute query methods has a branch
+    like this:
+
+        if column.number?
+          !value.zero?
+        end
+
+    This should never be true for array columns, since it would be the same
+    as running [].zero?, which results in a NoMethodError exception.
+
+    Fixing this by ensuring that array columns in PostgreSQL never return
+    true for number?/text? checks.
+
+    *Carlos Antonio da Silva*
+
+*   Fix a bug when assigning an array containing string numbers to a
+    PostgreSQL integer array column.
+
+    Fixes #13444.
+
+    Example:
+
+        # Given Book#ratings is of type :integer, array: true
+        Book.new(ratings: [1, 2]) # worked before
+        Book.new(ratings: ['1', '2']) # now works as well
+
+    *Damien Mathieu*
+
+*   `db:test:clone` and `db:test:prepare` must load Rails environment.
+
+    `db:test:clone` and `db:test:prepare` use `ActiveRecord::Base`. configurations,
+    so we need to load the Rails environment, otherwise the config wont be in place.
+
+    *arthurnn*
+
+*   Use the right column to type cast grouped calculations with custom expressions.
+
+    Fixes #13230.
+
+    Example:
+
+            # Before
+            Account.group(:firm_name).sum('0.01 * credit_limit')
+            # => { '37signals' => '0.5' }
+
+            # After
+            Account.group(:firm_name).sum('0.01 * credit_limit')
+            # => { '37signals' => 0.5 }
+
+    *Paul Nikitochkin*
+
+*   Support deprecated finder options when performing calculations
+    on an association.
+
+    Fixes #13165.
+
+    *Garth Smedley*, *Yves Senn*
+
+*   `ActiveRecord::ConnectionAdapters.string_to_time` respects
+    string with timezone (e.g. Wed, 04 Sep 2013 20:30:00 JST).
+
+    Fixes #12278, #12459.
+
+    *kennyj*, *George Guimarães*
+
+*   Polymorphic `belongs_to` associations with the `touch: true` option set update the timestamps of
+    the old and new owner correctly when moved between owners of different types.
+
+    Example:
+
+        class Rating < ActiveRecord::Base
+          belongs_to :rateable, polymorphic: true, touch: true
+        end
+
+        rating = Rating.create rateable: Song.find(1)
+        rating.update_attributes rateable: Book.find(2) # => timestamps of Song(1) and Book(2) are updated
+
+    *Severin Schoepke*
+
+*   `type_to_sql` returns a `String` for unmapped columns. This fixes an error
+    when using unmapped array types in combination with PostgreSQL's `array: true`.
+
+    Fixes #13146.
+
+    Example:
+
+        change_colum :table, :column, :bigint, array: true
+
+    *Jens Fahnenbruck*, *Yves Senn*
+
+*   Previously, the `has_one` macro incorrectly accepts the `counter_cache`
+    option due to a bug, although that options was never supported nor
+    functional on `has_one` and `has_one ... through` relationships. It now
+    correctly raises an `ArgumentError` when passed that option.
+
+    *Godfrey Chan*
+
+*   Update counter cache on a has_many relationship regardless of default scope
+
+    Fix #12952.
+
+    *Uku Taht*
+
+*   Fix bug when validating the uniqueness of an aliased attribute.
+
+    Fixes #12402.
+
+    *Lauro Caetano*
+
+*   Checks to see if the record contains the foreign key to set the inverse automatically.
+
+    *Edo Balvers*
+
+*   Prevent the counter cache from being decremented twice when destroying
+    a record on a has_many :through association.
+
+    Fixes #11079.
+
+    *Dmitry Dedov*
+
+*   Fix bug where has_one associaton record update result in crash, when replaced with itself.
+
+    Fixes #12834.
+
+    *Denis Redozubov*, *Sergio Cambra*
+
+*   Fix uninitialized constant TransactionState error when Marshall.load is used on an Active Record result.
+
+    Fixes #12790.
+
+    *Jason Ayre*
+
+*   Do not add to scope includes values from through associations.
+    Fixed bug when providing `includes` in through association scope, and fetching targets.
+
+    Example:
+        class Vendor < ActiveRecord::Base
+          has_many :relationships, -> { includes(:user) }
+          has_many :users, through: :relationships
+        end
+
+        vendor = Vendor.first
+
+        # Before
+
+        vendor.users.to_a # => Raises exception: not found `:user` for `User`
+
+        # After
+
+        vendor.users.to_a # => No exception is raised
+
+
+    Fixes #12242, #9517, #10240.
+
+    *Paul Nikitochkin*
+
+*   Save `has_one` association when primary key is manually set.
+
+    Fixes #12302.
+
+    *Lauro Caetano*
+
+*    Allow any version of BCrypt when using `has_secury_password`.
+
+     *Mike Perham*
+
+*   Assign inet/cidr attribute with `nil` value for invalid address.
+
+    Example:
+
+        record = User.new
+
+        record.logged_in_from_ip # is type of an inet or a cidr
+
+        # Before:
+        record.logged_in_from_ip = 'bad ip address' # raise exception
+
+        # After:
+        record.logged_in_from_ip = 'bad ip address' # do not raise exception
+        record.logged_in_from_ip # => nil
+        record.logged_in_from_ip_before_type_cast # => 'bad ip address'
+
+    *Paul Nikitochkin*
+
+*   `rake db:structure:dump` no longer crashes when the port was specified as `Fixnum`.
+
+    *Kenta Okamoto*
+
+*   Fix a bug where rake db:structure:load crashed when the path contained
+    spaces.
+
+    *Kevin Mook*
+
+*   `ActiveRecord::QueryMethods#unscope` unscopes negative equality
+
+    Allows you to call `#unscope` on a relation with negative equality
+    operators, i.e. `Arel::Nodes::NotIn` and `Arel::Nodes::NotEqual` that have
+    been generated through the use of `where.not`.
+
+    *Eric Hankins*
+
+
+## Rails 4.0.3 (February 18, 2014) ##
+
 *   Correctly escape PostgreSQL arrays.
 
     Fixes: CVE-2014-0080

data/lib/active_record/associations.rb

@@ -657,8 +657,8 @@ module ActiveRecord
     #   class Asset < ActiveRecord::Base
     #     belongs_to :attachable, polymorphic: true
     #
-    #     def attachable_type=(sType)
-    #        super(sType.to_s.classify.constantize.base_class.to_s)
+    #     def attachable_type=(klass)
+    #        super(klass.to_s.classify.constantize.base_class.to_s)
     #     end
     #   end
     #

data/lib/active_record/associations/association.rb

@@ -70,7 +70,7 @@ module ActiveRecord
       # The target is stale if the target no longer points to the record(s) that the
       # relevant foreign_key(s) refers to. If stale, the association accessor method
       # on the owner will reload the target. It's up to subclasses to implement the
-      # state_state method if relevant.
+      # stale_state method if relevant.
       #
       # Note that if the target has not been loaded, it is not considered stale.
       def stale_target?
@@ -235,7 +235,12 @@ module ActiveRecord
         # Returns true if inverse association on the given record needs to be set.
         # This method is redefined by subclasses.
         def invertible_for?(record)
-          inverse_reflection_for(record)
+          foreign_key_for?(record) && inverse_reflection_for(record)
+        end
+
+        # Returns true if record contains the foreign_key
+        def foreign_key_for?(record)
+          record.has_attribute?(reflection.foreign_key)
         end
 
         # This should be implemented to return the values of the relevant key(s) on the owner,