activerecord-virgodb-adapter 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b21e3613bde955c3741ba92692bb2465036783609e4d11f9540ce0283ea83732
-  data.tar.gz: 34b1d14f797d629a6f09c029d422803353df2d86cb8c0682883bbb90d56fde18
+  metadata.gz: c9adcef53b08377de04eaa8a3efb42a9ef26af8c9d21d354417a9431374ffb5b
+  data.tar.gz: '089277465d82f97c0075bb1641c46bd37e02a3c44d0e3f627d02962a473bfcfd'
 SHA512:
-  metadata.gz: cbafb03b4df28cc059ed39deffd6504916232cb545b4ae2c7bce66e55121837e90cb3a76c8ecc6fd074277665abd6c438042ecce57530a5960b0fc6391a2d314
-  data.tar.gz: 79aae8c9a8cbcc419ac83295f371d24122cfddf291d5974c473d23cbafa512b3a177109197b86f090c349af594eb1533d47bea3e2bd84e7a2a28fe835d08c02a
+  metadata.gz: f7c81193bd344ef5e4120c7147e4374d5421fb17e129937b829bb6f01fcc59ec8e1734916f7c85e2a07ff3b66687a09de0cc361a6489bc85459fb4e086083894
+  data.tar.gz: 5df55c10f41ff7fd8264e561e470966fa3b9aadf8e7691304f6ad0d8336fb0939780782df4c03a33b68369f691a357ca70a146261f3f812c891c7c5ada66a2e9

data/lib/active_record/connection_adapters/virgodb_adapter.rb

@@ -458,8 +458,8 @@ module ActiveRecord
         next_version = (select_value("SELECT MAX(version) FROM schema_versions WHERE table_name = #{quote(table_name)}") || 0).to_i + 1
 
         execute(<<~SQL)
-          INSERT INTO schema_versions (table_name, version, columns, applied_at)
-          VALUES (#{quote(table_name)}, #{next_version}, #{quote(cols.to_json)}, #{Time.now.to_i})
+          INSERT INTO schema_versions (table_name, version, columns)
+          VALUES (#{quote(table_name)}, #{next_version}, #{quote(cols.to_json)})
         SQL
       end
 
@@ -471,14 +471,21 @@ module ActiveRecord
       # in manifest/src/lib.rs for why (breaks a real structure_dump/
       # structure_load round trip the moment any host app's
       # ActiveRecord::SchemaDumper.ignore_tables is non-empty).
+      #
+      # No `applied_at` column (removed -- nothing ever read it back, see
+      # manifest/src/lib.rs's matching comment on `register_schema_version`).
+      # Breaking format change, no in-place migration: `IF NOT EXISTS` is a
+      # no-op against a manifest that already has the old `applied_at NOT
+      # NULL` shape, so `insert_schema_version!` above would fail against
+      # one -- deliberate, pre-production, existing manifests get dropped
+      # and recreated rather than migrated.
       def ensure_schema_versions_table!
         execute(<<~SQL)
           CREATE TABLE IF NOT EXISTS schema_versions (
             id         INTEGER PRIMARY KEY,
             table_name TEXT NOT NULL,
             version    INTEGER NOT NULL,
-            columns    TEXT NOT NULL,
-            applied_at INTEGER NOT NULL
+            columns    TEXT NOT NULL
           )
         SQL
       end

data/lib/active_record/tasks/virgodb_database_tasks.rb

@@ -141,21 +141,14 @@ module ActiveRecord
       # columns against the CURRENT version, which is exactly what's still
       # dumped.
       #
-      # `applied_at` is dumped as a fixed `0`, and no per-version history
-      # comment is written -- both used to carry real wall-clock data
+      # `schema_versions` has no `applied_at` column as of this adapter
+      # version (removed from the manifest's own schema, see
+      # manifest/src/lib.rs's matching comment on `register_schema_version`
+      # -- nothing ever read it back). It used to carry real wall-clock data
       # (`Time.now.to_i` at migration time), which made this file diff on
       # every clean rebuild (`db:drop` + `db:migrate`) even when the actual
-      # schema hadn't changed at all. Confirmed nothing reads either back:
-      # `current_schema_version` only ever selects `version, columns` (see
-      # above), and this adapter's own `assert_additive!`/
-      # `record_added_column!` only ever read `columns` too. The live
-      # manifest's real `schema_versions` table is untouched by this --
-      # `applied_at` still gets a real timestamp there at migration time,
-      # useful for a human inspecting the live table directly. This only
-      # changes what a fresh `structure_load` seeds into a NEW database,
-      # where a wall-clock value was never reproducible enough to belong in
-      # a checked-in file meant to represent "current schema shape," not
-      # "when someone last regenerated this file."
+      # schema hadn't changed at all -- that's gone now along with the
+      # column, not just papered over here.
       def dump_schema_versions!(filename)
         return unless connection.data_source_exists?("schema_versions")
 
@@ -169,10 +162,9 @@ module ActiveRecord
 
             pretty_columns = JSON.pretty_generate(JSON.parse(latest["columns"]))
             f.puts(
-              "INSERT INTO \"schema_versions\" (id, table_name, version, columns, applied_at) VALUES (\n" \
+              "INSERT INTO \"schema_versions\" (id, table_name, version, columns) VALUES (\n" \
               "  #{latest['id']}, #{connection.quote(table_name)}, #{latest['version']},\n" \
-              "  #{connection.quote(pretty_columns)},\n" \
-              "  0\n" \
+              "  #{connection.quote(pretty_columns)}\n" \
               ");"
             )
             f.puts

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-virgodb-adapter
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - virgodb