activerecord-typedstore 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9f474258f3d2248355c75bfaaed2439a6f17d01
-  data.tar.gz: a7f227175a6583d765931a9feda03e8ede33b4b0
+  metadata.gz: fea522cd38d362c1f89a69c7fd9492b72a4d9057
+  data.tar.gz: 77cd21ab722c5262b9150af01ee94bdd3c6e9539
 SHA512:
-  metadata.gz: f2f2191bb5cec0d4e138b3adeafdd6a779bd032f31c2d93f8862484676afd5683f6fdb7bf230ebe3f6f9a0e9843f6d0b58f1278917c5db5488f684ff6664a978
-  data.tar.gz: 4f74a8624f48916154ffa549d5e0320c3679db8534280c4593669bc4a2f000d32bdd3947dd2e673b75fae4d8708102b8c3c5492a9c76cece3ea6a9026c177cb6
+  metadata.gz: 42332f9a8e566e555e4bee6696ffa7b803f886e0d6a37f589216b8665d0bf94c7726dab22f2878179f3bbc9be13174f2cfcbb07d33d8b08baea3dfd14b35165a
+  data.tar.gz: fcbb9def1916703be1b236f8674795c6779941364199fa4e9997e34adc250f0fa1a1f5acb767b24fef951f237ec88c68a57d1fec7dbf985f6d3d5e182d8f19b9

data/lib/active_record/typed_store/extension.rb

@@ -57,12 +57,12 @@ module ActiveRecord::TypedStore
     end
 
     def clear_attribute_change(attr_name)
-      return if self.class.store_accessors.include?(attr_name.to_sym)
+      return if self.class.store_accessors.include?(normalize_attribute(attr_name))
       super
     end
 
     def read_attribute(attr_name)
-      if self.class.store_accessors.include?(attr_name.to_sym)
+      if self.class.store_accessors.include?(normalize_attribute(attr_name))
         return public_send(attr_name)
       end
       super
@@ -96,5 +96,14 @@ module ActiveRecord::TypedStore
         super
       end
     end
+
+    def normalize_attribute(attr)
+      case attr
+      when Symbol
+        attr
+      else
+        attr.to_s.to_sym
+      end
+    end
   end
 end

data/lib/active_record/typed_store/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module TypedStore
-    VERSION = '1.1.0'
+    VERSION = '1.1.1'
   end
 end

data/spec/active_record/typed_store_spec.rb

@@ -145,6 +145,14 @@ shared_examples 'any model' do
       model.name = 'foo'
       expect(model.read_attribute(:name)).to be == 'foo'
     end
+
+    it 'is accessible through #read_attribute when attribute is nil' do
+      expect(model.read_attribute(nil)).to be_nil
+    end
+
+    it 'allows #increment! when attribute is nil' do
+      expect { model.increment!(nil) }.to raise_error(ActiveModel::MissingAttributeError)
+    end
   end
 
   describe 'string attribute' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-typedstore
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Jean Boussier