activerecord-turntable 4.4.0 → 4.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0bb7d81afbaa8937a6f248d0b755e7a00da9d5471d5ec235d9c2bf0db14028d9
-  data.tar.gz: a67d03e3df1c3084b488f370a517c63e4d209a2590d40602b5ccbff115221997
+  metadata.gz: 2707b7fb927d92576addebf9aea39a01bc9d926186f4c3325f201d6c9736c54e
+  data.tar.gz: 6832f239569dcc570eb2f27ddcc7558a32412a41f7b040f55492d4f310b21f36
 SHA512:
-  metadata.gz: 8609ab1d338c91ae68e5681b6ac5588b5546177e35793363d0b1caaef156953a44a8cf5716dbb6b8702c7e2a3ccc4ea4a6e1cbdfa12e53492e1ab918c7c7ba17
-  data.tar.gz: 7d917139b63470b12a67e2a3eceaa075845a1510dee2202d067114d3b2ef388bfc8e85fb883b21815f25388c657388707546060055d0a38a6603be02ae499ce7
+  metadata.gz: 5a125f0773e370a2843eda9af85e058e5739e5727d8bd3707ca63bb1288948395ab1501ff8ebb2542eacde3390a46126d22d7bc714123a6dcae66a2b730766c0
+  data.tar.gz: 9f757cf609f41a9dab3f27b10bd59cf33f726dae96a925642cb5d5d32f816610c2f08c68c1b14b69c3fbbd7881366b5950be7c299abed4fd4c0f9749adf10533

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## activerecord-turntable 4.4.1 ##
+
+### Bugfix
+
+* Fix performance degragation about handling connection on v4.4.0 and earlier v4 releases.
+
 ## activerecord-turntable 4.4.0 ##
 
 ### Major Changes

data/README.md

@@ -27,7 +27,7 @@ MySQL only.
 Add to Gemfile:
 
 ```ruby
-gem 'activerecord-turntable', '~> 4.4.0'
+gem 'activerecord-turntable', '~> 4.4.1'
 ```
 
 Run a bundle install:

data/lib/active_record/turntable/active_record_ext/connection_handler_extension.rb

@@ -1,28 +1,14 @@
 module ActiveRecord::Turntable
   module ActiveRecordExt
     module ConnectionHandlerExtension
+      def owner_to_turntable_pool
+        @owner_to_turntable_pool ||= Concurrent::Map.new(initial_capacity: 2)
+      end
+
       # @note Override not to establish_connection destroy existing connection pool proxy object
       def retrieve_connection_pool(spec_name)
-        owner_to_pool.fetch(spec_name) do
-          # Check if a connection was previously established in an ancestor process,
-          # which may have been forked.
-          if ancestor_pool = pool_from_any_process_for(spec_name)
-            if ancestor_pool.is_a?(ActiveRecord::ConnectionAdapters::ConnectionPool)
-              # A connection was established in an ancestor process that must have
-              # subsequently forked. We can't reuse the connection, but we can copy
-              # the specification and establish a new connection with it.
-              spec = ancestor_pool.spec
-              spec = spec.to_hash if spec.respond_to?(:to_hash)
-              establish_connection(spec).tap do |pool|
-                pool.schema_cache = ancestor_pool.schema_cache if ancestor_pool.schema_cache
-              end
-            else
-              # Use same PoolProxy object
-              owner_to_pool[spec_name] = ancestor_pool
-            end
-          else
-            owner_to_pool[spec_name] = nil
-          end
+        owner_to_turntable_pool.fetch(spec_name) do
+          super
         end
       end
     end

data/lib/active_record/turntable/base.rb

@@ -61,7 +61,7 @@ module ActiveRecord::Turntable
         pp = PoolProxy.new(cp)
 
         self.connection_specification_name = "turntable_pool_proxy::#{name}"
-        ch.send(:owner_to_pool)[connection_specification_name] = pp
+        ch.owner_to_turntable_pool[connection_specification_name] = pp
       end
 
       def sequencer(sequencer_name, *args)

data/lib/active_record/turntable/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Turntable
-    VERSION = "4.4.0".freeze
+    VERSION = "4.4.1".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-turntable
 version: !ruby/object:Gem::Version
-  version: 4.4.0
+  version: 4.4.1
 platform: ruby
 authors:
 - gussan
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-01 00:00:00.000000000 Z
+date: 2018-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord