activerecord-turntable 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7d26c10b2a5821aa33e7136734bcf2e5ef25080
-  data.tar.gz: 5a4709f8c44aaf2f2d9ac437c8b1bc3ff679fa1d
+  metadata.gz: 8069297634d4cb87e81b6f4e06332ce1d5876183
+  data.tar.gz: bd7470ff554b46af40af99e904add373e3109d46
 SHA512:
-  metadata.gz: c990394e1144fc5f7b20fa6c5a9a2a818e8937683676bb0c5752f26582109a17ef43c8548e8645d811884facf0e4a9a4f196a62b4025947dde23fcfcb65bfbfd
-  data.tar.gz: 7afc6bc759ecbe127e720664888576b91c3628990a02c38bdd1cf5f4af8c71dff0e426f211fee76b640d5d5c6de4f7fbcc13509690c5db6b057007340c2d4323
+  metadata.gz: 7ecad4f8c75a561cedb0fca64e859a045b0518b252cc69c63f4ef31e0312570728e2e0adbe99844de53b2a6f93aaebc2918a7680dc3dfc2b29f252a1238fc4c2
+  data.tar.gz: 1b4d0ab20b846f1abd96fb5f4fd1924829150da9666783f8ecec67f5bf67e521fa422efa31cc5223cffc76f0e96ba152e033190a43f6ec46bd1a0ae725996c63

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## activerecord-turntable 2.0.4 ##
+
+Add dependency: ruby >= 1.9.3 from this release
+
+### Bugfixes
+
+* Fix incorrect insert sql with binary literal
+
 ## activerecord-turntable 2.0.3 ##
 
 ### Bugfixes

data/Rakefile

@@ -51,6 +51,7 @@ namespace :turntable do
         ActiveRecord::Base.connection.create_table :users do |t|
           t.string :nickname
           t.string :thumbnail_url
+          t.binary :blob
           t.datetime :joined_at
           t.datetime :deleted_at
           t.timestamps

data/activerecord-turntable.gemspec

@@ -21,12 +21,13 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
+  spec.required_ruby_version = '>= 1.9.3'
 
-  spec.add_dependency "activerecord",  ">= 4.0.0"
-  spec.add_dependency "activesupport", ">= 4.0.0"
-  spec.add_dependency "sql_tree",      "= 0.2.0"
-  spec.add_dependency "bsearch",       "~> 1.5"
-  spec.add_dependency "httpclient",    ">= 0"
+  spec.add_runtime_dependency "activerecord",  ">= 4.0.0", "< 5.0"
+  spec.add_runtime_dependency "activesupport", ">= 4.0.0", "< 5.0"
+  spec.add_runtime_dependency "sql_tree",      "= 0.2.0"
+  spec.add_runtime_dependency "bsearch",       "~> 1.5"
+  spec.add_runtime_dependency "httpclient",    ">= 0"
 
   # optional dependencies
   spec.add_development_dependency "activerecord-import"

data/lib/active_record/turntable/mixer.rb

@@ -214,7 +214,7 @@ module ActiveRecord::Turntable
         tree.values = [[SQLTree::Node::Expression::Variable.new("\\0")]]
         sql = tree.to_sql
         value_sql = vs.map do |val|
-          "(#{val.map { |v| @proxy.connection.quote(v.value)}.join(', ')})"
+          "(#{val.map { |v| "#{v.escape}#{@proxy.connection.quote(v.value)}" }.join(', ')})"
         end.join(', ')
         sql.gsub!('("\0")') { value_sql }
         shards_with_query[@proxy.cluster.shard_for(k)] = sql

data/lib/active_record/turntable/sql_tree_patch.rb

@@ -208,6 +208,10 @@ module SQLTree::Node
       end
     end
 
+    class Value
+      leaf :escape
+    end
+
     class EscapedValue < Value
       def initialize(value, escape = nil)
         @value = value

data/lib/active_record/turntable/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Turntable
-    VERSION = "2.0.3"
+    VERSION = "2.0.4"
   end
 end

data/spec/active_record/turntable/active_record_ext/persistence_spec.rb

@@ -35,6 +35,20 @@ describe ActiveRecord::Turntable::ActiveRecordExt::Persistence do
     Card.create!(:name => 'foobar')
   }
 
+  context "When creating record" do
+    context "with blob column" do
+      let(:blob_value) { "\123\123\123" }
+      let(:user) {
+        u = User.new(:nickname => 'x', :blob => blob_value )
+        u.id = 1
+        u.save
+        u
+      }
+      subject { user }
+      its(:blob) { is_expected.to eq(user.reload.blob) }
+    end
+  end
+
   context "When the model is sharded by surrogate key" do
     it "should not changed from normal operation when updating" do
       user.nickname = "fizzbuzz"

data/spec/migrations/001_create_users.rb

@@ -3,6 +3,7 @@ class CreateUsers < ActiveRecord::Migration
     create_table :users do |t|
       t.string :nickname
       t.string :thumbnail_url
+      t.binary :blob
       t.datetime :joined_at
       t.datetime :deleted_at
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-turntable
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - gussan
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-18 00:00:00.000000000 Z
+date: 2014-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -18,6 +18,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -25,6 +28,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -32,6 +38,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -39,6 +48,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: sql_tree
   requirement: !ruby/object:Gem::Requirement
@@ -429,7 +441,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="