activerecord-summarize 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbba2c0577555f891c1f860b76cc9f0194504d47d59922c8337afb9a1b3ab1a0
-  data.tar.gz: 3c1945b1652a4305ec4df2d13a0c5a6966e308018d2b34c5c21e396f02a1e31c
+  metadata.gz: d491ee7730156f77105ec7df6bac79b6410fa97b3387816f103dee233b43df8d
+  data.tar.gz: f33be41270ab955fcf2bf9b227cc7c212ae3aa385786da3a5b424a3e1e707e47
 SHA512:
-  metadata.gz: a2a9e27420e30861c5c713e757ae66ead1af9d5aa9e10b259620b10d9289652464fc561745e720bae100cbda1b265e9f551cfd1f05c78f53c8dae39bfd788c33
-  data.tar.gz: 7e8632ae8ced794bdfb539624a64ebeef8d4a0a6568e3f625cca13b0d669365dd309981d351649c2af3a33f21c45e0fed2848853d581681dd0656d55b8163005
+  metadata.gz: 0d1f5308da4fc8b781e8dd5a69a10c671106acdb9b565c056d23b33114fc96f8d4ff9a60f3887b861f9142b2564c3f33f17d9e8ea52c212c27abbdacc861e2d6
+  data.tar.gz: 318bad930ac53001068e6e3396d921f71ff62c8a0899abe7a96a55d9dab59aa7e6e45c2cdc6e7a5f5ae60b67f18a47be79cb73ee29a85e1fac25a988c43dc47a

data/CHANGELOG.md

@@ -1,3 +1,24 @@
+## [0.3.1] - 2022-06-23
+
+- **BUGFIX:** `with` didn't work correctly with a single argument. Embarassingly, both the time-traveling version of `with` and the trivial/fake one provided when `noop: true` is set had single argument bugs, and they were different bugs.
+- **IMPROVEMENT:** Automated tests covering every `with` invocation style I can think of for both implementations and a number of new tests to confirm that `noop: true` produces the same results as (default) `noop: false`.
+- **IMPROVEMENT:** After the initial release I forgot I had a CHANGELOG, and now I've back-filled it.
+
+## [0.3.0] - 2022-06-04
+
+- **BUGFIX:** `.sum(:foo)` of no rows or of all-null values now returns 0 instead of failing (completing partial fix from 0.2.3)
+- **BREAKING:** extremely unlikely to actually break anything, but `.count("distinct id")` now raises as `.distinct.count(:id)` already did. (AFAICT, by the nature of the techniques underlying `summarize`, `distinct` counts cannot be supported.)
+- **IMPROVEMENT:** Automated tests covering basic functions and past problem areas.
+
+## [0.2.3] - 2022-05-01
+
+- **BUGFIX:** Fix results for SQL `SUM(null)` (n.b., this turned out to be only a partial fix)
+- **BUGFIX:** Support summarize with only one query (not often very useful, but it should work!)
+
+## [0.2.2] - 2022-04-29
+
+- **BUGFIX:** Incorrect Arel generation when using `.where(*anything).sum` inside a `summarize` block
+
 ## [0.2.1] - 2022-02-17
 
 - Initial public release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    activerecord-summarize (0.3.0)
+    activerecord-summarize (0.3.1)
       activerecord (>= 5.0)
 
 GEM

data/activerecord-summarize.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject do |f|
-      (f == __FILE__) || f.match(%r{\A(?:(?:test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+      (f == __FILE__) || f.match(%r{\A(?:(?:test|spec|features)/|\.(?:git|travis|circleci|vscode|standard)|appveyor)})
     end
   end
   spec.bindir = "exe"

data/lib/activerecord/summarize/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Summarize
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/lib/activerecord/summarize.rb

@@ -38,7 +38,7 @@ module ActiveRecord::Summarize
 
     def process(&block)
       # For noop, just yield the original relation and a transparent `with` proc.
-      return yield(@relation, ->(*results, &block) { [*results].then(&block) }) if noop?
+      return yield(@relation, ChainableResult::SYNC_WITH) if noop?
       # Within the block, the relation and its future clones intercept calls to
       # `count` and `sum`, registering them and returning a ChainableResult via
       # summarize.add_calculation.

data/lib/chainable_result.rb

@@ -69,7 +69,7 @@ class ChainableResult
   def self.wrap(v, method = nil, *args, **opts, &block)
     method ||= block ? :then : :itself
     klass = case v
-    when ChainableResult then return v # don't wrap, exit early
+    when ChainableResult then ChainableResult::Future
     when ::Array then ChainableResult::Array
     when ::Hash then ChainableResult::Hash
     else ChainableResult::Other
@@ -81,7 +81,13 @@ class ChainableResult
     ChainableResult.wrap(results.size == 1 ? results.first : results, :then, &block)
   end
 
+  def self.sync_with(*results, &block)
+    # Non-time-traveling, synchronous version of `with` for testing
+    (results.size == 1 ? results.first : results).then(&block)
+  end
+
   WITH = method(:with)
+  SYNC_WITH = method(:sync_with)
 
   def self.resolve_item(item)
     case item

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-summarize
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Joshua Paine
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-06-04 00:00:00.000000000 Z
+date: 2022-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -46,7 +46,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".standard.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock

data/.standard.yml

@@ -1,5 +0,0 @@
-# For available configuration options, see:
-#   https://github.com/testdouble/standard
-# ignore:
-#   - 'lib/**/*':
-#     - Layout/DotPosition