activerecord-sqlserver-adapter 5.1.2 → 5.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a08a277e4b09e7e807a8e814dbe442a5f819f605
-  data.tar.gz: d05b3a0be20f6c353430b300e78a80952585582d
+  metadata.gz: 2a40800fd3d59fb80d22946187334124093a6060
+  data.tar.gz: af15e951258df52f8a44807d7e891d2da354d8f0
 SHA512:
-  metadata.gz: d66aed80923e34eaa44a3ef7b2845dc1a6a54699a4bfaeb84caab648dee603ddbf2a78d0afd974853e757d8e6eb041426806ee41a77f15b303b7dbf81051d699
-  data.tar.gz: 2b35fd5e358b1178ef89b1bf0b7bff8f005d9f3cc585dd17a40f9bb5eb097e59151a964edbca5753df879374737bb5667ed51d63b5500482a8a6af24fb6d0da6
+  metadata.gz: f3cd2dd2f39983e7c4b4267666e6960f8f93bf493bab25711e6cbc0b7ab3b41fe134ffb944c6e973b2e19c151a4551ffe669aa66135d708eaf738a73c42abc6b
+  data.tar.gz: bf31bc039ef3250071b784046b5cb6619797692553015f9b96da51b3bb2b08f03b6f676a7634326ba28b79e98c9aa105a3325e39008064adb79afd09f7ca08da

data/.travis.yml

@@ -4,7 +4,7 @@ services:
   - docker
 env:
   global:
-    - TINYTDS_VERSION=2.1.0.pre4
+    - TINYTDS_VERSION=2.1.0
     - ACTIVERECORD_UNITTEST_HOST=localhost
     - ACTIVERECORD_UNITTEST_DATASERVER=localhost
 rvm:

data/CHANGELOG.md

@@ -1,3 +1,24 @@
+## v5.1.5
+
+#### Fixed
+
+* Memoize `@@version` queries. Fixes #632
+
+
+## v5.1.4
+
+#### Fixed
+
+* Add case insensitive comparison for better performance with CI collations. Fixes #624
+
+
+## v5.1.3
+
+#### Fixed
+
+* Use bigint type in sqlserver_type when needed. Fixes #616
+
+
 ## v5.1.2
 
 #### Fixed

data/VERSION

@@ -1 +1 @@
-5.1.2
+5.1.5

data/appveyor.yml

@@ -2,7 +2,7 @@ init:
   - SET PATH=C:\Ruby%ruby_version%\bin;%PATH%
   - SET PATH=C:\MinGW\msys\1.0\bin;%PATH%
   - SET RAKEOPT=-rdevkit
-  - SET TINYTDS_VERSION=2.1.0.pre4
+  - SET TINYTDS_VERSION=2.1.0
 clone_depth: 5
 skip_tags: true
 matrix:

data/circle.yml

@@ -6,7 +6,7 @@ general:
 machine:
   environment:
     PATH: /opt/local/bin:${PATH}
-    TINYTDS_VERSION: 2.1.0.pre4
+    TINYTDS_VERSION: 2.1.0
     ACTIVERECORD_UNITTEST_HOST: localhost
     ACTIVERECORD_UNITTEST_DATASERVER: localhost
   services:

data/lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -84,7 +84,7 @@ module ActiveRecord
         end
 
         def can_perform_case_insensitive_comparison_for?(column)
-          column.type == :string
+          column.type == :string && (!column.collation || column.case_sensitive?)
         end
         private :can_perform_case_insensitive_comparison_for?
 
@@ -247,7 +247,7 @@ module ActiveRecord
           return attr.type.sqlserver_type if attr.type.respond_to?(:sqlserver_type)
           case value = attr.value_for_database
           when Numeric
-            'int'.freeze
+            value > 2_147_483_647 ? 'bigint'.freeze : 'int'.freeze
           else
             'nvarchar(max)'.freeze
           end

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -435,11 +435,14 @@ module ActiveRecord
       end
 
       def version_year
-        vstring = _raw_select('SELECT @@version', fetch: :rows).first.first.to_s
-        return 2016 if vstring =~ /vNext/
-        /SQL Server (\d+)/.match(vstring).to_a.last.to_s.to_i
-      rescue Exception => e
-        2016
+        return @version_year if defined?(@version_year)
+        @version_year = begin
+          vstring = _raw_select('SELECT @@version', fetch: :rows).first.first.to_s
+          return 2016 if vstring =~ /vNext/
+          /SQL Server (\d+)/.match(vstring).to_a.last.to_s.to_i
+        rescue Exception => e
+          2016
+        end
       end
 
     end

data/test/bin/setup.sh

@@ -3,7 +3,7 @@
 set -x
 set -e
 
-tag=2.0
+tag=2017-GA
 
 docker pull metaskills/mssql-server-linux-rails:$tag
 

data/test/config.yml

@@ -19,7 +19,7 @@ connections:
       dataserver: <%= ENV['ACTIVERECORD_UNITTEST_DATASERVER'] %>
       tds_version: <%= ENV['ACTIVERECORD_UNITTEST_TDSVERSION'] %>
       azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
-      timeout: <%= ENV['ACTIVERECORD_UNITTEST_AZURE'].present? ? 20 : nil %>
+      timeout: <%= ENV['ACTIVERECORD_UNITTEST_AZURE'].present? ? 20 : 10 %>
     arunit2:
       <<: *default_connection_info
       database: activerecord_unittest2
@@ -27,5 +27,5 @@ connections:
       dataserver: <%= ENV['ACTIVERECORD_UNITTEST_DATASERVER'] %>
       tds_version: <%= ENV['ACTIVERECORD_UNITTEST_TDSVERSION'] %>
       azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
-      timeout: <%= ENV['ACTIVERECORD_UNITTEST_AZURE'].present? ? 20 : nil %>
+      timeout: <%= ENV['ACTIVERECORD_UNITTEST_AZURE'].present? ? 20 : 10 %>
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.1.5
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-02 00:00:00.000000000 Z
+date: 2017-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -60,7 +60,6 @@ files:
 - Gemfile
 - Guardfile
 - MIT-LICENSE
-- RAILS5-TODO.md
 - README.md
 - RUNNING_UNIT_TESTS.md
 - Rakefile

data/RAILS5-TODO.md

@@ -1,25 +0,0 @@
-
-## Rails v5.1
-
-* BIGINT PK support. https://github.com/rails/rails/pull/26266
-* Raise `ActiveRecord::NotNullViolation` when a record cannot be inserted
-  or updated because it would violate a not null constraint.
-* Raise `ActiveRecord::RangeError` when values that executed are out of range.
-* Allow passing extra flags to `db:structure:load` and `db:structure:dump`
-  Introduces `ActiveRecord::Tasks::DatabaseTasks.structure_(load|dump)_flags` to customize the
-  eventual commands run against the database, e.g. mysqldump/pg_dump.
-* Set `:time` as a timezone aware type and remove deprecation when
-  `config.active_record.time_zone_aware_types` is not explicitly set.
-* Remove deprecated support to passing a column to `#quote`.
-* `#tables` and `#table_exists?` return only tables and not views.
-  All the deprecations on those methods were removed.
-* Remove deprecated `original_exception` argument in `ActiveRecord::StatementInvalid#initialize`
-  and `ActiveRecord::StatementInvalid#original_exception`.
-* Remove deprecated tasks: `db:test:clone`, `db:test:clone_schema`, `db:test:clone_structure`.
-* Make `table_name=` reset current statement cache,
-  so queries are not run against the previous table name.
-* Deprecate using `#quoted_id` in quoting.
-* Deprecate `supports_migrations?` on connection adapters.
-* Dig moving `Column#sqlserver_options` to `sql_type_metadata` delegate.
-* Should we do like PG and add `options[:collation]` before `#add_column_options!`?
-* Translated exceptions: `SerializationFailure` and `RangeError`.