activerecord-sqlserver-adapter 4.2.8 → 4.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6f37e4ce81b63e3fe3375111b70da855a95d1251
-  data.tar.gz: 7b11a582736c9718dbb20097b0b55c392f691b08
+  metadata.gz: 8f5d6ca15cc209e9b813902b9858da21c7e7c884
+  data.tar.gz: 6bd880c3daa536eee4df06414864df65cd8745c4
 SHA512:
-  metadata.gz: f0066beca8922fb26506304059d80069a91f45b9392857e68a2af63640f4706ff300ca4b8e8bb18d807117bb168039188d50d397897488de255b31c454692a1c
-  data.tar.gz: e52261a203dcc9d9124ed6d04113fbcc15887e09b38f18076e213906da9b2b4fbf71e83032b5ee284483c206a28d9bb237f6f04e67cbdcc7e0b68ece791f8fbb
+  metadata.gz: 5245acb11cbaa31099871f12c5a9387776dc5def556bbdcfecc25eebc3a1b167a29ebb14b6aa1cd58ad8fa52241bd58ef0f784aa29167a68a3c4c3d1f55aa9d2
+  data.tar.gz: 514c6fa8bc3c4e7d16df6db884c5705aa6932b5de7b3fd857cfb2346409efe004a117fc8c51de90a4d67ac26c1bca4c1c4753ce25c5913edf17651646809417f

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+## v4.2.9
+
+#### Fixed
+
+* Conform to new data_sources interfaces. See: https://git.io/va4Fp
+* The `primary_key` method falls back to Identity columns. Not the other way around. Fixes #454. Thanks @marceloeloelo
+* Ensure that `execute_procedure` returns proper time zones. Fixes #449
+
+#### Changed
+
+* Run tests with verbose false.
+
 
 ## v4.2.8
 

data/Rakefile

@@ -14,7 +14,7 @@ namespace :test do
       t.libs = ARTest::SQLServer.test_load_paths
       t.test_files = test_files
       t.warning = !!ENV['WARNING']
-      t.verbose = true
+      t.verbose = false
     end
 
   end

data/VERSION

@@ -1 +1 @@
-4.2.8
+4.2.9

data/lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -117,7 +117,8 @@ module ActiveRecord
             case @connection_options[:mode]
             when :dblib
               result = @connection.execute(sql)
-              result.each(as: :hash, cache_rows: true) do |row|
+              options = { as: :hash, cache_rows: true, timezone: ActiveRecord::Base.default_timezone || :utc }
+              result.each(options) do |row|
                 r = row.with_indifferent_access
                 yield(r) if block_given?
               end

data/lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -7,6 +7,10 @@ module ActiveRecord
           @native_database_types ||= initialize_native_database_types.freeze
         end
 
+        def data_sources
+          tables + views
+        end
+
         def tables(table_type = 'BASE TABLE')
           select_values "SELECT #{lowercase_schema_reflection_sql('TABLE_NAME')} FROM INFORMATION_SCHEMA.TABLES #{"WHERE TABLE_TYPE = '#{table_type}'" if table_type} ORDER BY TABLE_NAME", 'SCHEMA'
         end

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -181,7 +181,7 @@ module ActiveRecord
       end
 
       def primary_key(table_name)
-        identity_column(table_name).try(:name) || schema_cache.columns(table_name).find(&:is_primary?).try(:name)
+        schema_cache.columns(table_name).find(&:is_primary?).try(:name) || identity_column(table_name).try(:name)
       end
 
       # === SQLServer Specific (DB Reflection) ======================== #

data/test/cases/execute_procedure_test_sqlserver.rb

@@ -35,4 +35,10 @@ class ExecuteProcedureTestSQLServer < ActiveRecord::TestCase
     assert_equal 'VIEW', table_info['TABLE_TYPE'], "Table Info: #{table_info.inspect}"
   end
 
+  it 'uses the proper timezone' do
+    date_proc = connection.execute_procedure('my_getutcdate').first['utcdate']
+    date_base = connection.select_value('select GETUTCDATE()')
+    assert_equal date_base, date_proc
+  end
+
 end

data/test/schema/sqlserver_specific_schema.rb

@@ -119,6 +119,12 @@ ActiveRecord::Schema.define do
   end
   execute "sp_bindefault 'sst_getdateobject', 'sst_defaultobjects.date'"
 
+  execute "DROP PROCEDURE my_getutcdate" rescue nil
+  execute <<-SQL
+    CREATE PROCEDURE my_getutcdate AS
+    SELECT GETUTCDATE() utcdate
+  SQL
+
   # Constraints
 
   create_table(:sst_has_fks, force: true) { |t| t.column(:fk_id, :integer, null: false) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 4.2.8
+  version: 4.2.9
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-29 00:00:00.000000000 Z
+date: 2016-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord