activerecord-sqlserver-adapter 4.2.4 → 4.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 66376e3352f343f00ed459b35bd3ea825209cd66
-  data.tar.gz: 4b8ee4f3981be083fc8e6be1733e182bef5b3b83
+  metadata.gz: 54dab2a4b34d04529678804457e654cdf3c436b9
+  data.tar.gz: 1719214a6ddc266cd8fad7dec68005cabd6ad9e8
 SHA512:
-  metadata.gz: 35ce29a0a1666f992f6335d0d106a4317abca6891dc758f00a838292db8ddc82e318e0dbe16f6852c1c25a82bdacb44e0bf99598b321c0b4cf86664e49d6b465
-  data.tar.gz: 2d7490d9c29f9cc571e35daab9b5daee3fa6ba910a287b84c5dff9c906f8f9bfb595a730aa90bba4600db63ae8f553ee9df68cba4e56af8a59072b09e750ec69
+  metadata.gz: 3ffd8586472a4bdbbd6a113919085029268a134b4eecc5b924c129e151518aa61a287f7e5120f5c755e28addb73a4a546136952b18d35265a78df8f775bce015
+  data.tar.gz: 2ca086d538c72d86cd508e55cac63ebad56261dcc71eb4f13ae2bd8dd94cb4835b20a7e32acfe9ab551297b201d3af6eaa033fafe139ac1a7a6765d015662e6b

data/CHANGELOG.md

@@ -1,12 +1,30 @@
 
+## v4.2.5
+
+#### Removed
+
+* Remove Type::Castable hacks for core type objects to force trust the DB. Allows Rails 5 attributes.
+
+#### Fixed
+
+* Tests for decimal scale. See Rails commit. http://git.io/vGotB
+* Improve case comparision performace per column. Fixes #414
+* DB rollback when reversable add_column has several options. Fixes #359
+* Better column definitions for default objects. Fixes #412
+
+
 ## v4.2.4
 
+#### Fixed
+
 * Compatible with Rails 4.2.1.
 * Fix schema limit reflection for char/varchar. Fixes #394.
 
 
 ## v4.2.3
 
+#### Fixed
+
 * Fix SET defaults when using Azure.
 * Test insert 4-byte unicode chars.
 * Make rollback transaction transcount aware for implicit error rollbacks. Fixes #390

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,31 @@
+Contributor Code of Conduct
+
+As contributors and maintainers of this project, we pledge to respect all
+people who contribute through reporting issues, posting feature requests,
+updating documentation, submitting pull requests or patches, and other
+activities.
+
+We are committed to making participation in this project a harassment-free
+experience for everyone, regardless of level of experience, gender, gender
+identity and expression, sexual orientation, disability, personal appearance,
+body size, race, ethnicity, age, or religion.
+
+Examples of unacceptable behavior by participants include the use of sexual
+language or imagery, derogatory comments or personal attacks, trolling, public
+or private harassment, insults, or other unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct. Project maintainers who do not
+follow the Code of Conduct may be removed from the project team.
+
+This code of conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by opening an issue or contacting one or more of the project
+maintainers.
+
+This Code of Conduct is adapted from the Contributor Covenant
+(http://contributor-covenant.org), version 1.1.0, available at
+http://contributor-covenant.org/version/1/1/0/

data/Gemfile

@@ -2,6 +2,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'bcrypt'
+gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
 
 if RbConfig::CONFIG["host_os"] =~ /darwin/
   gem 'terminal-notifier-guard'
@@ -17,8 +18,11 @@ else
     spec = eval(File.read('activerecord-sqlserver-adapter.gemspec'))
     version = spec.dependencies.detect{ |d|d.name == 'activerecord' }.requirement.requirements.first.last.version
     major, minor, tiny = version.split('.')
-    uri = URI.parse "http://rubygems.org/api/v1/versions/activerecord.yaml"
-    YAML.load(Net::HTTP.get(uri)).select do |data|
+    uri = URI.parse "https://rubygems.org/api/v1/versions/activerecord.yaml"
+    http = Net::HTTP.new(uri.host, uri.port)
+    http.use_ssl = true
+    http.verify_mode = OpenSSL::SSL::VERIFY_NONE
+    YAML.load(http.request(Net::HTTP::Get.new(uri.request_uri)).body).select do |data|
       a, b, c = data['number'].split('.')
       !data['prerelease'] && major == a && (minor.nil? || minor == b)
     end.first['number']
@@ -34,8 +38,7 @@ group :tinytds do
   if ENV['TINYTDS_SOURCE']
     gem 'tiny_tds', path: ENV['TINYTDS_SOURCE']
   else
-    # TODO: [Rails4] Change back... segfault caused by tiny_tds 0.6.1
-    gem 'tiny_tds', git:"https://github.com/rails-sqlserver/tiny_tds.git"
+    gem 'tiny_tds'
   end
 end
 

data/README.md

@@ -1,14 +1,15 @@
 
 # ActiveRecord SQL Server Adapter. For SQL Server 2012 And Higher.
 
-[![Gem Version](http://img.shields.io/gem/v/activerecord-sqlserver-adapter.svg?style=flat)](https://rubygems.org/gems/activerecord-sqlserver-adapter)
-[![Gitter chat](https://img.shields.io/badge/%E2%8A%AA%20GITTER%20-JOIN%20CHAT%20%E2%86%92-brightgreen.svg?style=flat)](https://gitter.im/rails-sqlserver/activerecord-sqlserver-adapter)
+[![Build status](https://ci.appveyor.com/api/projects/status/mtgbx8f57vr7k2qa/branch/master?svg=true)](https://ci.appveyor.com/project/rails-sqlserver/activerecord-sqlserver-adapter/branch/master) [![Gem Version](http://img.shields.io/gem/v/activerecord-sqlserver-adapter.svg?style=flat)](https://rubygems.org/gems/activerecord-sqlserver-adapter) [![Gitter chat](https://img.shields.io/badge/%E2%8A%AA%20GITTER%20-JOIN%20CHAT%20%E2%86%92-brightgreen.svg?style=flat)](https://gitter.im/rails-sqlserver/activerecord-sqlserver-adapter)
 
 ![kantishna-wide](https://cloud.githubusercontent.com/assets/2381/5895051/aa6a57e0-a4e1-11e4-95b9-23627af5876a.jpg)
 
 ## Code Name Kantishna
 
-The SQL Server adapter for ActiveRecord v4.2 using SQL Server 2012 or higher. If you need the adapter for SQL Server 2008 or 2005, you are still in the right spot. Just install the latest 3.2.x to 4.1.x version of the adapter. We follow a rational versioning policy that tracks ActiveRecord. That means that our 4.2.x version of the adapter is only for the latest 4.2 version of Rails. We also have stable branches for each major/minor release of ActiveRecord.
+The SQL Server adapter for ActiveRecord v4.2 using SQL Server 2012 or higher.
+
+Interested in older versions? We follow a rational versioning policy that tracks Rails. That means that our 4.2.x version of the adapter is only for the latest 4.2 version of Rails. If you need the adapter for SQL Server 2008 or 2005, you are still in the right spot. Just install the latest 3.2.x to 4.1.x version of the adapter that matches your Rails version. We also have stable branches for each major/minor release of ActiveRecord.
 
 
 #### Executing Stored Procedures

data/RUNNING_UNIT_TESTS.md

@@ -9,11 +9,7 @@ This process is much easier than it has been before!
 Default testing uses DBLIB with TinyTDS.
 
 * Setup two databases in SQL Server, [activerecord_unittest] and [activerecord_unittest2]
-* Create a [rails] user with an empty password and give it a [db_owner] role to both DBs. Some tests require a server role of [sysadmin] too.
-  - http://twitpic.com/9bsiyp/full
-  - http://twitpic.com/9bsj7z/full
-  - http://twitpic.com/9bsjdx/full
-  - http://twitpic.com/9bsjl7/full
+* Create a [rails] user with an empty password and give it a [db_owner] role to both DBs. Some tests require a server role of [sysadmin] too. More details below with DDL SQL examples.
 * $ bundle install
 * $ bundle exec rake test ACTIVERECORD_UNITTEST_HOST='my.db.net'
 
@@ -34,6 +30,19 @@ The default names for the test databases are `activerecord_unittest` and `active
 
 The connection files make certain assumptions. For instance, the ODBC connection assumes you have a DSN setup that matches the name of the default database names. Remember too you have to set an environment variable for the DSN of the adapter, see the connection.rb file that matches your connection mode for details.
 
+```sql
+CREATE DATABASE [activerecord_unittest];
+CREATE DATABASE [activerecord_unittest2];
+GO
+CREATE LOGIN [rails] WITH PASSWORD = '', CHECK_POLICY = OFF, DEFAULT_DATABASE = [activerecord_unittest];
+GO
+USE [activerecord_unittest];
+CREATE USER [rails] FOR LOGIN [rails];
+GO
+EXEC sp_addrolemember N'db_owner', N'rails';
+EXEC master..sp_addsrvrolemember @loginame = N'rails', @rolename = N'sysadmin'
+GO
+```
 
 ## Cloning The Repos
 

data/activerecord-sqlserver-adapter.gemspec

@@ -6,11 +6,12 @@ Gem::Specification.new do |spec|
   spec.name          = 'activerecord-sqlserver-adapter'
   spec.version       = ActiveRecord::ConnectionAdapters::SQLServer::Version::VERSION
   spec.platform      = Gem::Platform::RUBY
+  spec.license       = 'MIT'
   spec.authors       = ['Ken Collins', 'Anna Carey', 'Will Bond', 'Murray Steele', 'Shawn Balestracci', 'Joe Rafaniello', 'Tom Ward']
   spec.email         = ['ken@metaskills.net', 'will@wbond.net']
   spec.homepage      = 'http://github.com/rails-sqlserver/activerecord-sqlserver-adapter'
   spec.summary       = 'ActiveRecord SQL Server Adapter.'
-  spec.description   = spec.summary
+  spec.description   = 'ActiveRecord SQL Server Adapter. SQL Server 2012 and upward.'
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
@@ -24,6 +25,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest-spec-rails'
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'nokogiri'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'byebug'
   spec.add_development_dependency 'rake'
 end

data/appveyor.yml

@@ -0,0 +1,30 @@
+version: 4.2.5.{build}
+init:
+  - SET PATH=C:\Ruby%ruby_version%\bin;%PATH%
+  - SET PATH=C:\MinGW\msys\1.0\bin;%PATH%
+  - SET RAKEOPT=-rdevkit
+clone_depth: 5
+skip_tags: true
+matrix:
+  fast_finish: true
+install:
+  - ruby --version
+  - gem --version
+  - bundle install --without odbc
+build: off
+test_script:
+  - powershell -File "%APPVEYOR_BUILD_FOLDER%\test\appveyor\dbsetup.ps1"
+  - timeout /t 4 /nobreak > NUL
+  - ps: Start-Service 'MSSQL$SQL2014'
+  - timeout /t 4 /nobreak > NUL
+  - sqlcmd -S ".\SQL2014" -U sa -P Password12! -i %APPVEYOR_BUILD_FOLDER%\test\appveyor\dbsetup.sql
+  - bundle exec rake test ACTIVERECORD_UNITTEST_DATASERVER="localhost\SQL2014"
+  - ps: Stop-Service 'MSSQL$SQL2014'
+  - ps: Start-Service 'MSSQL$SQL2012SP1'
+  - timeout /t 4 /nobreak > NUL
+  - sqlcmd -S ".\SQL2012SP1" -U sa -P Password12! -i %APPVEYOR_BUILD_FOLDER%\test\appveyor\dbsetup.sql
+  - bundle exec rake test ACTIVERECORD_UNITTEST_DATASERVER="localhost\SQL2012SP1"
+environment:
+  matrix:
+    - ruby_version: "200-x64"
+    - ruby_version: "21-x64"

data/lib/active_record/connection_adapters/sqlserver/database_statements.rb

@@ -87,6 +87,22 @@ module ActiveRecord
           Arel::Nodes::Bin.new(node)
         end
 
+        def case_sensitive_comparison(table, attribute, column, value)
+          if column.case_sensitive?
+            table[attribute].eq(value)
+          else
+            super
+          end
+        end
+
+        def case_insensitive_comparison(table, attribute, column, value)
+          if column.case_sensitive?
+            super
+          else
+            table[attribute].eq(value)
+          end
+        end
+
         # === SQLServer Specific ======================================== #
 
         def execute_procedure(proc_name, *variables)

data/lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -45,7 +45,7 @@ module ActiveRecord
         def columns(table_name, _name = nil)
           return [] if table_name.blank?
           column_definitions(table_name).map do |ci|
-            sqlserver_options = ci.slice :ordinal_position, :is_primary, :is_identity, :default_function, :table_name
+            sqlserver_options = ci.slice :ordinal_position, :is_primary, :is_identity, :default_function, :table_name, :collation
             cast_type = lookup_cast_type(ci[:type])
             new_column ci[:name], ci[:default_value], cast_type, ci[:type], ci[:null], sqlserver_options
           end
@@ -60,7 +60,7 @@ module ActiveRecord
           rename_table_indexes(table_name, new_name)
         end
 
-        def remove_column(table_name, column_name, _type = nil)
+        def remove_column(table_name, column_name, type = nil, options = {})
           raise ArgumentError.new('You must specify at least one column name.  Example: remove_column(:people, :first_name)') if column_name.is_a? Array
           remove_check_constraints(table_name, column_name)
           remove_default_constraint(table_name, column_name)
@@ -233,6 +233,7 @@ module ActiveRecord
             columns.NUMERIC_SCALE AS numeric_scale,
             columns.NUMERIC_PRECISION AS numeric_precision,
             columns.DATETIME_PRECISION AS datetime_precision,
+            columns.COLLATION_NAME AS collation,
             columns.ordinal_position,
             CASE
               WHEN columns.DATA_TYPE IN ('nchar','nvarchar','char','varchar') THEN columns.CHARACTER_MAXIMUM_LENGTH
@@ -311,6 +312,8 @@ module ActiveRecord
               when /\A\(N'(.*)'\)\Z/m
                 string_literal = SQLServer::Utils.unquote_string(Regexp.last_match[1])
                 [string_literal, nil]
+              when /CREATE DEFAULT/mi
+                [nil, nil]
               else
                 type = case ci[:type]
                        when /smallint|int|bigint/ then ci[:_type]

data/lib/active_record/connection_adapters/sqlserver/type.rb

@@ -1,6 +1,4 @@
 require 'active_record/type'
-require 'active_record/connection_adapters/sqlserver/type/core_ext/value.rb'
-require 'active_record/connection_adapters/sqlserver/type/castable.rb'
 require 'active_record/connection_adapters/sqlserver/type/quoter.rb'
 # Exact Numerics
 require 'active_record/connection_adapters/sqlserver/type/integer.rb'

data/lib/active_record/connection_adapters/sqlserver/type/boolean.rb

@@ -4,7 +4,6 @@ module ActiveRecord
       module Type
         class Boolean < ActiveRecord::Type::Boolean
 
-          include Castable
 
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/date.rb

@@ -4,8 +4,6 @@ module ActiveRecord
       module Type
         class Date < ActiveRecord::Type::Date
 
-          # When FreeTDS/TinyTDS casts this data type natively.
-          # include Castable
 
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/datetime.rb

@@ -4,8 +4,6 @@ module ActiveRecord
       module Type
         class DateTime < ActiveRecord::Type::DateTime
 
-          include Castable
-
           def type_cast_for_schema(value)
             value.acts_like?(:string) ? "'#{value}'" : super
           end

data/lib/active_record/connection_adapters/sqlserver/type/decimal.rb

@@ -4,7 +4,6 @@ module ActiveRecord
       module Type
         class Decimal < ActiveRecord::Type::Decimal
 
-          include Castable
 
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/float.rb

@@ -4,8 +4,6 @@ module ActiveRecord
       module Type
         class Float < ActiveRecord::Type::Float
 
-          include Castable
-
           def type
             :float
           end

data/lib/active_record/connection_adapters/sqlserver/type/integer.rb

@@ -4,7 +4,6 @@ module ActiveRecord
       module Type
         class Integer < ActiveRecord::Type::Integer
 
-          include Castable
 
         end
       end

data/lib/active_record/connection_adapters/sqlserver/type/real.rb

@@ -4,8 +4,6 @@ module ActiveRecord
       module Type
         class Real < Float
 
-          include Castable
-
           def type
             :real
           end

data/lib/active_record/connection_adapters/sqlserver/type/smalldatetime.rb

@@ -4,8 +4,6 @@ module ActiveRecord
       module Type
         class SmallDateTime < DateTime
 
-          include Castable
-
 
           private
 

data/lib/active_record/connection_adapters/sqlserver/type/time.rb

@@ -11,9 +11,6 @@ module ActiveRecord
             @precision = nil if @precision == 7
           end
 
-          # When FreeTDS/TinyTDS casts this data type natively.
-          # include Castable
-
           def type_cast_for_database(value)
             return if value.nil?
             Quoter.new super, self

data/lib/active_record/connection_adapters/sqlserver/version.rb

@@ -3,7 +3,7 @@ module ActiveRecord
     module SQLServer
       module Version
 
-        VERSION = '4.2.4'
+        VERSION = '4.2.5'
 
       end
     end

data/lib/active_record/connection_adapters/sqlserver_column.rb

@@ -40,6 +40,14 @@ module ActiveRecord
         @sql_type =~ /real/i
       end
 
+      def collation
+        @sqlserver_options[:collation]
+      end
+
+      def case_sensitive?
+        collation && !collation.match(/_CI/)
+      end
+
     end
   end
 end

data/test/appveyor/dbsetup.ps1

@@ -0,0 +1,27 @@
+
+Write-Output "Setting up..."
+[reflection.assembly]::LoadWithPartialName("Microsoft.SqlServer.Smo") | Out-Null
+[reflection.assembly]::LoadWithPartialName("Microsoft.SqlServer.SqlWmiManagement") | Out-Null
+
+Write-Output "Setting variables..."
+$serverName = $env:COMPUTERNAME
+$instances = @('SQL2012SP1', 'SQL2014')
+$smo = 'Microsoft.SqlServer.Management.Smo.'
+$wmi = new-object ($smo + 'Wmi.ManagedComputer')
+
+Write-Output "Configure Instances..."
+foreach ($instance in $instances) {
+  Write-Output "Instance $instance ..."
+  Write-Output "Enable TCP/IP and port 1433..."
+  $uri = "ManagedComputer[@Name='$serverName']/ServerInstance[@Name='$instance']/ServerProtocol[@Name='Tcp']"
+  $tcp = $wmi.GetSmoObject($uri)
+  $tcp.IsEnabled = $true
+  foreach ($ipAddress in $Tcp.IPAddresses) {
+    $ipAddress.IPAddressProperties["TcpDynamicPorts"].Value = ""
+    $ipAddress.IPAddressProperties["TcpPort"].Value = "1433"
+  }
+  $tcp.Alter()
+}
+
+Set-Service SQLBrowser -StartupType Manual
+Start-Service SQLBrowser

data/test/appveyor/dbsetup.sql

@@ -0,0 +1,11 @@
+CREATE DATABASE [activerecord_unittest];
+CREATE DATABASE [activerecord_unittest2];
+GO
+CREATE LOGIN [rails] WITH PASSWORD = '', CHECK_POLICY = OFF, DEFAULT_DATABASE = [activerecord_unittest];
+GO
+USE [activerecord_unittest];
+CREATE USER [rails] FOR LOGIN [rails];
+GO
+EXEC sp_addrolemember N'db_owner', N'rails';
+EXEC master..sp_addsrvrolemember @loginame = N'rails', @rolename = N'sysadmin'
+GO

data/test/cases/coerced_tests.rb

@@ -1,6 +1,24 @@
 require 'cases/helper_sqlserver'
 
 
+# Windows/Appveyor
+if RbConfig::CONFIG['host_os'] =~ /mswin|mingw/
+  # All of these are due to Time.local(2000).zone. See http://git.io/v3t0o
+  class BelongsToAssociationsTest < ActiveRecord::TestCase
+    coerce_tests! :test_belongs_to_with_touch_option_on_touch_without_updated_at_attributes
+  end
+  class BasicsTest < ActiveRecord::TestCase
+    coerce_tests! :test_preserving_time_objects_with_local_time_conversion_to_default_timezone_utc
+    coerce_tests! :test_preserving_time_objects_with_time_with_zone_conversion_to_default_timezone_local
+    coerce_tests! :test_preserving_time_objects_with_utc_time_conversion_to_default_timezone_local
+  end
+  class DirtyTest < ActiveRecord::TestCase
+    coerce_tests! :test_save_always_should_update_timestamps_when_serialized_attributes_are_present
+    coerce_tests! :test_previous_changes # Coupled to above test.
+  end
+end
+
+
 module ActiveRecord
   class AdapterTest < ActiveRecord::TestCase
 
@@ -46,15 +64,19 @@ class BasicsTest < ActiveRecord::TestCase
     assert_equal "[foo'bar]", quoted
   end
 
-  # This test has a few problems. First, it would require that we use
-  # the `Type::SQLServer::BigInteger.new(limit: 8)` for the `world_population`
-  # attribute. Second, since we allow the DB to win at casting for TinyTDS,
-  # it always comes back as a BigDecimal.
+  # PENDING: [Rails5.x] Remove coerced tests and use simple symbol types..
+  # This test has a few problems. First, it would require that we use the
+  # `Type::SQLServer::BigInteger.new(limit: 8)` for the `world_population` attribute.
   coerce_tests! :test_numeric_fields
+  coerce_tests! :test_numeric_fields_with_scale
 
   # Just like PostgreSQLAdapter does.
   coerce_tests! :test_respect_internal_encoding
 
+  # Caused in Rails v4.2.5 by adding `firm_id` column in this http://git.io/vBfMs
+  # commit. Trust Rails has this covered.
+  coerce_tests! :test_find_keeps_multiple_group_values
+
 end
 
 
@@ -388,41 +410,8 @@ class BigNumber < ActiveRecord::Base
 end
 class MigrationTest < ActiveRecord::TestCase
 
+  # PENDING: [Rails5.x] Remove coerced tests and use simple symbol types.
   coerce_tests! :test_add_table_with_decimals
-  def test_add_table_with_decimals_coerced
-    Person.connection.drop_table :big_numbers rescue nil
-    assert !BigNumber.table_exists?
-    GiveMeBigNumbers.up
-    assert BigNumber.create(
-      :bank_balance => 1586.43,
-      :big_bank_balance => BigDecimal("1000234000567.95"),
-      :world_population => 6000000000,
-      :my_house_population => 3,
-      :value_of_e => BigDecimal("2.7182818284590452353602875")
-    )
-    b = BigNumber.first
-    assert_not_nil b
-    assert_not_nil b.bank_balance
-    assert_not_nil b.big_bank_balance
-    assert_not_nil b.world_population
-    assert_not_nil b.my_house_population
-    assert_not_nil b.value_of_e
-    # SQLServer: We rock and cast during assignment.
-    assert_kind_of BigDecimal, b.world_population
-    assert_equal BigDecimal('6000000000'), b.world_population
-    # TODO: Our trust the DB policy breaks this expectation. Review SQLServer::Type::Castable module.
-    skip
-    assert_kind_of Fixnum, b.my_house_population
-    assert_equal 3, b.my_house_population
-    assert_kind_of BigDecimal, b.bank_balance
-    assert_equal BigDecimal("1586.43"), b.bank_balance
-    assert_kind_of BigDecimal, b.big_bank_balance
-    assert_equal BigDecimal("1000234000567.95"), b.big_bank_balance
-    assert_kind_of BigDecimal, b.value_of_e
-    assert_equal BigDecimal("2.7182818284590452353602875"), b.value_of_e
-    GiveMeBigNumbers.down
-    assert_raise(ActiveRecord::StatementInvalid) { BigNumber.first }
-  end
 
 end
 
@@ -609,6 +598,9 @@ class SchemaDumperTest < ActiveRecord::TestCase
   # This accidently returns the wrong number because of our tables too.
   coerce_tests! :test_types_line_up
 
+  # This is a poorly written test and really does not catch the bottom'ness it is meant too. Ours throw it off.
+  coerce_tests! :test_foreign_keys_are_dumped_at_the_bottom_to_circumvent_dependency_issues
+
 end
 
 

data/test/cases/column_test_sqlserver.rb

@@ -134,7 +134,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         9
       type.scale.must_equal             2
       obj.decimal_9_2 = '1234567.8901'
-      obj.decimal_9_2.must_equal        BigDecimal('1234567.8901') # Cast from user one day.
+      obj.decimal_9_2.must_equal        BigDecimal('1234567.89')
       obj.save!
       obj.reload.decimal_9_2.must_equal BigDecimal('1234567.89')
     end
@@ -149,7 +149,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         16
       type.scale.must_equal             4
       obj.decimal_16_4 = '1234567.8901001'
-      obj.decimal_16_4.must_equal        BigDecimal('1234567.8901001') # Cast from user one day.
+      obj.decimal_16_4.must_equal        BigDecimal('1234567.8901')
       obj.save!
       obj.reload.decimal_16_4.must_equal BigDecimal('1234567.8901')
     end
@@ -169,7 +169,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         18
       type.scale.must_equal             0
       obj.numeric_18_0 = '192.1'
-      obj.numeric_18_0.must_equal        BigDecimal('192.1') # Cast from user one day.
+      obj.numeric_18_0.must_equal        BigDecimal('192')
       obj.save!
       obj.reload.numeric_18_0.must_equal BigDecimal('192')
     end
@@ -189,7 +189,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         36
       type.scale.must_equal             2
       obj.numeric_36_2 = '192.123'
-      obj.numeric_36_2.must_equal        BigDecimal('192.123') # Cast from user one day.
+      obj.numeric_36_2.must_equal        BigDecimal('192.12')
       obj.save!
       obj.reload.numeric_36_2.must_equal BigDecimal('192.12')
     end
@@ -209,7 +209,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         19
       type.scale.must_equal             4
       obj.money = '922337203685477.58061'
-      obj.money.must_equal              BigDecimal('922337203685477.58061')
+      obj.money.must_equal              BigDecimal('922337203685477.5806')
       obj.save!
       obj.reload.money.must_equal       BigDecimal('922337203685477.5806')
     end
@@ -229,7 +229,7 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       type.precision.must_equal         10
       type.scale.must_equal             4
       obj.smallmoney = '214748.36461'
-      obj.smallmoney.must_equal        BigDecimal('214748.36461')
+      obj.smallmoney.must_equal        BigDecimal('214748.3646')
       obj.save!
       obj.reload.smallmoney.must_equal BigDecimal('214748.3646')
     end

data/test/cases/helper_sqlserver.rb

@@ -20,14 +20,13 @@ module ActiveRecord
       def connection_mode_dblib? ; ActiveRecord::Base.connection.instance_variable_get(:@connection_options)[:mode] == :dblib ; end
       def connection_mode_odbc? ; ActiveRecord::Base.connection.instance_variable_get(:@connection_options)[:mode] == :odbc ; end
       def sqlserver_azure? ; ActiveRecord::Base.connection.sqlserver_azure? ; end
+      def host_windows? ; RbConfig::CONFIG['host_os'] =~ /mswin|mingw/ ; end
     end
 
-
-    private
-
     def connection_mode_dblib? ; self.class.connection_mode_dblib? ; end
     def connection_mode_odbc? ; self.class.connection_mode_odbc? ; end
     def sqlserver_azure? ; self.class.sqlserver_azure? ; end
+    def host_windows? ; self.class.host_windows? ; end
 
     def connection
       ActiveRecord::Base.connection

data/test/cases/rake_test_sqlserver.rb

@@ -120,6 +120,8 @@ class SQLServerRakeStructureDumpLoadTest < SQLServerRakeTest
   end
 
   it 'dumps structure and accounts for defncopy oddities' do
+    # CHANGED: [TinyTDS] When utilities are available http://git.io/v3tBk
+    skip if host_windows?
     db_tasks.structure_dump configuration, filename
     filedata.wont_match %r{\AUSE.*\z}
     filedata.wont_match %r{\AGO.*\z}
@@ -129,6 +131,8 @@ class SQLServerRakeStructureDumpLoadTest < SQLServerRakeTest
   end
 
   it 'can load dumped structure' do
+    # CHANGED: [TinyTDS] When utilities are available http://git.io/v3tBk
+    skip if host_windows?
     db_tasks.structure_dump configuration, filename
     filedata.must_match %r{CREATE TABLE dbo\.users}
     db_tasks.purge(configuration)

data/test/cases/schema_dumper_test_sqlserver.rb

@@ -100,12 +100,12 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     assert_line :binary_basic_col,  type: 'binary_basic', limit: '1',           precision: nil,   scale: nil,  default: nil
     assert_line :varbinary_col,     type: 'varbinary',    limit: '8000',        precision: nil,   scale: nil,  default: nil
     assert_line :uuid_col,          type: 'uuid',         limit: nil,           precision: nil,   scale: nil,  default: nil
-    assert_line :sstimestamp_col, type: 'ss_timestamp', limit: nil,          precision: nil,  scale: nil, default: nil
+    assert_line :sstimestamp_col,   type: 'ss_timestamp', limit: nil,           precision: nil,   scale: nil,  default: nil
   end
 
   # Special Cases
 
-  it 'primary_key' do
+  it 'honor nonstandard primary keys' do
     generate_schema_for_table('movies') do |output|
       match = output.match(%r{create_table "movies"(.*)do})
       assert_not_nil(match, "nonstandardpk table not found")
@@ -113,6 +113,12 @@ class SchemaDumperTestSQLServer < ActiveRecord::TestCase
     end
   end
 
+  it 'no id with model driven primary key' do
+    output = generate_schema_for_table 'sst_no_pk_data'
+    output.must_match %r{create_table "sst_no_pk_data".*id:\sfalse.*do}
+    assert_line :name, type: 'string', limit: '4000'
+  end
+
 
   private
 

data/test/cases/specific_schema_test_sqlserver.rb

@@ -62,6 +62,12 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
     assert_equal '(NULL)', default.string_with_pretend_null_four
   end
 
+  it 'default objects work' do
+    obj = SSTestObjectDefault.create! name: 'MetaSkills'
+    obj.date.must_be_nil 'since this is set on insert'
+    obj.reload.date.must_be_instance_of Date
+  end
+
   # Natural primary keys.
 
   it 'work with identity inserts' do

data/test/config.yml

@@ -8,7 +8,6 @@ default_connection_info: &default_connection_info
   database: activerecord_unittest
   username: <%= ENV['ACTIVERECORD_UNITTEST_USER'] || 'rails' %>
   password: <%= ENV['ACTIVERECORD_UNITTEST_PASS'] || '' %>
-  azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
   collation: <%= ENV['ACTIVERECORD_UNITTEST_COLLATION'] || nil %>
   encoding: utf8
 
@@ -19,11 +18,15 @@ connections:
       <<: *default_connection_info
       appname: SQLServerAdptrUnit
       dataserver: <%= ENV['ACTIVERECORD_UNITTEST_DATASERVER'] %>
+      tds_version: <%= ENV['ACTIVERECORD_UNITTEST_TDSVERSION'] %>
+      azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
     arunit2:
       <<: *default_connection_info
       database: activerecord_unittest2
       appname: SQLServerAdptrUnit2
       dataserver: <%= ENV['ACTIVERECORD_UNITTEST_DATASERVER'] %>
+      tds_version: <%= ENV['ACTIVERECORD_UNITTEST_TDSVERSION'] %>
+      azure: <%= !ENV['ACTIVERECORD_UNITTEST_AZURE'].nil? %>
 
   odbc:
     arunit:

data/test/models/sqlserver/object_default.rb

@@ -0,0 +1,3 @@
+class SSTestObjectDefault < ActiveRecord::Base
+  self.table_name = 'sst_defaultobjects'
+end

data/test/schema/sqlserver_specific_schema.rb

@@ -109,6 +109,14 @@ ActiveRecord::Schema.define do
     )
   TINYITPKTABLE
 
+  execute "DROP DEFAULT [sst_getdateobject];" rescue nil
+  execute "CREATE DEFAULT [sst_getdateobject] AS getdate();" rescue nil
+  create_table 'sst_defaultobjects', force: true do |t|
+    t.string :name
+    t.date   :date
+  end
+  execute "sp_bindefault 'sst_getdateobject', 'sst_defaultobjects.date'"
+
   # Constraints
 
   create_table(:sst_has_fks, force: true) { |t| t.column(:fk_id, :integer, null: false) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 4.2.4
+  version: 4.2.5
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-20 00:00:00.000000000 Z
+date: 2015-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -143,7 +143,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -170,7 +170,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ActiveRecord SQL Server Adapter.
+description: ActiveRecord SQL Server Adapter. SQL Server 2012 and upward.
 email:
 - ken@metaskills.net
 - will@wbond.net
@@ -180,6 +180,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
 - MIT-LICENSE
@@ -187,6 +188,7 @@ files:
 - RUNNING_UNIT_TESTS.md
 - Rakefile
 - activerecord-sqlserver-adapter.gemspec
+- appveyor.yml
 - lib/active_record/connection_adapters/sqlserver/core_ext/active_record.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb
 - lib/active_record/connection_adapters/sqlserver/core_ext/explain.rb
@@ -209,9 +211,7 @@ files:
 - lib/active_record/connection_adapters/sqlserver/type/big_integer.rb
 - lib/active_record/connection_adapters/sqlserver/type/binary.rb
 - lib/active_record/connection_adapters/sqlserver/type/boolean.rb
-- lib/active_record/connection_adapters/sqlserver/type/castable.rb
 - lib/active_record/connection_adapters/sqlserver/type/char.rb
-- lib/active_record/connection_adapters/sqlserver/type/core_ext/value.rb
 - lib/active_record/connection_adapters/sqlserver/type/date.rb
 - lib/active_record/connection_adapters/sqlserver/type/datetime.rb
 - lib/active_record/connection_adapters/sqlserver/type/decimal.rb
@@ -247,6 +247,8 @@ files:
 - lib/activerecord-sqlserver-adapter.rb
 - lib/arel/visitors/sqlserver.rb
 - lib/arel_sqlserver.rb
+- test/appveyor/dbsetup.ps1
+- test/appveyor/dbsetup.sql
 - test/cases/adapter_test_sqlserver.rb
 - test/cases/coerced_tests.rb
 - test/cases/column_test_sqlserver.rb
@@ -280,6 +282,7 @@ files:
 - test/models/sqlserver/natural_pk_data.rb
 - test/models/sqlserver/natural_pk_int_data.rb
 - test/models/sqlserver/no_pk_data.rb
+- test/models/sqlserver/object_default.rb
 - test/models/sqlserver/quoted_table.rb
 - test/models/sqlserver/quoted_view_1.rb
 - test/models/sqlserver/quoted_view_2.rb
@@ -299,7 +302,8 @@ files:
 - test/support/rake_helpers.rb
 - test/support/sql_counter_sqlserver.rb
 homepage: http://github.com/rails-sqlserver/activerecord-sqlserver-adapter
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -317,11 +321,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: ActiveRecord SQL Server Adapter.
 test_files:
+- test/appveyor/dbsetup.ps1
+- test/appveyor/dbsetup.sql
 - test/cases/adapter_test_sqlserver.rb
 - test/cases/coerced_tests.rb
 - test/cases/column_test_sqlserver.rb
@@ -355,6 +361,7 @@ test_files:
 - test/models/sqlserver/natural_pk_data.rb
 - test/models/sqlserver/natural_pk_int_data.rb
 - test/models/sqlserver/no_pk_data.rb
+- test/models/sqlserver/object_default.rb
 - test/models/sqlserver/quoted_table.rb
 - test/models/sqlserver/quoted_view_1.rb
 - test/models/sqlserver/quoted_view_2.rb

data/lib/active_record/connection_adapters/sqlserver/type/castable.rb

@@ -1,15 +0,0 @@
-module ActiveRecord
-  module ConnectionAdapters
-    module SQLServer
-      module Type
-        module Castable
-
-          def type_cast_from_database(value)
-            type_cast_from_ss_database? ? super : value
-          end
-
-        end
-      end
-    end
-  end
-end

data/lib/active_record/connection_adapters/sqlserver/type/core_ext/value.rb

@@ -1,39 +0,0 @@
-module ActiveRecord
-  module Type
-    class Value
-
-      module SQLServerBehavior
-
-        extend ActiveSupport::Concern
-
-        included do
-          self.type_cast_from_ss_database = false
-        end
-
-        module ClassMethods
-
-          def type_cast_from_ss_database
-            @@type_cast_from_ss_database
-          end
-
-          def type_cast_from_ss_database=(boolean)
-            @@type_cast_from_ss_database = !!boolean
-          end
-
-        end
-
-        def type_cast_from_ss_database?
-          self.class.type_cast_from_ss_database
-        end
-
-        def type_cast_from_database(value)
-          type_cast_from_ss_database? ? super : value
-        end
-
-      end
-
-      include SQLServerBehavior
-
-    end
-  end
-end