activerecord-sqlserver-adapter 4.2.9 → 4.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f5d6ca15cc209e9b813902b9858da21c7e7c884
-  data.tar.gz: 6bd880c3daa536eee4df06414864df65cd8745c4
+  metadata.gz: b3f5cb06eb492b1fce0526281946dea07336bec9
+  data.tar.gz: 1b4d4a21a4a4ed6858572daac58016d8d5672d35
 SHA512:
-  metadata.gz: 5245acb11cbaa31099871f12c5a9387776dc5def556bbdcfecc25eebc3a1b167a29ebb14b6aa1cd58ad8fa52241bd58ef0f784aa29167a68a3c4c3d1f55aa9d2
-  data.tar.gz: 514c6fa8bc3c4e7d16df6db884c5705aa6932b5de7b3fd857cfb2346409efe004a117fc8c51de90a4d67ac26c1bca4c1c4753ce25c5913edf17651646809417f
+  metadata.gz: ae62612e1fe093da674fa74d67ee2e85a516795871fb6fa5fc281fadd2c09a5a0378a7a202caf592d6ab4babaa08545e218fe18a46a9e195805e8cf69195746b
+  data.tar.gz: 398a1381b3f0157bec451e29c45c57f4ade59291e10f3c17e95591bcf9471f743a2e96852c7509f946cd7237edf4b5ffcbfdd68b044165cf57d55f63daf602b9

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## v4.2.10
+
+#### Fixed
+
+* Ensure small datetime/datetime2 fractionals are properly quoted. Fixes #457.
+
+
 ## v4.2.9
 
 #### Fixed

data/VERSION

@@ -1 +1 @@
-4.2.9
+4.2.10

data/lib/active_record/connection_adapters/sqlserver/type/time_value_fractional.rb

@@ -17,7 +17,7 @@ module ActiveRecord
 
           def quote_fractional(value)
             seconds = (value.send(fractional_property).to_f / fractional_operator.to_f).round(fractional_scale)
-            seconds.to_s.split('.').last.to(fractional_scale-1)
+            seconds.to_d.to_s.split('.').last.to(fractional_scale-1)
           end
 
           def fractional_property

data/test/cases/column_test_sqlserver.rb

@@ -354,6 +354,11 @@ class ColumnTestSQLServer < ActiveRecord::TestCase
       obj.datetime2_7.must_equal           Time.utc(9999, 12, 31, 23, 59, 59, Rational(123456800, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <123456800>"
       obj.save!
       obj.reload.datetime2_7.must_equal    Time.utc(9999, 12, 31, 23, 59, 59, Rational(123456800, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <123456800>"
+      # Can save small fraction nanosecond precisoins and return again.
+      obj.datetime2_7 = Time.utc(2008, 6, 21, 13, 30, 0, Rational(15020, 1000))
+      obj.datetime2_7.must_equal           Time.utc(2008, 6, 21, 13, 30, 0, Rational(15000, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <15000>"
+      obj.save!
+      obj.reload.datetime2_7.must_equal    Time.utc(2008, 6, 21, 13, 30, 0, Rational(15000, 1000)), "Nanoseconds were <#{obj.datetime2_7.nsec}> vs <15000>"
       # With other precisions.
       time = Time.utc 9999, 12, 31, 23, 59, 59, Rational(123456789, 1000)
       col = column('datetime2_3')

data/test/cases/execute_procedure_test_sqlserver.rb

@@ -38,7 +38,7 @@ class ExecuteProcedureTestSQLServer < ActiveRecord::TestCase
   it 'uses the proper timezone' do
     date_proc = connection.execute_procedure('my_getutcdate').first['utcdate']
     date_base = connection.select_value('select GETUTCDATE()')
-    assert_equal date_base, date_proc
+    assert_equal date_base.change(usec: 0), date_proc.change(usec: 0)
   end
 
 end

data/test/cases/specific_schema_test_sqlserver.rb

@@ -68,6 +68,15 @@ class SpecificSchemaTestSQLServer < ActiveRecord::TestCase
     obj.reload.date.must_be_instance_of Date
   end
 
+  it 'allows datetime2 as timestamps' do
+    SSTestBooking.columns_hash['created_at'].sql_type.must_equal 'datetime2(7)'
+    SSTestBooking.columns_hash['updated_at'].sql_type.must_equal 'datetime2(7)'
+    obj1 = SSTestBooking.new name: 'test1'
+    obj1.save!
+    obj1.created_at.must_be_instance_of Time
+    obj1.updated_at.must_be_instance_of Time
+  end
+
   # Natural primary keys.
 
   it 'work with identity inserts' do

data/test/models/sqlserver/booking.rb

@@ -0,0 +1,3 @@
+class SSTestBooking < ActiveRecord::Base
+  self.table_name = 'sst_bookings'
+end

data/test/schema/sqlserver_specific_schema.rb

@@ -37,6 +37,12 @@ ActiveRecord::Schema.define do
 
   # Edge Cases
 
+  create_table 'sst_bookings', force: true do |t|
+    t.string :name
+    t.datetime2 :created_at, null: false
+    t.datetime2 :updated_at, null: false
+  end
+
   create_table 'sst_uuids', force: true, id: :uuid do |t|
     t.string :name
     t.uuid   :other_uuid, default: 'NEWID()'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version
-  version: 4.2.9
+  version: 4.2.10
 platform: ruby
 authors:
 - Ken Collins
@@ -14,7 +14,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-15 00:00:00.000000000 Z
+date: 2016-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -136,6 +136,7 @@ files:
 - test/debug.rb
 - test/fixtures/1px.gif
 - test/migrations/transaction_table/1_table_will_never_be_created.rb
+- test/models/sqlserver/booking.rb
 - test/models/sqlserver/customers_view.rb
 - test/models/sqlserver/datatype.rb
 - test/models/sqlserver/datatype_migration.rb
@@ -218,6 +219,7 @@ test_files:
 - test/debug.rb
 - test/fixtures/1px.gif
 - test/migrations/transaction_table/1_table_will_never_be_created.rb
+- test/models/sqlserver/booking.rb
 - test/models/sqlserver/customers_view.rb
 - test/models/sqlserver/datatype.rb
 - test/models/sqlserver/datatype_migration.rb