activerecord-sqlserver-adapter 2.3.17 → 2.3.18

data/CHANGELOG

@@ -1,4 +1,11 @@
 
+* 2.3.18 *
+
+* Warn of possible permission problems if "EXEC sp_helptext..." does not work view. Fixes #73.
+
+* Fix returning of auto-increment identity for TinyTDS driver. [Gregory McIntyre / puyo]
+
+
 * 2.3.17 *
 
 * Allow TinyTDS/DBLIB mode to pass down :host/:port config options.

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -147,7 +147,7 @@ module ActiveRecord
     class SQLServerAdapter < AbstractAdapter
       
       ADAPTER_NAME                = 'SQLServer'.freeze
-      VERSION                     = '2.3.17'.freeze
+      VERSION                     = '2.3.18'.freeze
       DATABASE_VERSION_REGEXP     = /Microsoft SQL Server\s+(\d{4})/
       SUPPORTED_VERSIONS          = [2000,2005,2008].freeze
       LIMITABLE_TYPES             = ['string','integer','float','char','nchar','varchar','nvarchar'].to_set.freeze
@@ -588,7 +588,13 @@ module ActiveRecord
           if view_info
             view_info = view_info.with_indifferent_access
             if view_info[:VIEW_DEFINITION].blank? || view_info[:VIEW_DEFINITION].length == 4000
-              view_info[:VIEW_DEFINITION] = info_schema_query { select_values("EXEC sp_helptext #{quote_table_name(table_name)}").join }
+              view_info[:VIEW_DEFINITION] = info_schema_query do
+                                              begin
+                                                select_values("EXEC sp_helptext #{quote_table_name(table_name)}").join
+                                              rescue
+                                                warn "No view definition found, possible permissions problem.\nPlease run GRANT VIEW DEFINITION TO your_user;"
+                                              end
+                                            end
             end
           end
           view_info
@@ -921,9 +927,6 @@ module ActiveRecord
         else :adonet
           @connection.create_command.tap{ |cmd| cmd.command_text = sql }.execute_non_query
         end
-      ensure
-        @insert_sql = false
-        @update_sql = false
       end
       
       def finish_statement_handle(handle)
@@ -952,6 +955,8 @@ module ActiveRecord
         else
           super || select_value("SELECT CAST(SCOPE_IDENTITY() AS bigint) AS Ident")
         end
+      ensure
+        @insert_sql = false
       end
       
       def update_sql(sql, name = nil)
@@ -963,6 +968,8 @@ module ActiveRecord
           execute(sql, name)
           select_value('SELECT @@ROWCOUNT AS AffectedRows')
         end
+      ensure
+        @update_sql = false
       end
       
       def info_schema_query

data/test/cases/adapter_test_sqlserver.rb

@@ -351,6 +351,12 @@ class AdapterTestSqlserver < ActiveRecord::TestCase
       assert_nil @connection.send(:identity_column,Subscriber.table_name)
     end
     
+    should 'return retreive auto incremented id column' do
+      joke = Joke.new
+      joke.id = 999
+      joke.save
+      assert_equal 999, joke.id
+    end
   end
   
   context 'For Quoting' do

metadata

@@ -1,15 +1,10 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: activerecord-sqlserver-adapter
-version: !ruby/object:Gem::Version 
-  hash: 33
+version: !ruby/object:Gem::Version
+  version: 2.3.18
   prerelease: 
-  segments: 
-  - 2
-  - 3
-  - 17
-  version: 2.3.17
 platform: ruby
-authors: 
+authors:
 - Ken Collins
 - Murray Steele
 - Shawn Balestracci
@@ -18,34 +13,27 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-04-15 00:00:00 -04:00
+date: 2011-04-27 00:00:00.000000000 -04:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+dependencies:
+- !ruby/object:Gem::Dependency
   name: activerecord
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &2171186220 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 2
-        - 2
-        version: "2.2"
+      - !ruby/object:Gem::Version
+        version: '2.2'
   type: :runtime
-  version_requirements: *id001
+  prerelease: false
+  version_requirements: *2171186220
 description: SQL Server 2000, 2005 and 2008 Adapter For Rails.
 email: ken@metaskills.net
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - README.rdoc
-files: 
+files:
 - CHANGELOG
 - MIT-LICENSE
 - Rakefile
@@ -85,41 +73,33 @@ files:
 has_rdoc: true
 homepage: http://github.com/rails-sqlserver
 licenses: []
-
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --line-numbers
 - --inline-source
 - --main
 - README.rdoc
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
 rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: SQL Server 2000, 2005 and 2008 Adapter For Rails.
-test_files: 
+test_files:
 - test/cases/aaaa_create_tables_test_sqlserver.rb
 - test/cases/adapter_test_sqlserver.rb
 - test/cases/attribute_methods_test_sqlserver.rb