activerecord-sqlserver-adapter 2.3 → 2.3.1

data/README.rdoc

@@ -140,7 +140,8 @@ Optionally configure your gem dependencies in your rails environment.rb file.
 
   config.gem 'dbi', :version => '0.4.1'
   config.gem 'dbd-odbc', :version => '0.2.4', :lib => 'dbd/ODBC'
-  config.gem 'activerecord-sqlserver-adapter',    :version => 'x.x.xx'
+  config.gem 'activerecord-sqlserver-adapter', :version => 'x.x.xx', 
+                                               :lib => 'active_record/connection_adapters/sqlserver_adapter'
 
 Here are some external links for libraries and/or tutorials on how to install any other additional components to use this adapter. If you know of a good one that we can include here, just let us know.
 

data/lib/activerecord-sqlserver-adapter.rb

@@ -0,0 +1 @@
+require 'active_record/connection_adapters/sqlserver_adapter'

data/test/cases/adapter_test_sqlserver.rb

@@ -30,7 +30,7 @@ class AdapterTestSqlserver < ActiveRecord::TestCase
     end
     
     should 'include version in inspect' do
-      assert_match(/version\: \d.\d.\d/,@connection.inspect)
+      assert_match(/version\: \d.\d/,@connection.inspect)
     end
     
     should 'support migrations' do

data/test/cases/validations_test_sqlserver.rb

@@ -9,13 +9,24 @@ class ValidationsTest < ActiveRecord::TestCase
   
   include SqlserverCoercedTest
   
-  # Because SQL Server converts UTF8 data to some other data type, there is no such thing as a 
-  # one to byte length check. See this article for details:
-  # http://connect.microsoft.com/SQLServer/feedback/ViewFeedback.aspx?FeedbackID=362867
+  # This test is tricky to pass. The validation SQL would generate something like this:
+  # 
+  #   SELECT TOP 1 [events].id FROM [events] WHERE ([events].[title] COLLATE Latin1_General_CS_AS = '一二三四五')
+  # 
+  # The problem is that we can not change the adapters quote method from this:
+  # 
+  #   elsif column && column.respond_to?(:is_utf8?) && column.is_utf8?
+  #     quoted_utf8_value(value)
+  # 
+  # To something like this for all quoting like blind bind vars:
+  # 
+  #   elsif value.is_utf8?
+  #     quoted_utf8_value(value)
+  # 
+  # As it would cause way more errors, sure this piggybacks on ActiveSupport's 1.8/1.9 abstract
+  # code to infer if the passed in string is indeed a national/unicde type. Perhaps in rails 3
+  # and using AREL this might get better, but I do not see a solution right now.
   # 
-  # Had the idea of doing this, but could not since the above was true.
-  # Event.connection.change_column :events, :title, :nvarchar, :limit => 5
-  # Event.reset_column_information
   def test_coerced_test_validate_uniqueness_with_limit_and_utf8
     assert true
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version 
-  version: "2.3"
+  version: 2.3.1
 platform: ruby
 authors: 
 - Ken Collins
@@ -34,6 +34,7 @@ files:
 - autotest/discover.rb
 - autotest/railssqlserver.rb
 - autotest/sqlserver.rb
+- lib/activerecord-sqlserver-adapter.rb
 - lib/active_record/connection_adapters/sqlserver_adapter.rb
 - lib/active_record/connection_adapters/sqlserver_adapter/core_ext/active_record.rb
 - lib/active_record/connection_adapters/sqlserver_adapter/core_ext/dbi.rb