activerecord-sqlserver-adapter 2.2.21 → 2.2.22

data/CHANGELOG

@@ -1,7 +1,14 @@
 
 MASTER
 
-* 
+
+
+* 2.2.22 * (October 15th, 2009)
+
+* Support Identity-key-column judgement on multiple schema environment [Ken Tachiya]
+
+* Add support for tinyint data types. In MySQL all these types would be boolean, however in 
+  our adapter, they will use the full 1 => 255 Fixnum value as you would expect. [Ken Collins]
 
 
 * 2.2.21 * (September 10th, 2009)

data/README.rdoc

@@ -130,7 +130,7 @@ It is our goal to match the adapter version with each version of rails. However
 
 First, you will need Ruby DBI and Ruby ODBC. If you are using the adapter under 1.9, then you need at least ruby-odbc version 0.9996. To my knowledge the ADO DBD for DBI is no longer supported. The installation below is not a comprehensive walk thru on how to get all the required moving parts like FreeTDS installed and/or configured. It will also assume gem installations of both the dependent libraries and the adapter itself.
 
-It should be noted that this version of the adapter was developed using both the ancient 0.0.23 version of DBI up to the current stable release of 0.4.1. Note that DBI 0.4.1 is the minimal for ruby 1.9 compatibility. Because later versions of DBI will be changing many things, IT IS HIGHLY RECOMMENDED that you max your install to version 0.4.1 which the examples below show. For the time being we are not supporting DBI versions higher than 0.4.1. The good news is that if you were using a very old DBI with ADO, technically this adapter will still work for you, but be warned your path is getting old and may not be supported for long.
+It should be noted that this version of the adapter was developed using both the ancient 0.0.23 version of DBI up to the current stable release of 0.4.1. Note that DBI 0.4.1 is the minimal for ruby 1.9 compatibility. Because later versions of DBI will be changing many things, IT IS HIGHLY NECESSARY that you max your install to version 0.4.1 which the examples below show. For the time being we are not supporting DBI versions higher than 0.4.1 this they settle down on new internal implementations.
 
   $ gem install dbi --version 0.4.1
   $ gem install dbd-odbc --version 0.2.4

data/Rakefile

@@ -3,7 +3,7 @@ require 'rake'
 require 'rake/testtask'
 require 'echoe'
 
-Echoe.new('activerecord-sqlserver-adapter','2.2.21') do |p|
+Echoe.new('activerecord-sqlserver-adapter','2.2.22') do |p|
   p.summary               = "SQL Server 2000, 2005 and 2008 Adapter For Rails."
   p.description           = "SQL Server 2000, 2005 and 2008 Adapter For Rails."
   p.author                = ["Ken Collins","Murray Steele","Shawn Balestracci","Joe Rafaniello","Tom Ward"]

data/lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -183,7 +183,7 @@ module ActiveRecord
     class SQLServerAdapter < AbstractAdapter
       
       ADAPTER_NAME            = 'SQLServer'.freeze
-      VERSION                 = '2.2.21'.freeze
+      VERSION                 = '2.2.22'.freeze
       DATABASE_VERSION_REGEXP = /Microsoft SQL Server\s+(\d{4})/
       SUPPORTED_VERSIONS      = [2000,2005,2008].freeze
       LIMITABLE_TYPES         = ['string','integer','float','char','nchar','varchar','nvarchar'].freeze
@@ -1052,7 +1052,7 @@ module ActiveRecord
             ELSE NULL
           end as is_nullable,
           CASE
-            WHEN COLUMNPROPERTY(OBJECT_ID(columns.TABLE_NAME), columns.COLUMN_NAME, 'IsIdentity') = 0 THEN NULL
+            WHEN COLUMNPROPERTY(OBJECT_ID(columns.TABLE_SCHEMA+'.'+columns.TABLE_NAME), columns.COLUMN_NAME, 'IsIdentity') = 0 THEN NULL
             ELSE 1
           END as is_identity
           FROM #{db_name}INFORMATION_SCHEMA.COLUMNS columns

data/lib/active_record/connection_adapters/sqlserver_adapter/core_ext/dbi.rb

@@ -46,6 +46,14 @@ module ActiveRecord
               obj.to_s
             end
           end
+          
+          # We want our true 1 to 255 tinyint range.
+          class SqlserverForcedTinyint
+            def self.parse(obj)
+              return nil if ::DBI::Type::Null.parse(obj).nil?
+              obj.to_i
+            end
+          end
 
         end
 
@@ -68,6 +76,8 @@ module ActiveRecord
                 DBI::Type::SqlserverTimestamp
               when /^float|decimal|money$/i
                 DBI::Type::SqlserverForcedString
+              when /^tinyint$/i
+                DBI::Type::SqlserverForcedTinyint
               else
                 type_name_to_module_without_sqlserver_types(type_name)
               end

data/test/cases/column_test_sqlserver.rb

@@ -1,6 +1,8 @@
 require 'cases/sqlserver_helper'
 require 'models/binary'
 
+class SqlServerEdgeSchema < ActiveRecord::Base; end;
+
 class ColumnTestSqlserver < ActiveRecord::TestCase
   
   def setup
@@ -260,5 +262,19 @@ class ColumnTestSqlserver < ActiveRecord::TestCase
     
   end
   
+  context 'For tinyint columns' do
+
+    setup do
+      @tinyint = SqlServerEdgeSchema.columns_hash['tinyint']
+    end
+
+    should 'be all it should be' do
+      assert_equal :integer, @tinyint.type
+      assert_nil @tinyint.scale
+      assert_equal 'tinyint(1)', @tinyint.sql_type
+    end
+
+  end
+  
   
 end

data/test/cases/specific_schema_test_sqlserver.rb

@@ -68,6 +68,24 @@ class SpecificSchemaTestSqlserver < ActiveRecord::TestCase
 
     end
     
+    context 'with tinyint column' do
+
+      setup do
+        @tiny1 = @edge_class.create! :tinyint => 1
+        @tiny255 = @edge_class.create! :tinyint => 255
+      end
+
+      should 'not treat tinyint like boolean as mysql does' do
+        assert_equal 1, @edge_class.find_by_tinyint(1).tinyint
+        assert_equal 255, @edge_class.find_by_tinyint(255).tinyint
+      end
+      
+      should 'throw an error when going out of our tiny int bounds' do
+        assert_raise(ActiveRecord::StatementInvalid) { @edge_class.create! :tinyint => 256 }
+      end
+      
+    end
+    
   end
   
   

data/test/cases/table_name_test_sqlserver.rb

@@ -1,6 +1,10 @@
 require 'cases/sqlserver_helper'
 require 'models/order'
 
+class SqlServerRailsOrders < ActiveRecord::Base
+  set_table_name 'rails.orders'
+end
+
 class TableNameTestSqlserver < ActiveRecord::TestCase
   
   self.use_transactional_fixtures = false
@@ -18,5 +22,17 @@ class TableNameTestSqlserver < ActiveRecord::TestCase
     assert_sql(/SELECT \* FROM \[orders\]/) { Order.all }
   end
   
+  context 'Table scoped to user.table_name' do
+
+    setup do
+      @klass = SqlServerRailsOrders
+    end
+
+    should 'have no issue doing basic column reflection' do
+      assert_nothing_raised() { @klass.columns }
+    end
+
+  end
+  
   
 end

data/test/schema/sqlserver_specific_schema.rb

@@ -65,6 +65,7 @@ ActiveRecord::Schema.define do
   create_table :sql_server_edge_schemas, :force => true do |t|
     t.string :description
     t.column :bigint, :bigint
+    t.column :tinyint, :tinyint
   end
   
   execute "IF EXISTS (SELECT TABLE_NAME FROM INFORMATION_SCHEMA.VIEWS WHERE TABLE_NAME = 'customers_view') DROP VIEW customers_view"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: activerecord-sqlserver-adapter
 version: !ruby/object:Gem::Version 
-  version: 2.2.21
+  version: 2.2.22
 platform: ruby
 authors: 
 - Ken Collins, Murray Steele, Shawn Balestracci, Joe Rafaniello, Tom Ward
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-09-10 00:00:00 -04:00
+date: 2009-10-15 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency