activerecord-session_store 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 839c59e0fa4e372772d868d85da9eeffca93cc4e
-  data.tar.gz: 27fe06dcf42428ab0530b19718c987cb7df0c05d
+  metadata.gz: 199a971acd3d868bd22acce4c420c18e9379d15e
+  data.tar.gz: 72716a9c795e148bbe8f4b52521cd545ab136efc
 SHA512:
-  metadata.gz: 5a4f5b07c3a2973c68d5517e2609f0b23297810706cfa577a1b3e0e432f100df769eb979be222dd21740d705be8ea1667dbe9445eed724cd47ae4112741019ed
-  data.tar.gz: 16f422ab72d3d3433e1f8db40db4f90ab2a67fee8fbbeca75cce544d4a11e636d28f72c2740018815bec5e1c8e891fa37e404b52e008f077453f832885706dce
+  metadata.gz: c0c2e5bc2f6426beae8f3e7954b3c89f91c050ee9f27f15b4144350966b786ea9b8d8580038662155681101e0e37714c169e24b8b57ff582c25147eaf78dd2db
+  data.tar.gz: 8ccded75455d38d05815730b050fdcd249fb9ef15110c9e7773048e4e064fce653433fa40edbe13d01434947264727decbf3309d37c1ce891815c5cc19307b5a

data/MIT-LICENSE

@@ -0,0 +1,22 @@
+Copyright (c) 2012-2015 David Heinemeier Hansson
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -21,7 +21,7 @@ Run the migration generator:
 Then, set your session store in `config/initializers/session_store.rb`:
 
 ```ruby
-MyApp::Application.config.session_store :active_record_store, :key => '_my_app_session'
+Rails.application.config.session_store :active_record_store, :key => '_my_app_session'
 ```
 
 Configuration
@@ -75,3 +75,23 @@ You must implement these methods:
 
 The example SqlBypass class is a generic SQL session store. You may
 use it as a basis for high-performance database-specific stores.
+
+Please note that you will need to manually include the silencer module to your
+custom logger if you are using a logger other than `Logger` and `Syslog::Logger`
+and their subclasses:
+
+```ruby
+MyLogger.send :include, ActiveRecord::SessionStore::Extension::LoggerSilencer
+```
+
+This silencer is being used to silence the logger and not leaking private
+information into the log, and it is required for security reason.
+
+## Contributing to Active Record Session Store
+
+Active Record Session Store is work of many contributors. You're encouraged to submit pull requests, propose features and discuss issues.
+
+See [CONTRIBUTING](CONTRIBUTING.md).
+
+## License
+Active Record Session Store is released under the [MIT License](MIT-LICENSE).

data/lib/action_dispatch/session/active_record_store.rb

@@ -62,7 +62,7 @@ module ActionDispatch
 
       private
         def get_session(env, sid)
-          logger.silence do
+          logger.silence_logger do
             unless sid and session = @@session_class.find_by_session_id(sid)
               # If the sid was nil or if there is no pre-existing session under the sid,
               # force the generation of a new sid and associate a new session associated with the new sid
@@ -75,7 +75,7 @@ module ActionDispatch
         end
 
         def set_session(env, sid, session_data, options)
-          logger.silence do
+          logger.silence_logger do
             record = get_session_model(env, sid)
             record.data = session_data
             return false unless record.save
@@ -92,7 +92,7 @@ module ActionDispatch
         end
 
         def destroy_session(env, session_id, options)
-          logger.silence do
+          logger.silence_logger do
             if sid = current_session_id(env)
               get_session_model(env, sid).destroy
               env[SESSION_RECORD_KEY] = nil

data/lib/active_record/session_store.rb

@@ -35,3 +35,8 @@ require 'active_record/session_store/railtie' if defined?(Rails)
 
 ActionDispatch::Session::ActiveRecordStore.session_class = ActiveRecord::SessionStore::Session
 Logger.send :include, ActiveRecord::SessionStore::Extension::LoggerSilencer
+
+begin
+  require "syslog/logger"
+  Syslog::Logger.send :include, ActiveRecord::SessionStore::Extension::LoggerSilencer
+rescue LoadError; end

data/lib/active_record/session_store/extension/logger_silencer.rb

@@ -30,12 +30,15 @@ module ActiveRecord
         end
 
         def add_with_threadsafety(severity, message = nil, progname = nil, &block)
-          return true if @logdev.nil? or (severity || UNKNOWN) < level
-          add_without_threadsafety(severity, message, progname, &block)
+          if !defined?(@logdev) || @logdev.nil? || (severity || UNKNOWN) < level
+            true
+          else
+            add_without_threadsafety(severity, message, progname, &block)
+          end
         end
 
         # Silences the logger for the duration of the block.
-        def silence(temporary_level = Logger::ERROR)
+        def silence_logger(temporary_level = Logger::ERROR)
           if silencer
             begin
               self.thread_level = temporary_level
@@ -65,7 +68,7 @@ module ActiveRecord
     end
 
     class NilLogger
-      def self.silence
+      def self.silence_logger
         yield
       end
     end

data/lib/active_record/session_store/railtie.rb

@@ -3,7 +3,7 @@ require 'rails/railtie'
 module ActiveRecord
   module SessionStore
     class Railtie < Rails::Railtie
-      rake_tasks { load "tasks/database.rake" }
+      rake_tasks { load File.expand_path("../../../tasks/database.rake", __FILE__) }
     end
   end
 end

data/lib/active_record/session_store/session.rb

@@ -59,7 +59,7 @@ module ActiveRecord
           end
       end
 
-      def initialize(attributes = nil)
+      def initialize(*)
         @data = nil
         super
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-session_store
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-23 00:00:00.000000000 Z
+date: 2015-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -105,6 +105,7 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
+- MIT-LICENSE
 - README.md
 - lib/action_dispatch/session/active_record_store.rb
 - lib/active_record/session_store.rb
@@ -116,7 +117,7 @@ files:
 - lib/generators/active_record/session_migration_generator.rb
 - lib/generators/active_record/templates/migration.rb
 - lib/tasks/database.rake
-homepage: http://www.rubyonrails.org
+homepage: https://github.com/rails/activerecord-session_store
 licenses:
 - MIT
 metadata: {}
@@ -138,9 +139,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: An Action Dispatch session store backed by an Active Record class.
 test_files: []
-has_rdoc: