activerecord-reputation-system 1.5.0 → 1.5.1

data/lib/reputation_system/base.rb

@@ -25,7 +25,7 @@ module ReputationSystem
       attrs = reputation[:of] == :self ? self : self.instance_eval(of.to_s) if of.is_a?(String) || of.is_a?(Symbol)
       attrs = self.instance_exec(self, &of) if of.is_a?(Proc)
       attrs = [attrs] unless attrs.is_a? Array
-      attrs
+      attrs.compact
     end
 
     def evaluate_reputation_scope(scope)

data/lib/reputation_system/version.rb

@@ -15,5 +15,5 @@
 ##
 
 module ReputationSystem
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/spec/reputation_system/base_spec.rb

@@ -58,11 +58,6 @@ describe ActiveRecord::Base do
       it "should have declared default value if any" do
         @answer.reputation_for(:avg_rating).should == 1
       end
-
-      it "should overwrite reputation definitions if the same reputation name is declared" do
-        Answer.has_reputation(:avg_rating, :source => :user, :aggregated_by => :average, :init_value => 2)
-        Answer.new.reputation_for(:avg_rating).should == 2
-      end
     end
   end
 end

data/spec/reputation_system/evaluation_spec.rb

@@ -63,11 +63,11 @@ describe ActiveRecord::Base do
         end
 
         it "should raise exception if invalid scope is given" do
-          lambda{@phrase.add_evaluation(:difficulty_with_scope, 1, :invalid_scope)}.should raise_error(ArgumentError)
+          lambda { @phrase.add_evaluation(:difficulty_with_scope, 1, :invalid_scope) }.should raise_error(ArgumentError)
         end
 
         it "should raise exception if scope is not given" do
-          lambda{@phrase.add_evaluation(:difficulty_with_scope, 1)}.should raise_error(ArgumentError)
+          lambda { @phrase.add_evaluation(:difficulty_with_scope, 1) }.should raise_error(ArgumentError)
         end
       end
     end
@@ -79,17 +79,22 @@ describe ActiveRecord::Base do
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.add_evaluation(:invalid, 1, @user)}.should raise_error(ArgumentError)
+        lambda { @question.add_evaluation(:invalid, 1, @user) }.should raise_error(ArgumentError)
       end
 
       it "should raise exception if the same source evaluates for the same target more than once" do
         @question.add_evaluation(:total_votes, 1, @user)
-        lambda{@question.add_evaluation(:total_votes, 1, @user)}.should raise_error
+        lambda { @question.add_evaluation(:total_votes, 1, @user) }.should raise_error
       end
 
       it "should not allow the same source to add an evaluation for the same target" do
         @question.add_evaluation(:total_votes, 1, @user)
-        lambda{@question.add_evaluation(:total_votes, 1, @user)}.should raise_error
+        lambda { @question.add_evaluation(:total_votes, 1, @user) }.should raise_error
+      end
+
+      it "should not raise exception if some association has not been initialized along during the propagation of reputation" do
+        answer = Answer.create!
+        lambda { answer.add_evaluation(:avg_rating, 3, @user) }.should_not raise_error
       end
 
       context "With Scopes" do
@@ -102,11 +107,11 @@ describe ActiveRecord::Base do
         end
 
         it "should raise exception if invalid scope is given" do
-          lambda{@phrase.add_evaluation(:difficulty_with_scope, 1, :invalid_scope)}.should raise_error(ArgumentError)
+          lambda { @phrase.add_evaluation(:difficulty_with_scope, 1, :invalid_scope) }.should raise_error(ArgumentError)
         end
 
         it "should raise exception if scope is not given" do
-          lambda{@phrase.add_evaluation(:difficulty_with_scope, 1)}.should raise_error(ArgumentError)
+          lambda { @phrase.add_evaluation(:difficulty_with_scope, 1) }.should raise_error(ArgumentError)
         end
       end
     end
@@ -155,15 +160,15 @@ describe ActiveRecord::Base do
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.update_evaluation(:invalid, 1, @user)}.should raise_error(ArgumentError)
+        lambda { @question.update_evaluation(:invalid, 1, @user) }.should raise_error(ArgumentError)
       end
 
       it "should raise exception if invalid source is given" do
-       lambda {@question.update_evaluation(:total_votes, 1, @answer)}.should raise_error(ArgumentError)
+       lambda { @question.update_evaluation(:total_votes, 1, @answer) }.should raise_error(ArgumentError)
       end
 
       it "should raise exception if evaluation does not exist" do
-        lambda{@answer.update_evaluation(:avg_rating, 1, @user)}.should raise_error
+        lambda { @answer.update_evaluation(:avg_rating, 1, @user) }.should raise_error
       end
 
       context "With Scopes" do
@@ -179,11 +184,11 @@ describe ActiveRecord::Base do
         end
 
         it "should raise exception if invalid scope is given" do
-          lambda{@phrase.update_evaluation(:difficulty_with_scope, 5, @user, :invalid_scope)}.should raise_error(ArgumentError)
+          lambda { @phrase.update_evaluation(:difficulty_with_scope, 5, @user, :invalid_scope) }.should raise_error(ArgumentError)
         end
 
         it "should raise exception if scope is not given" do
-          lambda{@phrase.update_evaluation(:difficulty_with_scope, 5, @user)}.should raise_error(ArgumentError)
+          lambda { @phrase.update_evaluation(:difficulty_with_scope, 5, @user) }.should raise_error(ArgumentError)
         end
       end
     end
@@ -199,15 +204,15 @@ describe ActiveRecord::Base do
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.delete_evaluation!(:invalid, @user)}.should raise_error(ArgumentError)
+        lambda { @question.delete_evaluation!(:invalid, @user) }.should raise_error(ArgumentError)
       end
 
       it "should raise exception if invalid source is given" do
-       lambda {@question.delete_evaluation!(:total_votes, @answer)}.should raise_error(ArgumentError)
+       lambda { @question.delete_evaluation!(:total_votes, @answer) }.should raise_error(ArgumentError)
       end
 
       it "should raise exception if evaluation does not exist" do
-        lambda{@answer.delete_evaluation!(:avg_rating, @user)}.should raise_error
+        lambda { @answer.delete_evaluation!(:avg_rating, @user) }.should raise_error
       end
 
       context "With Scopes" do
@@ -223,11 +228,11 @@ describe ActiveRecord::Base do
         end
 
         it "should raise exception if invalid scope is given" do
-          lambda{@phrase.delete_evaluation!(:difficulty_with_scope, @user, :invalid_scope)}.should raise_error(ArgumentError)
+          lambda { @phrase.delete_evaluation!(:difficulty_with_scope, @user, :invalid_scope) }.should raise_error(ArgumentError)
         end
 
         it "should raise exception if scope is not given" do
-          lambda{@phrase.delete_evaluation!(:difficulty_with_scope, @user)}.should raise_error(ArgumentError)
+          lambda { @phrase.delete_evaluation!(:difficulty_with_scope, @user) }.should raise_error(ArgumentError)
         end
       end
     end
@@ -243,7 +248,7 @@ describe ActiveRecord::Base do
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.delete_evaluation(:invalid, @user)}.should raise_error(ArgumentError)
+        lambda { @question.delete_evaluation(:invalid, @user) }.should raise_error(ArgumentError)
       end
 
       it "should return nil if evaluation does not exist" do
@@ -263,11 +268,11 @@ describe ActiveRecord::Base do
         end
 
         it "should raise exception if invalid scope is given" do
-          lambda{@phrase.delete_evaluation(:difficulty_with_scope, @user, :invalid_scope)}.should raise_error(ArgumentError)
+          lambda { @phrase.delete_evaluation(:difficulty_with_scope, @user, :invalid_scope) }.should raise_error(ArgumentError)
         end
 
         it "should raise exception if scope is not given" do
-          lambda{@phrase.delete_evaluation(:difficulty_with_scope, @user)}.should raise_error(ArgumentError)
+          lambda { @phrase.delete_evaluation(:difficulty_with_scope, @user) }.should raise_error(ArgumentError)
         end
       end
     end

metadata

@@ -1,13 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: activerecord-reputation-system
 version: !ruby/object:Gem::Version 
-  hash: 3
   prerelease: 
-  segments: 
-  - 1
-  - 5
-  - 0
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors: 
 - Katsuya Noguchi
@@ -15,98 +10,73 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-09-15 00:00:00 Z
+date: 2012-10-04 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  name: activerecord
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :development
-  name: activerecord
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
+  name: rake
   prerelease: false
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 49
-        segments: 
-        - 0
-        - 8
-        - 7
         version: 0.8.7
   type: :development
-  name: rake
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
+  name: rspec
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 19
-        segments: 
-        - 2
-        - 8
         version: "2.8"
   type: :development
-  name: rspec
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
+  name: rdoc
   prerelease: false
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
         version: "0"
   type: :development
-  name: rdoc
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
+  name: database_cleaner
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 1
-        segments: 
-        - 0
-        - 7
-        - 1
         version: 0.7.1
   type: :development
-  name: database_cleaner
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
+  name: sqlite3
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 17
-        segments: 
-        - 1
-        - 3
-        - 5
         version: 1.3.5
   type: :development
-  name: sqlite3
   version_requirements: *id006
 description: ActiveRecord Reputation System gem allows rails apps to compute and publish reputation scores for active record models.
 email: 
@@ -165,23 +135,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: ActiveRecord Reputation System gem allows rails apps to compute and publish reputation scores for active record models