activerecord-reputation-system 1.4.0 → 1.5.0

data/README.md

@@ -70,9 +70,9 @@ Once reputation system is defined, evaluations for answers and questions can be
 
 Reputation value can be accessed as follow:
 ```ruby
-@answer.reputation_value_for(:avg_rating)
-@question.reputation_value_for(:votes)
-@user.reputation_value_for(:karma)
+@answer.reptuation_for(:avg_rating)
+@question.reptuation_for(:votes)
+@user.reptuation_for(:karma)
 ```
 
 ## Defining Reputation System
@@ -134,7 +134,7 @@ decrease_evaluation(reputation_name, value, source)
 ## Reputation
 ```ruby
 # Returns the reputation value of the reputation with the given name.
-reputation_value_for(reputation_name)
+reptuation_for(reputation_name)
 
 # Returns the reputation rank of the reputation with the given name.
 rank_for(reputation_name)
@@ -142,7 +142,7 @@ rank_for(reputation_name)
 # Returns the normalized reputation value of the reputation with the given name. The normalization is computed using the following equation (assuming linear distribution):
 # normalized_value = (x - min) / (max - min) if max - min is not 0
 # normalized_value = 1 if max - min is 0
-normalized_reputation_value_for(reputation_name)
+normalized_reptuation_for(reputation_name)
 
 # Activates all reputations in the record. Active reputations are used when computing ranks or normalized reputation values.
 activate_all_reputations
@@ -213,7 +213,7 @@ add_evaluation(:reputation_name, evaluation_value, source, :scope)
 ```
 Also, reputations can be accessed in the context of scopes:
 ```ruby
-reputation_value_for(:reputation_name, :scope)
+reptuation_for(:reputation_name, :scope)
 ```
 To use a scoped reputation as a source in another reputation, try this:
 ```ruby

data/lib/models/rs_evaluation.rb

@@ -21,15 +21,19 @@ class RSEvaluation < ActiveRecord::Base
 
   attr_accessible :reputation_name, :value, :source, :source_id, :source_type, :target, :target_id, :target_type
 
+  # Sets an appropriate source type in case of Single Table Inheritance.
+  before_validation :set_source_type_for_sti
+
   # the same source cannot evaluate the same target more than once.
   validates_uniqueness_of :source_id, :scope => [:reputation_name, :source_type, :target_id, :target_type]
   validate :source_must_be_defined_for_reputation_in_network
 
   def self.find_by_reputation_name_and_source_and_target(reputation_name, source, target)
+    source_type = get_source_type_for_sti(source, target.class.name, reputation_name)
     RSEvaluation.find(:first,
                       :conditions => {:reputation_name => reputation_name.to_s,
                                       :source_id => source.id,
-                                      :source_type => source.class.name,
+                                      :source_type => source_type,
                                       :target_id => target.id,
                                       :target_type => target.class.name
                                       })
@@ -43,6 +47,20 @@ class RSEvaluation < ActiveRecord::Base
 
   protected
 
+    def self.get_source_type_for_sti(source, target_type, reputation_name)
+      valid_source_type = ReputationSystem::Network.get_reputation_def(target_type, reputation_name)[:source].to_s.camelize
+      temp = source.class
+      while temp && valid_source_type != temp.name && temp.name != "ActiveRecord::Base"
+        temp = temp.superclass
+      end
+      temp ? temp.name : nil
+    end
+
+    def set_source_type_for_sti
+      temp = self.class.get_source_type_for_sti(source, target_type, reputation_name)
+      self.source_type = temp if temp
+    end
+
     def source_must_be_defined_for_reputation_in_network
       unless source_type == ReputationSystem::Network.get_reputation_def(target_type, reputation_name)[:source].to_s.camelize
         errors.add(:source_type, "#{source_type} is not source of #{reputation_name} reputation")

data/lib/models/rs_reputation.rb

@@ -25,6 +25,7 @@ class RSReputation < ActiveRecord::Base
 
   attr_accessible :reputation_name, :value, :aggregated_by, :active, :target, :target_id, :target_type, :received_messages
 
+  before_validation :set_target_type_for_sti
   before_save :change_zero_value_in_case_of_product_process
 
   VALID_PROCESSES = ['sum', 'average', 'product']
@@ -32,7 +33,8 @@ class RSReputation < ActiveRecord::Base
   validates_uniqueness_of :reputation_name, :scope => [:target_id, :target_type]
 
   def self.find_by_reputation_name_and_target(reputation_name, target)
-    RSReputation.find_by_reputation_name_and_target_id_and_target_type(reputation_name.to_s, target.id, target.class.name)
+    target_type = get_target_type_for_sti(target, reputation_name)
+    RSReputation.find_by_reputation_name_and_target_id_and_target_type(reputation_name.to_s, target.id, target_type)
   end
 
   # All external access to reputation should use this since they are created lazily.
@@ -176,6 +178,21 @@ class RSReputation < ActiveRecord::Base
                            :conditions => {:reputation_name => reputation_name.to_s, :target_type => target_type, :active => true})
     end
 
+    def self.get_target_type_for_sti(target, reputation_name)
+      temp = target.class
+      defs = ReputationSystem::Network.get_reputation_defs(temp.name)[reputation_name.to_sym]
+      while temp && temp.name != "ActiveRecord::Base" && defs && defs.empty?
+        temp = temp.superclass
+        defs = ReputationSystem::Network.get_reputation_defs(temp.name)[reputation_name.to_sym]
+      end
+      temp ? temp.name : nil
+    end
+
+    def set_target_type_for_sti
+      temp = self.class.get_target_type_for_sti(target, reputation_name)
+      self.target_type = temp if temp
+    end
+
     def change_zero_value_in_case_of_product_process
       self.value = 1 if self.value == 0 && self.aggregated_by == "product"
     end

data/lib/reputation_system/network.rb

@@ -18,8 +18,8 @@ module ReputationSystem
   class Network
     class << self
       def has_reputation_for?(class_name, reputation_name)
-        reputation_defs = get_reputation_defs(class_name)
-        reputation_defs[reputation_name.to_sym] && reputation_defs[reputation_name.to_sym][:source]
+        reputation_def = get_reputation_def(class_name, reputation_name)
+        !!reputation_def[:source]
       end
 
       def get_reputation_defs(class_name)
@@ -27,8 +27,21 @@ module ReputationSystem
       end
 
       def get_reputation_def(class_name, reputation_name)
-        reputation_defs = get_reputation_defs(class_name)
-        reputation_defs[reputation_name.to_sym] ||= {}
+        reputation_def = {}
+        unless class_name == "ActiveRecord::Base"
+          reputation_defs = get_reputation_defs(class_name)
+          reputation_defs[reputation_name.to_sym] ||= {}
+          reputation_def = reputation_defs[reputation_name.to_sym]
+          if reputation_def == {}
+            begin
+              klass = class_name.constantize.superclass
+              reputation_def = get_reputation_def(klass.name, reputation_name) if klass
+            rescue NameError
+              # Class might have not been initialized yet at this point.
+            end
+          end
+        end
+        reputation_def
       end
 
       def add_reputation_def(class_name, reputation_name, options)

data/lib/reputation_system/reputation.rb

@@ -17,10 +17,20 @@
 module ReputationSystem
   module Reputation
     def reputation_value_for(reputation_name, *args)
+      warn "[DEPRECATION] `reputation_value_for` will be deprecated in version 2.0.0. Please use `reputation_for` instead."
+      reputation_for(reputation_name, *args)
+    end
+
+    def reputation_for(reputation_name, *args)
       find_reputation(reputation_name, args.first).value
     end
 
     def normalized_reputation_value_for(reputation_name, *args)
+      warn "[DEPRECATION] `normalized_reputation_value_for` will be deprecated in version 2.0.0. Please use `normalized_reputation_for` instead."
+      normalized_reputation_for(reputation_name, *args)
+    end
+
+    def normalized_reputation_for(reputation_name, *args)
       find_reputation(reputation_name, args.first).normalized_value
     end
 
@@ -45,7 +55,7 @@ module ReputationSystem
 
     def rank_for(reputation_name, *args)
       scope = args.first
-      my_value = self.reputation_value_for(reputation_name, scope)
+      my_value = self.reputation_for(reputation_name, scope)
       self.class.count_with_reputation(reputation_name, scope, :all,
         :conditions => ["rs_reputations.value > ?", my_value]
       ) + 1

data/lib/reputation_system/version.rb

@@ -15,5 +15,5 @@
 ##
 
 module ReputationSystem
-  VERSION = "1.4.0"
+  VERSION = "1.5.0"
 end

data/spec/models/rs_evaluation_spec.rb

@@ -32,6 +32,24 @@ describe RSEvaluation do
     end
   end
 
+  context "Callback" do
+    describe "#set_source_type_for_sti" do
+      it "should assign source class name as source type if not STI" do
+        question = Question.create!(:text => 'Does this work?', :author_id => @user.id)
+        question.add_evaluation(:total_votes, 5, @user)
+        evaluation = RSEvaluation.find_by_reputation_name_and_source_and_target(:total_votes, @user, question)
+        evaluation.source_type.should == @user.class.name
+      end
+      it "should assign source's ancestors class name where reputation is declared if STI" do
+        designer = Designer.create! :name => 'hiro'
+        programmer = Programmer.create! :name => 'katsuya'
+        programmer.add_evaluation(:leadership, 1, designer)
+        evaluation = RSEvaluation.find_by_reputation_name_and_source_and_target(:leadership, designer, programmer)
+        evaluation.source_type.should == Person.name
+      end
+    end
+  end
+
   context "Association" do
     it "should delete associated reputation message" do
       @question.add_evaluation(:total_votes, 5, @user)

data/spec/models/rs_reputation_spec.rb

@@ -56,6 +56,24 @@ describe RSReputation do
     end
   end
 
+  context "Callback" do
+    describe "#set_target_type_for_sti" do
+      it "should assign target class name as target type if not STI" do
+        question = Question.create!(:text => 'Does this work?', :author_id => @user.id)
+        question.add_evaluation(:total_votes, 5, @user)
+        rep = RSReputation.find_by_reputation_name_and_target(:total_votes, question)
+        rep.target_type.should == question.class.name
+      end
+      it "should assign target's ancestors class name where reputation is declared if STI" do
+        designer = Designer.create! :name => 'hiro'
+        programmer = Programmer.create! :name => 'katsuya'
+        programmer.add_evaluation(:leadership, 1, designer)
+        rep = RSReputation.find_by_reputation_name_and_target(:leadership, programmer)
+        rep.target_type.should == Person.name
+      end
+    end
+  end
+
   context "Association" do
     before :each do
       @question = Question.create!(:text => 'What is Twitter?', :author_id => @user.id)

data/spec/reputation_system/base_spec.rb

@@ -36,14 +36,14 @@ describe ActiveRecord::Base do
         @user.respond_to?(:add_evaluation).should == false
       end
 
-      it "should add 'reputation_value_for' method to a model with reputation" do
-        @user.respond_to?(:reputation_value_for).should == true
-        @question.respond_to?(:reputation_value_for).should == true
+      it "should add 'reputation_for' method to a model with reputation" do
+        @user.respond_to?(:reputation_for).should == true
+        @question.respond_to?(:reputation_for).should == true
       end
 
-      it "should add 'normalized_reputation_value_for' method to a model with reputation" do
-        @user.respond_to?(:normalized_reputation_value_for).should == true
-        @question.respond_to?(:normalized_reputation_value_for).should == true
+      it "should add 'normalized_reputation_for' method to a model with reputation" do
+        @user.respond_to?(:normalized_reputation_for).should == true
+        @question.respond_to?(:normalized_reputation_for).should == true
       end
 
       it "should delete reputations if target is deleted" do
@@ -56,12 +56,12 @@ describe ActiveRecord::Base do
       end
 
       it "should have declared default value if any" do
-        @answer.reputation_value_for(:avg_rating).should == 1
+        @answer.reputation_for(:avg_rating).should == 1
       end
 
       it "should overwrite reputation definitions if the same reputation name is declared" do
         Answer.has_reputation(:avg_rating, :source => :user, :aggregated_by => :average, :init_value => 2)
-        Answer.new.reputation_value_for(:avg_rating).should == 2
+        Answer.new.reputation_for(:avg_rating).should == 2
       end
     end
   end

data/spec/reputation_system/evaluation_spec.rb

@@ -75,7 +75,7 @@ describe ActiveRecord::Base do
     describe "#add_evaluation" do
       it "should create evaluation in case of valid input" do
         @question.add_evaluation(:total_votes, 1, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 1
+        @question.reputation_for(:total_votes).should == 1
       end
 
       it "should raise exception if invalid reputation name is given" do
@@ -96,9 +96,9 @@ describe ActiveRecord::Base do
         it "should add evaluation on appropriate scope" do
           @phrase.add_evaluation(:difficulty_with_scope, 1, @user, :s1).should be_true
           @phrase.add_evaluation(:difficulty_with_scope, 2, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 1
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 2
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 1
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 2
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
 
         it "should raise exception if invalid scope is given" do
@@ -114,22 +114,22 @@ describe ActiveRecord::Base do
     describe "#add_or_update_evaluation" do
       it "should create evaluation if it does not exist" do
         @question.add_or_update_evaluation(:total_votes, 1, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 1
+        @question.reputation_for(:total_votes).should == 1
       end
 
       it "should update evaluation if it exists already" do
         @question.add_evaluation(:total_votes, 1, @user)
         @question.add_or_update_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 2
+        @question.reputation_for(:total_votes).should == 2
       end
 
       context "With Scopes" do
         it "should add evaluation on appropriate scope if it does not exist" do
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 1, @user, :s1).should be_true
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 2, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 1
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 2
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 1
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 2
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
 
         it "should update evaluation on appropriate scope if it exists already" do
@@ -137,9 +137,9 @@ describe ActiveRecord::Base do
           @phrase.add_evaluation(:difficulty_with_scope, 2, @user, :s2).should be_true
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 3, @user, :s1).should be_true
           @phrase.add_or_update_evaluation(:difficulty_with_scope, 5, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 3
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 5
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 3
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 5
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
       end
     end
@@ -151,7 +151,7 @@ describe ActiveRecord::Base do
 
       it "should update evaluation in case of valid input" do
         @question.update_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 2
+        @question.reputation_for(:total_votes).should == 2
       end
 
       it "should raise exception if invalid reputation name is given" do
@@ -173,9 +173,9 @@ describe ActiveRecord::Base do
 
         it "should update evaluation on appropriate scope" do
           @phrase.update_evaluation(:difficulty_with_scope, 5, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 5
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 5
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
 
         it "should raise exception if invalid scope is given" do
@@ -195,7 +195,7 @@ describe ActiveRecord::Base do
 
       it "should delete evaluation in case of valid input" do
         @question.delete_evaluation!(:total_votes, @user)
-        @question.reputation_value_for(:total_votes).should == 0
+        @question.reputation_for(:total_votes).should == 0
       end
 
       it "should raise exception if invalid reputation name is given" do
@@ -217,9 +217,9 @@ describe ActiveRecord::Base do
 
         it "should delete evaluation on appropriate scope" do
           @phrase.delete_evaluation!(:difficulty_with_scope, @user, :s2)
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
 
         it "should raise exception if invalid scope is given" do
@@ -239,7 +239,7 @@ describe ActiveRecord::Base do
 
       it "should delete evaluation in case of valid input" do
         @question.delete_evaluation(:total_votes, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 0
+        @question.reputation_for(:total_votes).should == 0
       end
 
       it "should raise exception if invalid reputation name is given" do
@@ -257,9 +257,9 @@ describe ActiveRecord::Base do
 
         it "should delete evaluation on appropriate scope" do
           @phrase.delete_evaluation(:difficulty_with_scope, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
 
         it "should raise exception if invalid scope is given" do
@@ -275,13 +275,13 @@ describe ActiveRecord::Base do
     describe "#increase_evaluation" do
       it "should add evaluation if it does not exist" do
         @question.increase_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 2
+        @question.reputation_for(:total_votes).should == 2
       end
 
       it "should increase evaluation if it exists already" do
         @question.add_evaluation(:total_votes, 1, @user)
         @question.increase_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == 3
+        @question.reputation_for(:total_votes).should == 3
       end
 
       context "With Scopes" do
@@ -291,9 +291,9 @@ describe ActiveRecord::Base do
 
         it "should increase evaluation on appropriate scope" do
           @phrase.increase_evaluation(:difficulty_with_scope, 5, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == 7
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == 7
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
       end
     end
@@ -301,13 +301,13 @@ describe ActiveRecord::Base do
     describe "#decrease_evaluation" do
       it "should add evaluation if it does not exist" do
         @question.decrease_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == -2
+        @question.reputation_for(:total_votes).should == -2
       end
 
       it "should increase evaluation if it exists already" do
         @question.add_evaluation(:total_votes, 1, @user)
         @question.decrease_evaluation(:total_votes, 2, @user).should be_true
-        @question.reputation_value_for(:total_votes).should == -1
+        @question.reputation_for(:total_votes).should == -1
       end
 
       context "With Scopes" do
@@ -317,9 +317,9 @@ describe ActiveRecord::Base do
 
         it "should decrease evaluation on appropriate scope" do
           @phrase.decrease_evaluation(:difficulty_with_scope, 5, @user, :s2).should be_true
-          @phrase.reputation_value_for(:difficulty_with_scope, :s1).should == 0
-          @phrase.reputation_value_for(:difficulty_with_scope, :s2).should == -3
-          @phrase.reputation_value_for(:difficulty_with_scope, :s3).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s1).should == 0
+          @phrase.reputation_for(:difficulty_with_scope, :s2).should == -3
+          @phrase.reputation_for(:difficulty_with_scope, :s3).should == 0
         end
       end
     end
@@ -336,8 +336,8 @@ describe ActiveRecord::Base do
         it "should affect only reputations with relevant scope" do
           @trans_ja.add_evaluation(:votes, 1, @user)
           @trans_fr.add_evaluation(:votes, 2, @user)
-          @phrase.reputation_value_for(:maturity, :ja).should == 1
-          @phrase.reputation_value_for(:maturity, :fr).should == 2
+          @phrase.reputation_for(:maturity, :ja).should == 1
+          @phrase.reputation_for(:maturity, :fr).should == 2
         end
       end
 
@@ -348,8 +348,8 @@ describe ActiveRecord::Base do
 
         it "should affect only reputations with relevant scope" do
           @trans_ja.update_evaluation(:votes, 3, @user)
-          @phrase.reputation_value_for(:maturity, :ja).should == 3
-          @phrase.reputation_value_for(:maturity, :fr).should == 0
+          @phrase.reputation_for(:maturity, :ja).should == 3
+          @phrase.reputation_for(:maturity, :fr).should == 0
         end
       end
 
@@ -360,8 +360,8 @@ describe ActiveRecord::Base do
 
         it "should affect only reputations with relevant scope" do
           @trans_ja.delete_evaluation!(:votes, @user)
-          @phrase.reputation_value_for(:maturity, :ja).should == 0
-          @phrase.reputation_value_for(:maturity, :fr).should == 0
+          @phrase.reputation_for(:maturity, :ja).should == 0
+          @phrase.reputation_for(:maturity, :fr).should == 0
         end
       end
     end
@@ -378,14 +378,14 @@ describe ActiveRecord::Base do
       describe "#add_evaluation" do
         it "should affect only reputations with relevant scope" do
           @trans_ja.add_evaluation(:votes, 1, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 1
+          @phrase.reputation_for(:maturity_all).should == 1
           @trans_fr.add_evaluation(:votes, 2, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 3
+          @phrase.reputation_for(:maturity_all).should == 3
           @trans_de.add_evaluation(:votes, 3, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 3
-          @phrase.reputation_value_for(:maturity, :ja).should == 1
-          @phrase.reputation_value_for(:maturity, :fr).should == 2
-          @phrase.reputation_value_for(:maturity, :de).should == 3
+          @phrase.reputation_for(:maturity_all).should == 3
+          @phrase.reputation_for(:maturity, :ja).should == 1
+          @phrase.reputation_for(:maturity, :fr).should == 2
+          @phrase.reputation_for(:maturity, :de).should == 3
         end
       end
 
@@ -398,7 +398,7 @@ describe ActiveRecord::Base do
         it "should affect only reputations with relevant scope" do
           @trans_ja.update_evaluation(:votes, 3, @user)
           @trans_de.update_evaluation(:votes, 2, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 3
+          @phrase.reputation_for(:maturity_all).should == 3
         end
       end
 
@@ -410,9 +410,9 @@ describe ActiveRecord::Base do
 
         it "should affect only reputations with relevant scope" do
           @trans_de.delete_evaluation!(:votes, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 1
+          @phrase.reputation_for(:maturity_all).should == 1
           @trans_ja.delete_evaluation!(:votes, @user)
-          @phrase.reputation_value_for(:maturity_all).should == 0
+          @phrase.reputation_for(:maturity_all).should == 0
         end
       end
     end

data/spec/reputation_system/reputation_spec.rb

@@ -26,28 +26,28 @@ describe ActiveRecord::Base do
   end
 
   context "Primary Reputation" do
-    describe "#reputation_value_for" do
+    describe "#reputation_for" do
       it "should return 0 as a default" do
-        @question.reputation_value_for(:total_votes).should == 0
+        @question.reputation_for(:total_votes).should == 0
       end
 
       it "should return appropriate value in case of valid input" do
         user2 = User.new(:name => 'dick')
         @question.add_evaluation(:total_votes, 1, @user)
         @question.add_evaluation(:total_votes, 1, user2)
-        @question.reputation_value_for(:total_votes).should == 2
+        @question.reputation_for(:total_votes).should == 2
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.reputation_value_for(:invalid)}.should raise_error(ArgumentError)
+        lambda {@question.reputation_for(:invalid)}.should raise_error(ArgumentError)
       end
 
       it "should raise exception if scope is given for reputation with no scopes" do
-        lambda {@question.reputation_value_for(:difficulty, :s1)}.should raise_error(ArgumentError)
+        lambda {@question.reputation_for(:difficulty, :s1)}.should raise_error(ArgumentError)
       end
 
       it "should raise exception if scope is not given for reputation with scopes" do
-        lambda {@phrase.reputation_value_for(:difficulty_with_scope)}.should raise_error(ArgumentError)
+        lambda {@phrase.reputation_for(:difficulty_with_scope)}.should raise_error(ArgumentError)
       end
     end
 
@@ -83,20 +83,20 @@ describe ActiveRecord::Base do
   end
 
   context "Non-Primary Reputation with Gathering Aggregation" do
-    describe "#reputation_value_for" do
+    describe "#reputation_for" do
       it "should always have correct updated value" do
         question2 = Question.create!(:text => 'Does this work?', :author_id => @user.id)
-        @user.reputation_value_for(:question_karma).should == 0
+        @user.reputation_for(:question_karma).should == 0
         @question.add_evaluation(:total_votes, 1, @user)
-        @user.reputation_value_for(:question_karma).should == 1
+        @user.reputation_for(:question_karma).should == 1
         question2.add_evaluation(:total_votes, 1, @user)
-        @user.reputation_value_for(:question_karma).should == 2
+        @user.reputation_for(:question_karma).should == 2
       end
     end
   end
 
   context "Non-Primary Reputation with Mixing Aggregation" do
-    describe "#reputation_value_for" do
+    describe "#reputation_for" do
       it "should always have correct updated value" do
         question = Question.create!(:text => 'Does this work?', :author_id => @user.id)
         question2 = Question.create!(:text => 'Does this work?', :author_id => @user.id)
@@ -108,19 +108,19 @@ describe ActiveRecord::Base do
         answer2 = Answer.create!(:text => 'Yes!', :author_id => @user.id, :question_id => question2.id)
         answer.add_evaluation(:avg_rating, 3, @user)
         answer2.add_evaluation(:avg_rating, 2, @user)
-        answer.reputation_value_for(:weighted_avg_rating).should == 3
-        answer2.reputation_value_for(:weighted_avg_rating).should == 4
-        @user.reputation_value_for(:answer_karma).should be_within(DELTA).of(3.5)
-        @user.reputation_value_for(:question_karma).should be_within(DELTA).of(2)
-        @user.reputation_value_for(:karma).should be_within(DELTA).of(1.4)
+        answer.reputation_for(:weighted_avg_rating).should == 3
+        answer2.reputation_for(:weighted_avg_rating).should == 4
+        @user.reputation_for(:answer_karma).should be_within(DELTA).of(3.5)
+        @user.reputation_for(:question_karma).should be_within(DELTA).of(2)
+        @user.reputation_for(:karma).should be_within(DELTA).of(1.4)
       end
     end
   end
 
   context "Normalization" do
-    describe "#normalized_reputation_value_for" do
+    describe "#normalized_reputation_for" do
       it "should return 0 as if there is no data" do
-        @question.normalized_reputation_value_for(:total_votes).should == 0
+        @question.normalized_reputation_for(:total_votes).should == 0
       end
 
       it "should return appropriate value in case of valid input" do
@@ -129,21 +129,21 @@ describe ActiveRecord::Base do
         @question.add_evaluation(:total_votes, 1, @user)
         question2.add_evaluation(:total_votes, 2, @user)
         question3.add_evaluation(:total_votes, 3, @user)
-        @question.normalized_reputation_value_for(:total_votes).should == 0
-        question2.normalized_reputation_value_for(:total_votes).should == 0.5
-        question3.normalized_reputation_value_for(:total_votes).should == 1
+        @question.normalized_reputation_for(:total_votes).should == 0
+        question2.normalized_reputation_for(:total_votes).should == 0.5
+        question3.normalized_reputation_for(:total_votes).should == 1
       end
 
       it "should raise exception if invalid reputation name is given" do
-        lambda {@question.normalized_reputation_value_for(:invalid)}.should raise_error(ArgumentError)
+        lambda {@question.normalized_reputation_for(:invalid)}.should raise_error(ArgumentError)
       end
 
       it "should raise exception if scope is given for reputation with no scopes" do
-        lambda {@question.normalized_reputation_value_for(:difficulty, :s1)}.should raise_error(ArgumentError)
+        lambda {@question.normalized_reputation_for(:difficulty, :s1)}.should raise_error(ArgumentError)
       end
 
       it "should raise exception if scope is not given for reputation with scopes" do
-        lambda {@phrase.normalized_reputation_value_for(:difficulty_with_scope)}.should raise_error(ArgumentError)
+        lambda {@phrase.normalized_reputation_for(:difficulty_with_scope)}.should raise_error(ArgumentError)
       end
     end
 

data/spec/reputation_system/scope_spec.rb

@@ -29,7 +29,7 @@ describe ActiveRecord::Base do
     it "should add scope if the reputation has scopes defined" do
       Phrase.add_scope_for(:difficulty_with_scope, :s4)
       @phrase.add_evaluation(:difficulty_with_scope, 2, @user, :s4)
-      @phrase.reputation_value_for(:difficulty_with_scope, :s4).should == 2
+      @phrase.reputation_for(:difficulty_with_scope, :s4).should == 2
     end
 
     it "should raise exception if the scope already exist" do
@@ -40,4 +40,4 @@ describe ActiveRecord::Base do
       lambda{Question.add_scope_for(:difficulty, :s1)}.should raise_error(ArgumentError)
     end
   end
-end
+end

data/spec/spec_helper.rb

@@ -102,6 +102,12 @@ ActiveRecord::Schema.define do
     t.string  :locale
     t.timestamps
   end
+
+  create_table :people do |t|
+    t.string :name
+    t.string :type
+    t.timestamps
+  end
 end
 
 class User < ActiveRecord::Base
@@ -110,16 +116,16 @@ class User < ActiveRecord::Base
 
   has_reputation :karma,
     :source => [
-      {:reputation => :question_karma},
-      {:reputation => :answer_karma, :weight => 0.2}],
+      { :reputation => :question_karma },
+      { :reputation => :answer_karma, :weight => 0.2 }],
     :aggregated_by => :product
 
   has_reputation :question_karma,
-    :source => {:reputation => :total_votes, :of => :questions},
+    :source => { :reputation => :total_votes, :of => :questions },
     :aggregated_by => :sum
 
   has_reputation :answer_karma,
-    :source => {:reputation => :weighted_avg_rating, :of => :answers},
+    :source => { :reputation => :weighted_avg_rating, :of => :answers },
     :aggregated_by => :average
 end
 
@@ -130,7 +136,7 @@ class Question < ActiveRecord::Base
   has_reputation :total_votes,
     :source => :user,
     :aggregated_by => :sum,
-    :source_of => {:reputation => :question_karma, :of => :author}
+    :source_of => { :reputation => :question_karma, :of => :author }
 
   has_reputation :difficulty,
     :source => :user,
@@ -143,10 +149,10 @@ class Answer < ActiveRecord::Base
 
   has_reputation :weighted_avg_rating,
     :source => [
-      {:reputation => :avg_rating},
-      {:reputation => :difficulty, :of => :question}],
+      { :reputation => :avg_rating },
+      { :reputation => :difficulty, :of => :question }],
     :aggregated_by => :product,
-    :source_of => {:reputation => :answer_karma, :of => :author}
+    :source_of => { :reputation => :answer_karma, :of => :author }
 
   has_reputation :avg_rating,
     :source => :user,
@@ -163,15 +169,15 @@ class Phrase < ActiveRecord::Base
 
   has_reputation :maturity_all,
     :source => [
-      {:reputation => :maturity, :of => :self, :scope => :ja},
-      {:reputation => :maturity, :of => :self, :scope => :fr}],
+      { :reputation => :maturity, :of => :self, :scope => :ja },
+      { :reputation => :maturity, :of => :self, :scope => :fr }],
     :aggregated_by => :sum
 
   has_reputation :maturity,
     :source => { :reputation => :votes, :of => lambda {|this, s| this.translations.for(s)} },
     :aggregated_by => :sum,
     :scopes => [:ja, :fr, :de],
-    :source_of => {:reputation => :maturity_all, :of => :self, :defined_for_scope => [:ja, :fr]}
+    :source_of => { :reputation => :maturity_all, :of => :self, :defined_for_scope => [:ja, :fr] }
 
   has_reputation :difficulty_with_scope,
     :source => :user,
@@ -186,5 +192,17 @@ class Translation < ActiveRecord::Base
   has_reputation :votes,
     :source => :user,
     :aggregated_by => :sum,
-    :source_of => {:reputation => :maturity, :of => :phrase, :scope => :locale}
+    :source_of => { :reputation => :maturity, :of => :phrase, :scope => :locale} 
+end
+
+class Person < ActiveRecord::Base
+  has_reputation :leadership,
+    :source => :person,
+    :aggregated_by => :sum
+end
+
+class Programmer < Person
+end
+
+class Designer < Person
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: activerecord-reputation-system
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 3
   prerelease: 
   segments: 
   - 1
-  - 4
+  - 5
   - 0
-  version: 1.4.0
+  version: 1.5.0
 platform: ruby
 authors: 
 - Katsuya Noguchi
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-09-10 00:00:00 Z
+date: 2012-09-15 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   prerelease: false