activerecord-precount 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b261414eec5a1fd723fb2fcea8cbe708c48415ca
-  data.tar.gz: 1d522f1cb7b9a7f0ac94d479feed434805d3077f
+  metadata.gz: c92657e5f11805aecb44010c1df4fe3974bf05da
+  data.tar.gz: 60838e0e6fcea0079f0d008ccc4424697675006f
 SHA512:
-  metadata.gz: 9ddc79eeb3385aa2be6a1973c5e1bb11dba1fe123e3e9e6064fb3c16445922ff8273d8268a0ca37a8801b31fa9edd3cb5f70c091f5f3d23efa8fa2d4fde7915e
-  data.tar.gz: 4340c6a29f8040a154d1f6d6c5a401064efc60bfab6ec654c808da6a2e58fc804c834507d8c2d35229034ead2dc72340e85218eaa31fd053f91d7a9a3d59c99a
+  metadata.gz: b93b4d140152d202018ea73a66b80a34bc3c55ee38a81d3ee4bb2d721ddcbd509d45aff9446278b0513c4c925979b4eef2258d50524d44b4b5664a1aa827f960
+  data.tar.gz: 65a1f4826a8686dec6e64873e3b8760c55a3a8bed687ec906f3897d09116792cdec13578d8b5e6c4a531404e099cea8f7e37f7e8e2e1d8e771e18881acae7db3

data/ci/Gemfile.activerecord-5.0.x

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 
-gem 'rails', '5.0.0.rc1'
+gem 'rails', '5.0.0'
 gemspec path: '..'

data/lib/active_record/precount.rb

@@ -28,6 +28,7 @@ require "active_support/lazy_load_hooks"
 #       * collection_proxy_extension: Fallback to eager-loaded values when foo.count is called
 #
 ActiveSupport.on_load(:active_record) do
+  require "active_record/precount/autosave_association_extension"
   require "active_record/precount/base_extension"
   require "active_record/precount/collection_proxy_extension"
   require "active_record/precount/has_many_extension"

data/lib/active_record/precount/autosave_association_extension.rb

@@ -0,0 +1,14 @@
+module ActiveRecord
+  module Precount
+    module AutosaveAssociationExtension
+      private
+
+      def save_belongs_to_association(reflection)
+        return if reflection.is_a? ActiveRecord::Reflection::CountLoaderReflection
+        super(reflection)
+      end
+    end
+  end
+
+  Base.prepend(Precount::AutosaveAssociationExtension)
+end

data/lib/active_record/precount/version.rb

@@ -1,5 +1,5 @@
 module ActiveRecord
   module Precount
-    VERSION = "0.6.1"
+    VERSION = "0.6.2"
   end
 end

data/test/cases/associations/autosave_association_bug_reproduction_test.rb

@@ -0,0 +1,26 @@
+require 'cases/helper'
+
+class AutosaveAssociationBugReproductionTest < ActiveRecord::CountLoader::TestCase
+  def setup
+    tweets_count.times do |i|
+      tweet = Tweet.create
+      i.times do |j|
+        Favorite.create(tweet: tweet, user_id: j + 1)
+      end
+    end
+  end
+
+  def teardown
+    [Tweet, Favorite].each(&:delete_all)
+  end
+
+  def tweets_count
+    3
+  end
+
+  def test_bug_with_save_belongs_to_association_method_fixed
+    tweet = Tweet.first
+    tweet.my_favorites_count
+    assert_equal(true, tweet.save!)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-precount
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - Takashi Kokubun
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-04 00:00:00.000000000 Z
+date: 2016-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -205,6 +205,7 @@ files:
 - ci/Gemfile.activerecord-5.0.x
 - ci/travis.rb
 - lib/active_record/precount.rb
+- lib/active_record/precount/autosave_association_extension.rb
 - lib/active_record/precount/base_extension.rb
 - lib/active_record/precount/collection_proxy_extension.rb
 - lib/active_record/precount/count_loader_builder.rb
@@ -278,6 +279,7 @@ files:
 - sample/public/robots.txt
 - sample/vendor/assets/javascripts/.keep
 - sample/vendor/assets/stylesheets/.keep
+- test/cases/associations/autosave_association_bug_reproduction_test.rb
 - test/cases/associations/eager_count_test.rb
 - test/cases/associations/eager_load_test.rb
 - test/cases/associations/includes_test.rb