activerecord-postgres_enum 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d34e14ab6cb6bb3067632c5ea90dfa62a9e23be88330c30cb118ffe4f70e55d
-  data.tar.gz: 7b6dd1a8dbe8e7e2b08b616ca15894eb72e2040f7f0d691f02b3452d37a08542
+  metadata.gz: 38f91da5be0b65f63986102e8c44d6d77980e3b232fa6b9abfffa8702a874f40
+  data.tar.gz: 248ad3810cca88eb9c5b1caa6de339d439d821faea6bd8377b51092483b13573
 SHA512:
-  metadata.gz: 19e8a1a1a6b55cca9ae200356c6bcff134809e1d17a3e3b37c0269a482a0f263925ae72ea467ae897133aa0d5e718536b8a693488716f45c9b1c8f5d68fa573e
-  data.tar.gz: 98cc761dec0bfa6248da5135e767d23ea54bcf36c91b604e0eee71c003f22cf79c32273a9bb3e9ec97a8afdc692389a7610665479356189484d569a2a9aa9a8c
+  metadata.gz: 3d29a3a97a34ea5c2b82f08470a5689b837be302560dda5923127bf570603574e2a0d2377ef49c8c7e93af4f7f98e5bbc7adcd8f6bcafd46b17fd71ebab9f60b
+  data.tar.gz: 253db867e758c6560b7893a09084b209e585cf53e388bf0a8a9050af8b3c38edf217364b4ee0c9c745877e2778cbd7cf7dc3ba167339b609cccc88d98dd2a6f1

data/README.md

@@ -44,13 +44,23 @@ To drop an existing enum:
 drop_enum :mood
 ```
 
+To rename an existing enum:
+
+```ruby
+rename_enum :mood, :emotions
+```
+
 To add a value into existing enum:
 
 ```ruby
-alter_enum :mood, "crazy"
+add_enum_value :mood, "crazy"
 ```
 
-Renaming / updating enums is currently not supported, since it's quite tricky.
+To rename a value:
+
+```ruby
+rename_enum_value :mood, "crazy", "nutty"
+```
 
 ## Development
 

data/lib/active_record/postgres_enum/postgresql_adapter.rb

@@ -3,6 +3,21 @@
 module ActiveRecord
   module PostgresEnum
     module PostgreSQLAdapter
+      DEFINED_ENUMS_QUERY = <<~SQL
+        SELECT t.OID, t.typname, t.typtype, array_agg(e.enumlabel) as enumlabels
+        FROM pg_type t
+        INNER JOIN pg_enum e ON e.enumtypid = t.oid
+        WHERE typtype = 'e'
+        GROUP BY t.OID, t.typname, t.typtype
+        ORDER BY t.typname
+      SQL
+
+      def enums
+        select_all(DEFINED_ENUMS_QUERY).each_with_object({}) do |row, memo|
+          memo[row["typname"].to_sym] = row['enumlabels'].gsub(/[{}]/, '').split(',')
+        end
+      end
+
       def create_enum(name, values)
         values = values.map { |v| "'#{v}'" }
         execute "CREATE TYPE #{name} AS ENUM (#{values.join(', ')})"
@@ -12,10 +27,18 @@ module ActiveRecord
         execute "DROP TYPE #{name}"
       end
 
-      def alter_enum(name, value)
+      def rename_enum(name, new_name)
+        execute "ALTER TYPE #{name} RENAME TO #{new_name}"
+      end
+
+      def add_enum_value(name, value)
         execute "ALTER TYPE #{name} ADD VALUE '#{value}'"
       end
 
+      def rename_enum_value(name, existing_value, new_value)
+        execute "ALTER TYPE #{name} RENAME VALUE '#{existing_value}' TO '#{new_value}'"
+      end
+
       def migration_keys
         super + [:enum_name]
       end

data/lib/active_record/postgres_enum/schema_dumper.rb

@@ -5,34 +5,19 @@ module ActiveRecord
     # provide support for writing out the 'create_enum' calls in schema.rb
     module SchemaDumper
       def tables(stream)
-        enums(stream)
-        super(stream)
+        dump_enums(stream)
+
+        super
       end
 
       private
 
-      def defined_enums
-        query = <<~SQL
-          SELECT t.OID, t.typname, t.typtype, array_agg(e.enumlabel) as enumlabels
-          FROM pg_type t
-          INNER JOIN pg_enum e ON e.enumtypid = t.oid
-          WHERE typtype = 'e'
-          GROUP BY t.OID, t.typname, t.typtype
-          ORDER BY t.typname
-        SQL
-
-        @connection.select_all(query).each do |enum|
-          enum['enumlabels'] = enum['enumlabels'].gsub!(/[{}]/, '').split(',')
-        end
-      end
-
-      def enums(stream)
+      def dump_enums(stream)
         statements = []
 
-        defined_enums.each do |enum|
-          enum_name = enum['typname']
-          values = enum['enumlabels'].map(&:inspect).join(', ')
-          statements << "  create_enum(#{enum_name.inspect}, [#{values}])"
+        @connection.enums.each do |name, values|
+          values = values.map(&:inspect).join(', ')
+          statements << "  create_enum('#{name}', [#{values}])"
         end
 
         stream.puts statements.join("\n")

data/lib/active_record/postgres_enum/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module PostgresEnum
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,29 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-postgres_enum
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Michael Merkushin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-30 00:00:00.000000000 Z
+date: 2018-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.0
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.2.0
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -38,6 +44,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '1'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.16'
+- !ruby/object:Gem::Dependency
+  name: combustion
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +128,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement