activerecord-pedantmysql2-adapter 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36d70ac399667562de94a24e296acf7354654757
-  data.tar.gz: f12af9c6d3ba61df645847680497c2de2488ad0c
+  metadata.gz: df26d0bd1e7762f5394a6bbb0268f3c450c3802e
+  data.tar.gz: 0b3b997d9687a4bbad0b0b672e06406a6902c63e
 SHA512:
-  metadata.gz: 35e62a5b6e66e8fe9a9ac3df96ec428701b2623cda9874a073e3950e5f50169493412f13f73391561a53ec68e652bea45f1e83f664ba0752aee3ad4e6bf304ef
-  data.tar.gz: 4ef14253e3b99caaabc619f95f0814bcad7ddfa9b6cc0d39a138695cac73b8a6bf3a8a3f2c5eff148b1b2a2ff2c5f46af25c08c3d82202c8aa44815b9d3a6827
+  metadata.gz: ce22c43b5e38358782c96c0ae9989b07e20e395a1d821c7605a374cb9d507c8c136d085b00debb66080e7a18b6697ead0513125b8c16212681ae5b7de434b205
+  data.tar.gz: 90c27520d20f79dc3b1a7ec97fce529fe85915414ebe14c823064edf040140340662e10b8e6507c7bed4780427b52afe11f520c97cd2a3ac14922e49fd4e0be8

data/.travis.yml

@@ -0,0 +1,7 @@
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.2
+
+before_script:
+  - mysql -e 'create database pedant_mysql2_test;'

data/README.md

@@ -1,5 +1,11 @@
 # Activerecord::PedantMysql2
 
+[![Build Status](https://secure.travis-ci.org/Shopify/activerecord-pedantmysql2-adapter.png)](http://travis-ci.org/Shopify/activerecord-pedantmysql2-adapter)
+[![Code Climate](https://codeclimate.com/github/Shopify/activerecord-pedantmysql2-adapter.png)](https://codeclimate.com/github/Shopify/activerecord-pedantmysql2-adapter)
+[![Coverage Status](https://coveralls.io/repos/Shopify/activerecord-pedantmysql2-adapter/badge.png)](https://coveralls.io/r/Shopify/activerecord-pedantmysql2-adapter)
+[![Gem Version](https://badge.fury.io/rb/activerecord-pedantmysql2-adapter.png)](http://badge.fury.io/rb/activerecord-pedantmysql2-adapter)
+
+
 ActiveRecord adapter for MySQL that report warnings.
 
 The main usage is to progressively identify and fix MySQL warnings generated by legacy rails applications, and ultimately enable strict mode. 
@@ -51,7 +57,7 @@ end
 
 ## Contributing
 
-1. Fork it ( http://github.com/<my-github-username>/activerecord-pedantmysql2-adapter/fork )
+1. Fork it ( http://github.com/Shopify/activerecord-pedantmysql2-adapter/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/Rakefile

@@ -1 +1,6 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/activerecord-pedantmysql2-adapter.gemspec

@@ -22,4 +22,6 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'mysql2', '>= 0.3.11'
   spec.add_development_dependency 'bundler', '~> 1.5'
   spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'coveralls'
 end

data/lib/active_record/connection_adapters/pedant_mysql2_adapter.rb

@@ -39,12 +39,23 @@ end
 
 class ActiveRecord::ConnectionAdapters::PedantMysql2Adapter < ActiveRecord::ConnectionAdapters::Mysql2Adapter
 
+  alias_method :original_execute, :execute
+
   def execute(sql, name = nil)
     value = super
     log_warnings(sql)
     value
   end
 
+  def exec_delete(sql, name, binds)
+    original_execute to_sql(sql, binds), name
+    affected_rows = @connection.affected_rows
+    log_warnings(sql)
+    affected_rows
+  end
+
+  alias :exec_update :exec_delete
+
   private
 
   def log_warnings(sql)

data/lib/pedant_mysql2/version.rb

@@ -1,3 +1,3 @@
 module PedantMysql2
-  VERSION = "0.0.2"
+  VERSION = '0.0.3'
 end

data/shipit.rubygems.yml

@@ -0,0 +1 @@
+# using the default shipit config

data/spec/adapter_spec.rb

@@ -5,6 +5,9 @@ describe PedantMysql2 do
   let(:connection) { ActiveRecord::Base.connection }
 
   before :each do
+    connection.execute('SET SESSION binlog_format = "STATEMENT"')
+    connection.execute('CREATE TABLE IF NOT EXISTS comment (id int)')
+    connection.execute('TRUNCATE TABLE comment')
     @original_callback = PedantMysql2.on_warning
   end
 
@@ -23,6 +26,16 @@ describe PedantMysql2 do
     expect(result.to_a).to be == [[1.0]]
   end
 
+  it 'do not change the returned value of exec_update' do
+    result = connection.update('UPDATE comment SET id = 1 LIMIT 1')
+    expect(result).to be_zero
+  end
+
+  it 'do not change the returned value of exec_delete' do
+    result = connection.delete('DELETE FROM comment LIMIT 1')
+    expect(result).to be_zero
+  end
+
   it 'can easily be raised' do
     PedantMysql2.on_warning = lambda { |warning| raise warning }
     expect {

data/spec/spec_helper.rb

@@ -1,5 +1,14 @@
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+
+require 'simplecov'
+require 'coveralls'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start
+
 require 'activerecord-pedantmysql2-adapter'
 
 Dir[File.expand_path(File.join(File.dirname(__FILE__), 'support', '**', '*.rb'))].each { |f| require f }

data/spec/support/database.rb

@@ -2,9 +2,7 @@ ActiveRecord::Base.configurations = {
   'test' => {
     adapter: 'pedant_mysql2',
     database: 'pedant_mysql2_test',
-    username: nil,
-    port: '13306',
-    host: '127.0.0.1',
+    username: 'travis',
     encoding: 'utf8',
     strict: false,
   },

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-pedantmysql2-adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-20 00:00:00.000000000 Z
+date: 2014-05-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -66,6 +66,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Gives a hook on MySQL warnings that allow you to either raise or log
   them.
 email:
@@ -76,6 +104,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -85,6 +114,7 @@ files:
 - lib/activerecord-pedantmysql2-adapter.rb
 - lib/pedant_mysql2.rb
 - lib/pedant_mysql2/version.rb
+- shipit.rubygems.yml
 - spec/adapter_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.rb