activerecord-originator 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa3749b460f4bf88f4ae707b69db1e2c32f41d7bfac6780ebafbc4e96375a730
-  data.tar.gz: b130e6f429f7cd6acc167715a08797f9816f16d06fa990fc1ddda22c4d17700b
+  metadata.gz: 3d49cfc8d3525d43a35a9a6402ed9c49bb0a358eb3431037b4a950e6de6f8410
+  data.tar.gz: 3b346c2bd9f844d283a1b188638cddca0fb8c735e3deec856db820affca33210
 SHA512:
-  metadata.gz: 30ce59ca0d48a39793d27a959db9a93dff186006ac83bb4fe220469cde766ac7627c9fe1e0b9f429ecb16e339481f95dbbc39ad7d656d82b1875ef88281f4216
-  data.tar.gz: c502f0bf40254b8d92484e4a9fa5e5bdc20eb28a096e4a265fb94616dcca7f3ce4dc6f37e9c2e9a740666f4aeac31e68886fcd50ceb16797c43abd46506480fd
+  metadata.gz: 261187b6b1048e29a61f8bae368f92e99d96f121df8a59c9ab2440900856cdb275cefd093d327b6953fc15c8e8c1cd04a7df7a9a4801c3d4c1498ed27aaf62db
+  data.tar.gz: 851b7be3ef5d544f86020c36d1a7ba2548cfd58af4d234a27c424a9b087404b199f1f2a5f41dd3b1e77510a531073e9f4fefd8855ecdceb656acf586d8f4c85e

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# CHANGELOG
+
+## v0.2.0 - 2024-03-16
+
+* Avoid modifying unnecessary nodes for performance. [#15](https://github.com/pocke/activerecord-originator/pull/15)
+
+## v0.1.0 - 2024-03-13
+
+* The first release!

data/Rakefile

@@ -14,3 +14,28 @@ task :steep do
 end
 
 task default: %i[rubocop steep spec]
+
+namespace :benchmark do
+  task :to_sql do
+    puts "# Benchmarking #to_sql mehtod"
+    puts
+    puts "## Wihtout AR::Originator"
+    sh 'ruby', 'benchmark/to_sql.rb'
+
+    puts
+    puts "## With AR::Originator"
+    sh 'ruby', '-r', 'activerecord/originator', 'benchmark/to_sql.rb'
+  end
+
+  task :select_query do
+    puts "# Benchmarking SELECT Query"
+    puts
+    puts "## Wihtout AR::Originator"
+    sh 'ruby', 'benchmark/select_query.rb'
+
+    puts
+    puts "## With AR::Originator"
+    sh 'ruby', '-r', 'activerecord/originator', 'benchmark/select_query.rb'
+  end
+end
+task benchmark: %i[benchmark:to_sql benchmark:select_query]

data/lib/activerecord/originator/arel_visitor_extension.rb

@@ -3,13 +3,7 @@
 module ActiveRecord
   module Originator
     module ArelVisitorExtension
-      def accept(object, collector)
-        super(object, CollectorProxy.new(collector))
-      end
-
-      private
-
-      %i[
+      TARGET_NODE_CLASSESS = %i[
         Ascending
         Descending
         Equality
@@ -21,7 +15,15 @@ module ActiveRecord
         LessThan
         LessThanOrEqual
         GreaterThanOrEqual
-      ].each do |klass_name|
+      ]
+
+      def accept(object, collector)
+        super(object, CollectorProxy.new(collector))
+      end
+
+      private
+
+      TARGET_NODE_CLASSESS.each do |klass_name|
         define_method(:"visit_Arel_Nodes_#{klass_name}") do |o, collector|
           __skip__ = begin
             comment = originator_comment(o)

data/lib/activerecord/originator/version.rb

@@ -2,6 +2,6 @@
 
 module ActiveRecord
   module Originator
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/lib/activerecord/originator.rb

@@ -10,7 +10,13 @@ require_relative "originator/arel_node_extension"
 require_relative "originator/arel_visitor_extension"
 require_relative "originator/collector_proxy"
 
-Arel::Nodes::Node.descendants.each do |klass|
+ActiveRecord::Originator::ArelVisitorExtension::TARGET_NODE_CLASSESS.each do |name|
+  begin
+    klass = Arel::Nodes.const_get(name)
+  rescue NameError
+    # Some classes are not defined in old arel
+    next
+  end
   klass.prepend ActiveRecord::Originator::ArelNodeExtension
 end
 Arel::Visitors::ToSql.prepend ActiveRecord::Originator::ArelVisitorExtension

data/sig/activerecord/originator/arel_visitor_extension.rbs

@@ -1,6 +1,7 @@
 module ActiveRecord
   module Originator
     module ArelVisitorExtension : _ArelVisitor
+      TARGET_NODE_CLASSESS: Array[Symbol]
       def accept: (untyped object, _Collector collector) -> untyped
 
       private

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-originator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Masataka Pocke Kuwabara
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-13 00:00:00.000000000 Z
+date: 2024-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -48,6 +48,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- CHANGELOG.md
 - LICENSE
 - README.md
 - Rakefile