activerecord-oracle_enhanced-adapter 7.1.0 → 7.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c54d072a9a65f5b91b230da739c0b2f117d397813b9f2dfb0ca56c13da00979
-  data.tar.gz: 0b4e805aff8d23258dda658e70a87494cb93d6da7b5e0024bd74a3807f54295e
+  metadata.gz: acf9205c3bd6ee30bd105a8166789a7f7aa34ce9699405bfc8b174c016c55113
+  data.tar.gz: 3716edcbc87b8a8ecd55cb556706637cd038b7a10084235852fe91615c4ba6b2
 SHA512:
-  metadata.gz: 72464c92eb71576aae495a2e93674d6823e1a2967f7f8bc45116d14dfbe8f29291c71b7f122e83c74698834be25e729bfddc0b64baf23de7e1b26044960faf26
-  data.tar.gz: 165de73dc654f318d7dc3042ae10f669047733255decd38f9abb2c3db3522bbb6f4c471db44a1ffe40ebaab05b400f9cd2eede381ea1018ea28217529a1c7610
+  metadata.gz: 0a2a11722e534f9079995f462879d2592fc0df483e833dc4765f3df7c2fec0345a823cf2390b60a60a7c056ee31c503088fcf0342eeb02fa1e233c162926924b
+  data.tar.gz: 6c7a89267b1f9747c7bed9251f0d234eaaa1825be8d5efdf93566906c49d0258cd94a94354732b3381df195527b37a7d0fcf575b4ca4b46de6784cc6dd86cbfc

data/History.md

@@ -1,3 +1,11 @@
+## 7.1.1 / 2025-06-16
+
+* Changes and bug fixes
+  * Address `add_timestamps` error [#2417, #2438]
+  * Address `rename_table` ArgumentError [#2418, #2437]
+  * Update `reconnect!` method signature [#2433, #2436]
+  * Update README.md to support status of Rails 7.1 [#2408, #2409]
+
 ## 7.1.0 / 2024-09-25
 
 * Changes and bug fixes

data/README.md

@@ -6,10 +6,20 @@ Oracle enhanced adapter for ActiveRecord
 DESCRIPTION
 -----------
 
-Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions between 2.3.x and 7.0 and it is working with Oracle database versions 10g and higher
+Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions between 2.3.x and 7.1 and it is working with Oracle database versions 10g and higher
 
 INSTALLATION
 ------------
+### Rails 7.1
+
+Oracle enhanced adapter version 7.1 supports Rails 7.1
+When using Ruby on Rails version 7.1 then in Gemfile include
+
+```ruby
+# Use oracle as the database for Active Record
+gem 'activerecord-oracle_enhanced-adapter', '~> 7.1.0'
+```
+
 ### Rails 7.0
 
 Oracle enhanced adapter version 7.0 supports Rails 7.0

data/VERSION

@@ -1 +1 @@
-7.1.0
+7.1.1

data/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -252,7 +252,7 @@ module ActiveRecord
           rebuild_primary_key_index_to_default_tablespace(table_name, options)
         end
 
-        def rename_table(table_name, new_name) # :nodoc:
+        def rename_table(table_name, new_name, **options) # :nodoc:
           if new_name.to_s.length > DatabaseLimits::IDENTIFIER_MAX_LENGTH
             raise ArgumentError, "New table name '#{new_name}' is too long; the limit is #{DatabaseLimits::IDENTIFIER_MAX_LENGTH} characters"
           end
@@ -261,7 +261,7 @@ module ActiveRecord
           execute "RENAME #{quote_table_name(table_name)} TO #{quote_table_name(new_name)}"
           execute "RENAME #{quote_table_name("#{table_name}_seq")} TO #{default_sequence_name(new_name)}" rescue nil
 
-          rename_table_indexes(table_name, new_name)
+          rename_table_indexes(table_name, new_name, **options)
         end
 
         def drop_table(table_name, **options) # :nodoc:
@@ -622,6 +622,13 @@ module ActiveRecord
           OracleEnhanced::AlterTable.new create_table_definition(name)
         end
 
+        def add_timestamps(table_name, **options)
+          fragments = add_timestamps_for_alter(table_name, **options)
+          fragments.each do |fragment|
+            execute "ALTER TABLE #{quote_table_name(table_name)} #{fragment}"
+          end
+        end
+
         def update_table_definition(table_name, base)
           OracleEnhanced::Table.new(table_name, base)
         end

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -467,7 +467,7 @@ module ActiveRecord
       end
 
       # Reconnects to the database.
-      def reconnect! # :nodoc:
+      def reconnect!(restore_transactions: false) # :nodoc:
         super
         _connection.reset!
       rescue OracleEnhanced::ConnectionException => e

data/spec/active_record/connection_adapters/oracle_enhanced/compatibility_spec.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+describe "compatibility migrations" do
+  include SchemaSpecHelper
+
+  before(:all) do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    @conn = ActiveRecord::Base.connection
+    schema_define do
+      create_table :test_employees, force: true
+    end
+  end
+
+  after(:all) do
+    schema_define do
+      drop_table :test_employees, if_exists: true
+      drop_table :new_test_employees, if_exists: true
+    end
+  end
+
+  it "should rename table on 7_0 and below" do
+    migration = Class.new(ActiveRecord::Migration[7.0]) {
+      def change
+        rename_table :test_employees, :new_test_employees
+      end
+    }.new
+
+    migration.migrate(:up)
+    expect(@conn.table_exists?(:new_test_employees)).to be_truthy
+    expect(@conn.table_exists?(:test_employees)).not_to be_truthy
+
+    migration.migrate(:down)
+    expect(@conn.table_exists?(:new_test_employees)).not_to be_truthy
+    expect(@conn.table_exists?(:test_employees)).to be_truthy
+  end
+end

data/spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb

@@ -30,6 +30,12 @@ describe "OracleEnhancedAdapter establish connection" do
     expect(ActiveRecord::Base.connection).to be_active
   end
 
+  it "should be active after reconnection to database with restore_transactions: true" do
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    ActiveRecord::Base.connection.reconnect!(restore_transactions: true)
+    expect(ActiveRecord::Base.connection).to be_active
+  end
+
   it "should use database default cursor_sharing parameter value force by default" do
     # Use `SYSTEM_CONNECTION_PARAMS` to query v$parameter
     ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS)

data/spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb

@@ -387,6 +387,34 @@ describe "OracleEnhancedAdapter schema definition" do
   end
 end
 
+  describe "add timestamps" do
+    before(:each) do
+      @conn = ActiveRecord::Base.connection
+      schema_define do
+        create_table :test_employees, force: true
+      end
+      class ::TestEmployee < ActiveRecord::Base; end
+    end
+
+    after(:each) do
+      schema_define do
+        drop_table :test_employees, if_exists: true
+      end
+      Object.send(:remove_const, "TestEmployee")
+      ActiveRecord::Base.clear_cache!
+    end
+
+    it "should add created_at and updated_at" do
+      expect do
+        @conn.add_timestamps("test_employees")
+      end.not_to raise_error
+
+      TestEmployee.reset_column_information
+      expect(TestEmployee.columns_hash["created_at"]).not_to be_nil
+      expect(TestEmployee.columns_hash["updated_at"]).not_to be_nil
+    end
+  end
+
   describe "ignore options for LOB columns" do
     after(:each) do
       schema_define do

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 7.1.0
+  version: 7.1.1
 platform: ruby
 authors:
 - Raimonds Simanovskis
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-25 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -104,6 +103,7 @@ files:
 - lib/arel/visitors/oracle12.rb
 - lib/arel/visitors/oracle_common.rb
 - spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/compatibility_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
@@ -139,7 +139,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -154,12 +153,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.8.11
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
 - spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/compatibility_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb