activerecord-oracle_enhanced-adapter 5.2.2 → 5.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 192b152e571ea28d6e195b9245c3bfc6ee331254a1c55bb6d7605d5da9a50b91
-  data.tar.gz: a954652613d0ce95d24a75bc5b6784fe2750d25e37fc26448017c1c290246df0
+  metadata.gz: 99ba62aedd6e50d8e73857481e9571fe6d32bcf54e63ad71efb585a41ee46de3
+  data.tar.gz: a328430116e7ff784117e6281e6ed7be5bc3df51ea9425d49cf3304bc0730ccf
 SHA512:
-  metadata.gz: 04cee9773aab325fcaf71454ad982538a8940846e5b9780422f1836ff7089a20d5a9e0e8439ed7ca7770ecb956701b7b05a56ecb46a6ef7d7742306926b4fe6e
-  data.tar.gz: 1cee77e92e6f81f4c0f93c610cb6b0436ebf39a97dd14411633295b830878cb3de485e2220a15120b7fd8826d4caf1e094662d354696de83a3beff26c865ec97
+  metadata.gz: ec5c2229cc8ec228ae600373f107a4dd325913c7940f9668462148bda65380818ee7ac5eaf369e042c54cda30c44ad1934cd9aa0429a783c2c723869c036066b
+  data.tar.gz: 566e26dc8d096883fff8409fce90160706e1ae18f4e4779cd2f83ff58657f2a91f2e93ad552068717d242af38ed70403264b6b6bf1d87b7d354bf7c61f5309d9

data/History.md

@@ -1,3 +1,15 @@
+## 5.2.3 / 2018-08-08
+
+* Changes and bug fixes
+  * Introduce column cache per connection [#1744 #1750]
+  * Use `cursor_sharing` = force by default again [#1745 #1748]
+  * Add `table_name` search condition to `indexes(table_name)` method [#1747 #1749]
+  * Suppress warning `BigDecimal.new` is deprecated [#1742 #1743]
+  * Do not install bundler explicitly [#1725 #1726]
+  * Add `allow_railures` for jruby-head until #1737 resolved [#1739 #1740]
+  * CI against JRuby 9.2.0.0 [#1728 #1741]
+  * Do not run CI against older version of JRuby [#1741]
+
 ## 5.2.2 / 2018-04-28
 
 * Changes and bug fixes

data/VERSION

@@ -1 +1 @@
-5.2.2
+5.2.3

data/lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb

@@ -150,7 +150,7 @@ module ActiveRecord
             # @raw_connection.setDefaultRowPrefetch(prefetch_rows) if prefetch_rows
           end
 
-          cursor_sharing = config[:cursor_sharing]
+          cursor_sharing = config[:cursor_sharing] || "force"
           exec "alter session set cursor_sharing = #{cursor_sharing}" if cursor_sharing
 
           # Initialize NLS parameters
@@ -476,7 +476,7 @@ module ActiveRecord
             elsif d.isInt
               Integer(d.stringValue)
             else
-              BigDecimal.new(d.stringValue)
+              BigDecimal(d.stringValue)
             end
           when :BINARY_FLOAT
             rset.getFloat(i)

data/lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb

@@ -124,7 +124,7 @@ module ActiveRecord
             when Type::OracleEnhanced::Raw
               @raw_cursor.bind_param(position, OracleEnhanced::Quoting.encode_raw(value))
             when ActiveModel::Type::Decimal
-              @raw_cursor.bind_param(position, BigDecimal.new(value.to_s))
+              @raw_cursor.bind_param(position, BigDecimal(value.to_s))
             when NilClass
               @raw_cursor.bind_param(position, nil, String)
             else
@@ -295,7 +295,7 @@ module ActiveRecord
           privilege = config[:privilege] && config[:privilege].to_sym
           async = config[:allow_concurrency]
           prefetch_rows = config[:prefetch_rows] || 100
-          cursor_sharing = config[:cursor_sharing]
+          cursor_sharing = config[:cursor_sharing] || "force"
           # get session time_zone from configuration or from TZ environment variable
           time_zone = config[:time_zone] || ENV["TZ"]
 

data/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -83,7 +83,7 @@ module ActiveRecord
           (owner, table_name, db_link) = @connection.describe(table_name)
           default_tablespace_name = default_tablespace
 
-          result = select_all(<<-SQL.strip.gsub(/\s+/, " "), "indexes", [bind_string("owner", owner), bind_string("owner", owner)])
+          result = select_all(<<-SQL.strip.gsub(/\s+/, " "), "indexes", [bind_string("owner", owner), bind_string("owner", owner), bind_string("table_name", table_name)])
             SELECT LOWER(i.table_name) AS table_name, LOWER(i.index_name) AS index_name, i.uniqueness,
               i.index_type, i.ityp_owner, i.ityp_name, i.parameters,
               LOWER(i.tablespace_name) AS tablespace_name,
@@ -97,6 +97,7 @@ module ActiveRecord
                 c.column_name = atc.column_name AND i.owner = atc.owner AND atc.hidden_column = 'NO'
             WHERE i.owner = :owner
                AND i.table_owner = :owner
+               AND i.table_name = :table_name
                AND NOT EXISTS (SELECT uc.index_name FROM all_constraints uc
                 WHERE uc.index_name = i.index_name AND uc.owner = i.owner AND uc.constraint_type = 'P')
             ORDER BY i.index_name, c.column_position
@@ -152,6 +153,14 @@ module ActiveRecord
           all_schema_indexes.select { |i| i.table == table_name }
         end
 
+        def columns(table_name)
+          table_name = table_name.to_s
+          if @columns_cache[table_name]
+            @columns_cache[table_name]
+          else
+            @columns_cache[table_name] = super(table_name)
+          end
+        end
         # Additional options for +create_table+ method in migration files.
         #
         # You can specify individual starting value in table creation migration file, e.g.:
@@ -248,6 +257,8 @@ module ActiveRecord
           execute "DROP SEQUENCE #{quote_table_name(seq_name)}" rescue nil
         rescue ActiveRecord::StatementInvalid => e
           raise e unless options[:if_exists]
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def insert_versions_sql(versions) # :nodoc:
@@ -398,6 +409,8 @@ module ActiveRecord
           execute add_column_sql
           create_sequence_and_trigger(table_name, options) if type && type.to_sym == :primary_key
           change_column_comment(table_name, column_name, options[:comment]) if options.key?(:comment)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def aliased_types(name, fallback)
@@ -407,6 +420,8 @@ module ActiveRecord
         def change_column_default(table_name, column_name, default_or_changes) #:nodoc:
           default = extract_new_default_value(default_or_changes)
           execute "ALTER TABLE #{quote_table_name(table_name)} MODIFY #{quote_column_name(column_name)} DEFAULT #{quote(default)}"
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def change_column_null(table_name, column_name, null, default = nil) #:nodoc:
@@ -439,15 +454,21 @@ module ActiveRecord
           execute(change_column_sql)
 
           change_column_comment(table_name, column_name, options[:comment]) if options.key?(:comment)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def rename_column(table_name, column_name, new_column_name) #:nodoc:
           execute "ALTER TABLE #{quote_table_name(table_name)} RENAME COLUMN #{quote_column_name(column_name)} to #{quote_column_name(new_column_name)}"
           rename_column_indexes(table_name, column_name, new_column_name)
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def remove_column(table_name, column_name, type = nil, options = {}) #:nodoc:
           execute "ALTER TABLE #{quote_table_name(table_name)} DROP COLUMN #{quote_column_name(column_name)} CASCADE CONSTRAINTS"
+        ensure
+          clear_table_columns_cache(table_name)
         end
 
         def change_table_comment(table_name, comment)

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -213,6 +213,7 @@ module ActiveRecord
         @statements = StatementPool.new(self.class.type_cast_config_to_integer(config[:statement_limit]))
         @enable_dbms_output = false
         @do_not_prefetch_primary_key = {}
+        @columns_cache = {}
       end
 
       ADAPTER_NAME = "OracleEnhanced".freeze
@@ -541,6 +542,10 @@ module ActiveRecord
         SQL
       end
 
+      def clear_table_columns_cache(table_name)
+        @columns_cache[table_name.to_s] = nil
+      end
+
       # Find a table's primary key and sequence.
       # *Note*: Only primary key is implemented - sequence will be nil.
       def pk_and_sequence_for(table_name, owner = nil, desc_table_name = nil, db_link = nil) #:nodoc:

data/spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb

@@ -31,15 +31,15 @@ describe "OracleEnhancedAdapter establish connection" do
     expect(ActiveRecord::Base.connection).to be_active
   end
 
-  it "should use database default cursor_sharing parameter value exact by default" do
+  it "should use database default cursor_sharing parameter value force by default" do
     # Use `SYSTEM_CONNECTION_PARAMS` to query v$parameter
     ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS)
-    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("EXACT")
+    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("FORCE")
   end
 
-  it "should use modified cursor_sharing value force" do
-    ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(cursor_sharing: :force))
-    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("FORCE")
+  it "should use modified cursor_sharing value exact" do
+    ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS.merge(cursor_sharing: :exact))
+    expect(ActiveRecord::Base.connection.select_value("select value from v$parameter where name = 'cursor_sharing'")).to eq("EXACT")
   end
 end
 

data/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb

@@ -67,15 +67,16 @@ describe "OracleEnhancedAdapter" do
       end
 
       it "should get columns from database at first time" do
+        @conn.clear_table_columns_cache(:test_employees)
         expect(TestEmployee.connection.columns("test_employees").map(&:name)).to eq(@column_names)
         expect(@logger.logged(:debug).last).to match(/select .* from all_tab_cols/im)
       end
 
-      it "should get columns from database at second time" do
+      it "should not get columns from database at second time" do
         TestEmployee.connection.columns("test_employees")
         @logger.clear(:debug)
         expect(TestEmployee.connection.columns("test_employees").map(&:name)).to eq(@column_names)
-        expect(@logger.logged(:debug).last).to match(/select .* from all_tab_cols/im)
+        expect(@logger.logged(:debug).last).not_to match(/select .* from all_tab_cols/im)
       end
 
       it "should get primary key from database at first time" do
@@ -137,6 +138,7 @@ describe "OracleEnhancedAdapter" do
       @conn.execute "DROP DATABASE LINK #{@db_link}" rescue nil
       @sys_conn.drop_table :test_posts, if_exists: true
       Object.send(:remove_const, "TestPost") rescue nil
+      @conn.clear_table_columns_cache(:test_posts)
       ActiveRecord::Base.clear_cache!
     end
 
@@ -532,7 +534,7 @@ describe "OracleEnhancedAdapter" do
     it "should return array from indexes with bind usage" do
       expect(@conn.indexes("TEST_POSTS").class).to eq Array
       expect(@logger.logged(:debug).last).to match(/:owner/)
-      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["owner", "#{DATABASE_USER.upcase}"\]\]/)
+      expect(@logger.logged(:debug).last).to match(/\[\["owner", "#{DATABASE_USER.upcase}"\], \["owner", "#{DATABASE_USER.upcase}"\], \["table_name", "TEST_POSTS"\]\]/)
     end
 
     it "should not have primary key trigger with bind usage" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 5.2.2
+  version: 5.2.3
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-27 00:00:00.000000000 Z
+date: 2018-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -139,31 +139,31 @@ signing_key:
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
-- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
+- spec/support/alter_system_set_open_cursors.sql
+- spec/support/alter_system_user_password.sql
+- spec/support/create_oracle_enhanced_users.sql
+- spec/spec_config.yaml.template
 - spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
+- spec/active_record/connection_adapters/emulation/oracle_adapter_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/structure_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/schema_dumper_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/database_tasks_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/schema_statements_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/procedures_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced/dbms_output_spec.rb
-- spec/active_record/oracle_enhanced/type/integer_spec.rb
-- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
 - spec/active_record/oracle_enhanced/type/timestamp_spec.rb
+- spec/active_record/oracle_enhanced/type/boolean_spec.rb
+- spec/active_record/oracle_enhanced/type/float_spec.rb
 - spec/active_record/oracle_enhanced/type/binary_spec.rb
 - spec/active_record/oracle_enhanced/type/national_character_string_spec.rb
+- spec/active_record/oracle_enhanced/type/integer_spec.rb
 - spec/active_record/oracle_enhanced/type/raw_spec.rb
-- spec/active_record/oracle_enhanced/type/float_spec.rb
-- spec/active_record/oracle_enhanced/type/dirty_spec.rb
 - spec/active_record/oracle_enhanced/type/json_spec.rb
+- spec/active_record/oracle_enhanced/type/national_character_text_spec.rb
+- spec/active_record/oracle_enhanced/type/dirty_spec.rb
 - spec/active_record/oracle_enhanced/type/text_spec.rb
-- spec/active_record/oracle_enhanced/type/boolean_spec.rb
-- spec/spec_config.yaml.template
 - spec/spec_helper.rb
-- spec/support/create_oracle_enhanced_users.sql
-- spec/support/alter_system_user_password.sql
-- spec/support/alter_system_set_open_cursors.sql