activerecord-oracle_enhanced-adapter 5.2.0 → 5.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5c56a2903f50e1f4d29ebce73f1d3ecfb8ccc20fdff51530358068c99e74182
-  data.tar.gz: 1230afe509076a53d1f797ccbdba4d74b29647fdc263f60849d1ae34145e6116
+  metadata.gz: fa2bc4f36243959ebbe43179acbb417a7ee8c3256efa3a743b4fcdf6ceb35a42
+  data.tar.gz: 16d9bacff337f6634fb5d72e0d13f65dfc9b727ac95f757d3be1484ad6f66e2a
 SHA512:
-  metadata.gz: ba4c22c74b3da5cd8768681df7c57aa0b07d1037d13efeecd3588a3487543f79b2d0eea2e7c0fe7fd947aa66d0f339c39ff263bf680831b603c74052fa38e990
-  data.tar.gz: cc928edfef4189c8ce3ed0e1d1643b2b13369ef052467b21fa7223c03d4a31925b45572e3d60e2ec3b108d12365d601f3e17884eda599586cd869789841c4895
+  metadata.gz: 625e0fc67e187b681867359d4576491bbbf2eb14c70f4c455bfa926713aaed6bf1e452acf7a3806f05297eccd444326368c390be170033f0013758cd5c2538e9
+  data.tar.gz: 197b8c4ef15c5458e67d1a530ebfce8fa8b2a97f0ccad2037729d59cf6fd867f828303a07d6eef475b60afb4fc83d302fd29aa0f67387657cea441429789d2ab

data/History.md

@@ -1,3 +1,8 @@
+## 5.2.1 / 2018-04-15
+
+* Changes and bug fixes
+  * Memoize if the table needs to prefetch primary key[#1673 #1699 #1700]
+
 ## 5.2.0 / 2018-04-10
 
 * Major changes and fixes

data/VERSION

@@ -1 +1 @@
-5.2.0
+5.2.1

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -212,6 +212,7 @@ module ActiveRecord
         super(connection, logger, config)
         @statements = StatementPool.new(self.class.type_cast_config_to_integer(config[:statement_limit]))
         @enable_dbms_output = false
+        @do_not_prefetch_primary_key = {}
       end
 
       ADAPTER_NAME = "OracleEnhanced".freeze
@@ -427,8 +428,11 @@ module ActiveRecord
       def prefetch_primary_key?(table_name = nil)
         return true if table_name.nil?
         table_name = table_name.to_s
-        owner, desc_table_name, db_link = @connection.describe(table_name)
-        do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name, db_link) || has_primary_key_trigger?(table_name, owner, desc_table_name, db_link)
+        do_not_prefetch = @do_not_prefetch_primary_key[table_name]
+        if do_not_prefetch.nil?
+          owner, desc_table_name, db_link = @connection.describe(table_name)
+          @do_not_prefetch_primary_key [table_name] = do_not_prefetch = !has_primary_key?(table_name, owner, desc_table_name, db_link) || has_primary_key_trigger?(table_name, owner, desc_table_name, db_link)
+        end
         !do_not_prefetch
       end
 

data/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb

@@ -96,6 +96,14 @@ describe "OracleEnhancedAdapter" do
           expect(TestEmployee2.columns.map(&:sql_type)).to eq(@column_sql_types)
         end
       end
+
+      it "should get sequence value at next time" do
+        TestEmployee.create!
+        expect(@logger.logged(:debug).first).not_to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im)
+        @logger.clear(:debug)
+        TestEmployee.create!
+        expect(@logger.logged(:debug).first).to match(/SELECT \"TEST_EMPLOYEES_SEQ\".NEXTVAL FROM dual/im)
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.2.1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-09 00:00:00.000000000 Z
+date: 2018-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord