activerecord-oracle_enhanced-adapter 1.8.1 → 1.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62f1ee327be10ea29cf50ada1a4b147d356d49ae
-  data.tar.gz: 3cea1f10aab9bc54e73ea4f194b28de3b87c0ea6
+  metadata.gz: 955c1c3d11ce8928038c4f64681234c4cf7ad304
+  data.tar.gz: c08040c3b024d62a76653409df2cda7e723a7ce6
 SHA512:
-  metadata.gz: 06c2cfe4b5791964e005cae994f9897bfd3ab874b42b3626cb077636acaf2284489a8902624cc8e11556e7259d3d7b5dd66e882b970216b3d1ba602b6f4bda95
-  data.tar.gz: af0ffb2979e1b3138f9ee58c28ea5c07850b3ee06fb28a6bfe9834fe4352e9aa651dc180d593e69b99adfee8e8605108cf0581d6f95bbc21d437213dabfb3573
+  metadata.gz: 758ddc44a6c42afe6a160142c5d6d489bb5c4f240333d1ce715e7434f4da57240a46f84207b1160fe831bd0489a76e23e21cea4515b159bc01ade69379cc1620
+  data.tar.gz: a95939add8ff9aebaf535aeb4d293f0466dcde14479e0ccf4fdbdcf54f37b23e34924f793b54975dc06e0e0e24ec24406b441a6106a071946f7dcf25bd4fb04c

data/History.md

@@ -1,3 +1,18 @@
+## 1.8.2 / 2017-08-24
+
+* Changes and bug fixes
+  * Fix cursor leak when using activerecord-import gem [#1409, #1433]
+  * Mention new statement_limit default [#1364, #1365]
+  * Add upgrade section for `:statement_limit` value at Rails 5.1 [#1362, #1363]
+  * Set `disk_asynch_io` to `false` [#1413, #1414]
+  * Update README.md [#1367 #1368]
+  * CI against JRuby 9.1.12.0 [#1359, #1360]
+  * Bump ruby versions [#1346]
+  * rubocop namespace changes from `Style` to `Layout` [#1347, #1351]
+
+* Changes and bug fixes
+  * No changes since 1.8.0.rc3
+
 ## 1.8.1 / 2017-05-11
 
 * Changes and bug fixes
@@ -46,7 +61,7 @@
 * Changes and bug fixes
   * Eliminate a redundant empty lines in schema.rb generated by SchemaDumper [#1232]
   * Align the columns of db/structure.sql [#1242]
-  * Use Abstract StatementPool [#1228]
+  * Use Abstract StatementPool (new `statement_limit` default is 1000 was 250) [#1228]
   * Decouple Composite Primary Key code [#1224, #1225]
   * Push `valid_type?` up to abstract adapter [#1208]
   * Oracle12 visitor is also available for 12.2 [#1217]

data/README.md

@@ -6,7 +6,7 @@ Oracle enhanced adapter for ActiveRecord
 DESCRIPTION
 -----------
 
-Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions between 2.3.x and 5.0 and it is working with Oracle database versions from 10g to 12c.
+Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby on Rails applications. Oracle enhanced adapter can be used from Ruby on Rails versions between 2.3.x and 5.1 and it is working with Oracle database versions from 10g to 12c.
 
 INSTALLATION
 ------------
@@ -641,6 +641,31 @@ development:
 
 UPGRADE
 ---------------
+### Upgrade Rails 5.0 or older version to Rails 5.1
+
+If your application gets `ORA-01000: maximum open cursors exceeded`
+after upgrading to Rails 5.1
+check these two values and configure `:statement_limit` value at database.yml
+is larger than `open_cursors` at Oracle database instance.
+
+* `open_cursors` value at Oracle database instance
+
+```sql
+SQL> select name,value from v$parameter where name = 'open_cursors';
+
+NAME
+--------------------------------------------------------------------------------
+VALUE
+--------------------------------------------------------------------------------
+open_cursors
+1200
+
+```
+
+* `:statement_limit` value at database.yml
+
+Since Oracle enhanced adapter 1.8.0 this default value changed from 250 to 1000.
+
 ### Upgrade Rails 4.2 or older version to Rails 5
 
 If your Oracle table columns have been created for Rails `:datetime` attributes in Rails 4.2 or earlier,

data/VERSION

@@ -1 +1 @@
-1.8.1
+1.8.2

data/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

@@ -97,6 +97,7 @@ module ActiveRecord
           type_casted_binds = type_casted_binds(binds)
 
           log(sql, name, binds, type_casted_binds) do
+            cached = false
             returning_id_col = returning_id_index = nil
             if without_prepared_statement?(binds)
               cursor = @connection.prepare(sql)
@@ -115,6 +116,7 @@ module ActiveRecord
                 cursor.bind_returning_param(returning_id_index, Integer) if ORACLE_ENHANCED_CONNECTION == :jdbc
               end
 
+              cached = true
             end
 
             cursor.exec_update
@@ -124,6 +126,7 @@ module ActiveRecord
               returning_id = cursor.get_returning_param(returning_id_index, Integer).to_i
               rows << [returning_id]
             end
+            cursor.close unless cached
             ActiveRecord::Result.new(returning_id_col || [], rows)
           end
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.8.2
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-11 00:00:00.000000000 Z
+date: 2017-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -136,19 +136,19 @@ signing_key:
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord
 test_files:
-- spec/spec_config.yaml.template
-- spec/spec_helper.rb
 - spec/support/create_oracle_enhanced_users.sql
 - spec/support/alter_system_user_password.sql
-- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
+- spec/spec_config.yaml.template
+- spec/spec_helper.rb
 - spec/active_record/connection_adapters/oracle_enhanced_database_tasks_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_structure_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_context_index_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_connection_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb
-- spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb
 - spec/active_record/connection_adapters/oracle_enhanced_dirty_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_emulate_oracle_adapter_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb
+- spec/active_record/connection_adapters/oracle_enhanced_dbms_output_spec.rb