activerecord-oracle_enhanced-adapter 1.7.6 → 1.7.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41a3067381d41d5b5913b9a33068ba104b6a2dcf
-  data.tar.gz: be09e20a6bed6f6f809fc91c44b64123cc0401e9
+  metadata.gz: fa268d433a58212089a08ecef9e43c163abde038
+  data.tar.gz: 4c57883d8eaa819b01c58342cd1d1ef679228f46
 SHA512:
-  metadata.gz: 77e99c43c30fa4af329f92125d678a96250e5321b9bbd4df76555dbdf80d42dff2a779fdb43aa262dd01a493120a28bfd4113fa90b015c0e6f412c41d40a1da5
-  data.tar.gz: 3baf365a33a66438a8c6d1177baf2d499d944c0f85c261e7d486f8288a69578f018be54db571c33f5fbcea8c15be8cc35bc198279dfb459d2e8cc682fb4abef1
+  metadata.gz: e5f806719336de611f0b0665c16ed334c35c544f2e6b9462e2e6788f41417f33e43b524769c47bc6b1b6bb67c47316c2ac84b69132f6e3253f1d32d6d5f72441
+  data.tar.gz: 03f58f1cbdec17d82868588f78f1dd26cf6532ec819410f7c0d0cdd17a4611dee283bb55f2496befba03b9e37fe13ede1cff77b5792e9fd1ef87c49bf6110caf

data/History.md

@@ -1,3 +1,13 @@
+## 1.7.7 / 2016-11-15
+
+* Changes and bug fixes
+  * Introduce `use_old_oracle_visitor` to choose old Oracle visitor [#1049]
+  * Fix deprecated warnings in Ruby 2.4.0+ [#1048, #1052]
+  * Add Ruby 2.2.5 and JRuby 9.0.5.0 for travis [#1050, #1051]
+
+* Known issues
+ * No changes since 1.7.6
+
 ## 1.7.6 / 2016-11-12
 
 * Changes and bug fixes

data/VERSION

@@ -1 +1 @@
-1.7.6
+1.7.7

data/activerecord-oracle_enhanced-adapter.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.7.6"
+  s.version = "1.7.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.required_ruby_version     = '>= 2.2.2'
   s.license = 'MIT'
   s.authors = [%q{Raimonds Simanovskis}]
-  s.date = %q{2016-11-12}
+  s.date = %q{2016-11-15}
   s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
 This adapter is superset of original ActiveRecord Oracle adapter.
 }

data/lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb

@@ -250,12 +250,12 @@ module ActiveRecord
 
       def typecast_result_value(value, get_lob_value)
         case value
-        when Fixnum, Bignum
+        when Integer
           value
         when String
           value
         when Float, BigDecimal
-          # return Fixnum or Bignum if value is integer (to avoid issues with _before_type_cast values for id attributes)
+          # return Integer if value is integer (to avoid issues with _before_type_cast values for id attributes)
           value == (v_to_i = value.to_i) ? v_to_i : value
         when OraNumber
           # change OraNumber value (returned in early versions of ruby-oci8 2.0.x) to BigDecimal

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -390,6 +390,17 @@ module ActiveRecord
       cattr_accessor :string_to_time_format
       self.string_to_time_format = nil
 
+      ##
+      # :singleton-method:
+      # By default, OracleEnhanced adapter will use Oracle12 visitor
+      # if database version is Oracle 12.1.
+      # If you wish to use Oracle visitor which is intended to work with Oracle 11.2 or lower
+      # for Oracle 12.1 database you can add the following line to your initializer file:
+      #
+      #   ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.use_old_oracle_visitor = true
+      cattr_accessor :use_old_oracle_visitor
+      self.use_old_oracle_visitor = false
+
       class StatementPool
         include Enumerable
 
@@ -434,7 +445,7 @@ module ActiveRecord
       end
 
       def arel_visitor # :nodoc:
-        if supports_fetch_first_n_rows_and_offset?
+        if supports_fetch_first_n_rows_and_offset? && !use_old_oracle_visitor
           Arel::Visitors::Oracle12.new(self)
         else
           Arel::Visitors::Oracle.new(self)

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -206,19 +206,19 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
       expect(@employee2.job_id.class).to eq(BigDecimal)
     end
 
-    it "should return Fixnum value from NUMBER column if column name contains 'id' and emulate_integers_by_column_name is true" do
+    it "should return Integer value from NUMBER column if column name contains 'id' and emulate_integers_by_column_name is true" do
       # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_integers_by_column_name = true
       class ::Test2Employee < ActiveRecord::Base
         attribute :job_id, :integer
       end
       create_employee2
-      expect(@employee2.job_id.class).to eq(Fixnum)
+      expect(@employee2.job_id).to be_a(Integer)
     end
 
-    it "should return Fixnum value from NUMBER column with integer value using _before_type_cast method" do
+    it "should return Integer value from NUMBER column with integer value using _before_type_cast method" do
       # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_integers_by_column_name = true
       create_employee2
-      expect(@employee2.job_id_before_type_cast.class).to eq(Fixnum)
+      expect(@employee2.job_id_before_type_cast).to be_a(Integer)
     end
 
     it "should return BigDecimal value from NUMBER column if column name does not contain 'id' and emulate_integers_by_column_name is true" do
@@ -227,14 +227,14 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
       expect(@employee2.salary.class).to eq(BigDecimal)
     end
 
-    it "should return Fixnum value from NUMBER column if column specified in set_integer_columns" do
+    it "should return Integer value from NUMBER column if column specified in set_integer_columns" do
       # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_integers_by_column_name = false
       # Test2Employee.set_integer_columns :job_id
       class ::Test2Employee < ActiveRecord::Base
         attribute :job_id, :integer
       end
       create_employee2
-      expect(@employee2.job_id.class).to eq(Fixnum)
+      expect(@employee2.job_id).to be_a(Integer)
     end
 
     it "should return Boolean value from NUMBER(1) column if emulate booleans is used" do
@@ -243,23 +243,23 @@ describe "OracleEnhancedAdapter integer type detection based on column names" do
       expect(@employee2.is_manager.class).to eq(TrueClass)
     end
 
-    it "should return Fixnum value from NUMBER(1) column if emulate booleans is not used" do
+    it "should return Integer value from NUMBER(1) column if emulate booleans is not used" do
       # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans = false
       class ::Test2Employee < ActiveRecord::Base
         attribute :is_manager, :integer
       end
       create_employee2
-      expect(@employee2.is_manager.class).to eq(Fixnum)
+      expect(@employee2.is_manager).to be_a(Integer)
     end
 
-    it "should return Fixnum value from NUMBER(1) column if column specified in set_integer_columns" do
+    it "should return Integer value from NUMBER(1) column if column specified in set_integer_columns" do
       # ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans = true
       # Test2Employee.set_integer_columns :is_manager
       class ::Test2Employee < ActiveRecord::Base
         attribute :is_manager, :integer
       end
       create_employee2
-      expect(@employee2.is_manager.class).to eq(Fixnum)
+      expect(@employee2.is_manager).to be_a(Integer)
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.7.6
+  version: 1.7.7
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-12 00:00:00.000000000 Z
+date: 2016-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -133,7 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord