activerecord-oracle_enhanced-adapter 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 90fa8b1a7acfc65a87b37c9d9e6fab35b7a6fe35
-  data.tar.gz: 3d1fe46c3644b1a5ac00bc7c212df6e7e55fa1fb
+  metadata.gz: bf4084aa6fe2217315ef98166e65bf6191e412e6
+  data.tar.gz: fdf580fff012e2e395d63391752769afcfa84eaf
 SHA512:
-  metadata.gz: 04809974b2b2258aff6483828ae2d4c5db9d2b7ff7f6c5290c8d0c6f50b63d59b391c66efbe47bb3f911c0083fb16707c10479ddd4a3c1e7c9a00a5f8366cd04
-  data.tar.gz: 2fb86439af72485537fa6e6545eedffd2716e77f3ee640a5e207a1ff935add1f650c94a71e6b0ef0e50b7922b69d07dd4c92c222a42b028e6eacc9255800c3aa
+  metadata.gz: 2284e55e7d67bc70a25dfd063cece15fc03b6d987d90fd596e81277bb5dc18902022e3675afe1646784d9f6d28c4ce541b85232d4e6d561cb0f42b954d68c6ba
+  data.tar.gz: 45c8321ce8d8b6482c2384ca4d8cdafacca7063f87fd88c8126caa290a3a26fd5234b91a3398c9e2f78109b458207027cfebef8b840c1e93b302f76f060e8885

data/History.md

@@ -1,3 +1,13 @@
+## 1.7.1 / 2016-08-22
+
+* Changes and bug fixes
+ * Add `ActiveRecord::OracleEnhanced::Type::Boolean` [#985, #979]
+ * Address `create_table': undefined method `each_pair' for []:Array (NoMethodError) [#980]
+ * Deprecate `fallback_string_to_date`, `fallback_string_to_time` [#974]
+
+* Known issues
+ * No changes since 1.7.0.rc1
+
 ## 1.7.0 / 2016-08-04
 
 * Changes and bug fixes

data/VERSION

@@ -1 +1 @@
-1.7.0
+1.7.1

data/activerecord-oracle_enhanced-adapter.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.7.0"
+  s.version = "1.7.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.required_ruby_version     = '>= 2.2.2'
   s.license = 'MIT'
   s.authors = [%q{Raimonds Simanovskis}]
-  s.date = %q{2016-08-04}
+  s.date = %q{2016-08-22}
   s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
 This adapter is superset of original ActiveRecord Oracle adapter.
 }
@@ -46,6 +46,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
     "lib/active_record/connection_adapters/oracle_enhanced/schema_statements_ext.rb",
     "lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb",
     "lib/active_record/connection_adapters/oracle_enhanced/version.rb",
+    "lib/active_record/oracle_enhanced/type/boolean.rb",
     "lib/active_record/oracle_enhanced/type/integer.rb",
     "lib/active_record/oracle_enhanced/type/national_character_string.rb",
     "lib/active_record/oracle_enhanced/type/raw.rb",

data/lib/active_record/connection_adapters/oracle_enhanced/column.rb

@@ -91,6 +91,12 @@ module ActiveRecord
 
         def fallback_string_to_date(string) #:nodoc:
           if OracleEnhancedAdapter.string_to_date_format || OracleEnhancedAdapter.string_to_time_format
+            ActiveSupport::Deprecation.warn(<<-MSG.squish)
+              `fallback_string_to_date` has been deprecated.
+              It will be removed from next version of Oracle enhanced adapter.
+              Users are unlikely to see this message since this method has gone
+              from ActiveRecord::ConnectionAdapters::Column in Rails 4.2.
+            MSG
             return (string_to_date_or_time_using_format(string).to_date rescue super)
           end
           super
@@ -98,12 +104,25 @@ module ActiveRecord
 
         def fallback_string_to_time(string) #:nodoc:
           if OracleEnhancedAdapter.string_to_time_format || OracleEnhancedAdapter.string_to_date_format
+            ActiveSupport::Deprecation.warn(<<-MSG.squish)
+              `fallback_string_to_time` has been deprecated.
+              It will be removed from next version of Oracle enhanced adapter.
+              Users are unlikely to see this message since this method has gone
+              from ActiveRecord::ConnectionAdapters::Column in Rails 4.2.
+            MSG
             return (string_to_date_or_time_using_format(string).to_time rescue super)
           end
           super
         end
 
         def string_to_date_or_time_using_format(string) #:nodoc:
+          ActiveSupport::Deprecation.warn(<<-MSG.squish)
+            `string_to_date_or_time_using_format` has been deprecated.
+            It will be removed from next version of Oracle enhanced adapter.
+            Users are unlikely to see this message since `fallback_string_to_date`
+            and `fallback_string_to_time` have gone
+            from ActiveRecord::ConnectionAdapters::Column in Rails 4.2.
+          MSG
           if OracleEnhancedAdapter.string_to_time_format && dt=Date._strptime(string, OracleEnhancedAdapter.string_to_time_format)
             return Time.parse("#{dt[:year]}-#{dt[:mon]}-#{dt[:mday]} #{dt[:hour]}:#{dt[:min]}:#{dt[:sec]}#{dt[:zone]}")
           end

data/lib/active_record/connection_adapters/oracle_enhanced/schema_statements.rb

@@ -83,7 +83,7 @@ module ActiveRecord
               change_column_comment(table_name, column.name, column.comment) if column.comment
             end
           end
-          td.indexes.each_pair { |c,o| add_index table_name, c, o }
+          td.indexes.each { |c,o| add_index table_name, c, o }
 
         end
 

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -1195,7 +1195,7 @@ module ActiveRecord
 
         if OracleEnhancedAdapter.emulate_booleans
           if OracleEnhancedAdapter.emulate_booleans_from_strings
-            m.register_type %r(^VARCHAR2\(1\))i, Type::Boolean.new
+            m.register_type %r(^VARCHAR2\(1\))i, ActiveRecord::OracleEnhanced::Type::Boolean.new
           else
             m.register_type %r(^NUMBER\(1\))i, Type::Boolean.new
           end
@@ -1338,3 +1338,6 @@ require 'active_record/oracle_enhanced/type/national_character_string'
 
 # Add OracleEnhanced::Type::Text
 require 'active_record/oracle_enhanced/type/text'
+
+# Add OracleEnhanced::Type::Boolean
+require 'active_record/oracle_enhanced/type/boolean'

data/lib/active_record/oracle_enhanced/type/boolean.rb

@@ -0,0 +1,22 @@
+module ActiveRecord
+  module OracleEnhanced
+    module Type
+      class Boolean < ActiveModel::Type::Boolean # :nodoc:
+        # Add 'N' as FALSE_VALUES
+        FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE', 'off', 'OFF', 'n', 'N'].to_set
+
+        private
+
+        def cast_value(value)
+          # Not calling super to use its own `FALSE_VALUES`
+          if value == ''
+            nil
+          else
+            !FALSE_VALUES.include?(value)
+          end
+        end
+
+      end
+    end
+  end
+end

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -439,6 +439,40 @@ describe "OracleEnhancedAdapter boolean type detection based on string column ty
 
 end
 
+describe "OracleEnhancedAdapter boolean support when emulate_booleans_from_strings = true" do
+  before(:all) do
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = true
+    ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
+    ActiveRecord::Schema.define do
+      create_table :posts, :force => true do |t|
+        t.string  :name,        null: false
+        t.boolean :is_default, default: false
+      end
+    end
+  end
+
+  after(:all) do
+    ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter.emulate_booleans_from_strings = false
+  end
+
+  before(:each) do
+    class ::Post < ActiveRecord::Base
+    end
+  end
+
+  after(:each) do
+    Object.send(:remove_const, "Post")
+    ActiveRecord::Base.clear_cache!
+  end
+
+  it "boolean should not change after reload" do
+    post = Post.create(name: 'Test 1', is_default: false)
+    expect(post.is_default).to be false
+    post.reload
+    expect(post.is_default).to be false
+  end
+end
+
 describe "OracleEnhancedAdapter timestamp with timezone support" do
   before(:all) do
     ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-04 00:00:00.000000000 Z
+date: 2016-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -106,6 +106,7 @@ files:
 - lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb
 - lib/active_record/connection_adapters/oracle_enhanced/version.rb
 - lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
+- lib/active_record/oracle_enhanced/type/boolean.rb
 - lib/active_record/oracle_enhanced/type/integer.rb
 - lib/active_record/oracle_enhanced/type/national_character_string.rb
 - lib/active_record/oracle_enhanced/type/raw.rb
@@ -146,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.4
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Oracle enhanced adapter for ActiveRecord