activerecord-oracle_enhanced-adapter 1.7.0.beta3 → 1.7.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0bbb2aebec384e0204b617dbf5a6e655a8722416
-  data.tar.gz: 6fed44437c1cefbcfe128f966f0aa403a653e564
+  metadata.gz: 3df4a696070c8c035aa78ed9dd994026c4574fce
+  data.tar.gz: 3f188e30da0e0a62f1118361ce59f1aa4e60a988
 SHA512:
-  metadata.gz: f2c36e334ebd84c28e96083af7a17329c8b80184b8e6ff2e06be334b172055e8bc675beeb66e926f73749de3eb2c87bb24b760b33299a905658b1d524b7ab230
-  data.tar.gz: 698b970a12d567ed1599f15ff940eb83bd01dd6d9f9b5bba902807679d8db93925d25fa99e14dc5c62b1faeb139813c9dd5d19e6696900a6a3dbcb9076737a70
+  metadata.gz: f01b5ce78edad5e74a7affeba450f5d39717cb0dd530728625c28f1b90bb56da397a83f9cec2ac8348429d43567abfe565773da761f517ef5990acc7b0062cc7
+  data.tar.gz: 6ac7c22f0367fc0a630bf42385bc951abb6048b0f61246e2bbab919fc5a7bd755401819492b6067ac05d35e690cb8ac51c43ae300c4da646dc2dc9de8eb73b9e

data/History.md

@@ -1,3 +1,25 @@
+## 1.7.0.beta4 / 2016-07-27
+
+* Changes and bug fixes
+
+ * Call `bind_returning_param` when sql has returning_id and using JRuby [#937]
+ * Remove unused `col_type` to avoid warnings [#934]
+ * Remove TODO comment since Oracle DATE type can be mapped Rails Datetime with attribute API [#935]
+ * Remove rspec from runtime dependency [#933]
+ * Rename `add_dependency` to `add_runtime_dependency` [#933]
+ * Remove warnings for + when tested with JRuby 9.1.2 [#936]
+
+* Known issues
+
+ - Only with JRuby
+ * Rails 5 : create table with primary key trigger with default primary key not returning id [#912]
+    * #937 addresses two failures reported in #912
+ * Rails 5 : explain should explain query with binds got Java::JavaSql::SQLException: Invalid column index [#908]
+ - CRuby and JRuby
+ * Rails 5 : create table with primary key trigger not returning id [#907]
+ * Rails 5 : custom methods for create, update and destroy not working [#906]
+ * Rails 5 : undefined method `to_i' for #<Arel::Nodes::BindParam:0x00000002c92910> [#848, rails/arel#438]
+
 ## 1.7.0.beta3 / 2016-07-22
 
 * Changes and bug fixes

data/README.md

@@ -18,7 +18,7 @@ Oracle enhanced adapter Rails 5 support is still in beta release, so use with ca
 
 ```ruby
 # Use oracle as the database for Active Record
-gem 'activerecord-oracle_enhanced-adapter', '~> 1.7.0.beta2'
+gem 'activerecord-oracle_enhanced-adapter', '~> 1.7.0.beta4'
 ```
 
 ### Rails 4.2

data/VERSION

@@ -1 +1 @@
-1.7.0.beta3
+1.7.0.beta4

data/activerecord-oracle_enhanced-adapter.gemspec

@@ -1,12 +1,12 @@
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.7.0.beta3"
+  s.version = "1.7.0.beta4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.required_ruby_version     = '>= 2.2.2'
   s.license = 'MIT'
   s.authors = [%q{Raimonds Simanovskis}]
-  s.date = %q{2016-07-22}
+  s.date = %q{2016-07-27}
   s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
 This adapter is superset of original ActiveRecord Oracle adapter.
 }
@@ -86,11 +86,10 @@ This adapter is superset of original ActiveRecord Oracle adapter.
     "spec/active_record/connection_adapters/oracle_enhanced_structure_dump_spec.rb",
     "spec/spec_helper.rb"
   ]
-  s.add_dependency(%q<rspec>, ["~> 3.3"])
-  s.add_dependency(%q<activerecord>, ["~> 5.0.0"])
-  s.add_dependency(%q<arel>, ["~> 7.1.0"])
-  s.add_dependency(%q<ruby-plsql>, [">= 0.5.0"])
-  s.add_dependency(%q<ruby-oci8>, [">= 2.2.0"]) if !defined?(RUBY_ENGINE) || RUBY_ENGINE == 'ruby'
+  s.add_runtime_dependency(%q<activerecord>, ["~> 5.0.0"])
+  s.add_runtime_dependency(%q<arel>, ["~> 7.1.0"])
+  s.add_runtime_dependency(%q<ruby-plsql>, [">= 0.5.0"])
+  s.add_runtime_dependency(%q<ruby-oci8>, [">= 2.2.0"]) if !defined?(RUBY_ENGINE) || RUBY_ENGINE == 'ruby'
   s.license = 'MIT'
 end
 

data/lib/active_record/connection_adapters/oracle_enhanced/database_statements.rb

@@ -108,12 +108,17 @@ module ActiveRecord
               cursor = @statements[sql]
 
               cursor.bind_params(type_casted_binds)
+
+              if sql =~ /:returning_id/
+                returning_id_index = 1
+                cursor.bind_returning_param(returning_id_index, Integer) if ORACLE_ENHANCED_CONNECTION == :jdbc
+              end
+
             end
 
             cursor.exec_update
 
             rows = []
-            returning_id_index = 1 if sql =~ /:returning_id/
             if returning_id_index
               returning_id = cursor.get_returning_param(returning_id_index, Integer).to_i
               rows << [returning_id]

data/lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb

@@ -142,14 +142,14 @@ module ActiveRecord
 
           if column && column.object_type?
             @raw_cursor.bind_param(position, value, :named_type, column.sql_type)
-          elsif value.nil?
-            @raw_cursor.bind_param(position, nil, String)
           else
-            case col_type = column && column.type
-            when :raw
+            case value
+            when ActiveRecord::OracleEnhanced::Type::Raw
               @raw_cursor.bind_param(position, ActiveRecord::ConnectionAdapters::OracleEnhanced::Quoting.encode_raw(value))
-            when :decimal
+            when ActiveModel::Type::Decimal
               @raw_cursor.bind_param(position, BigDecimal.new(value.to_s))
+            when NilClass
+              @raw_cursor.bind_param(position, nil, String)
             else
               @raw_cursor.bind_param(position, value)
             end

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -497,10 +497,7 @@ module ActiveRecord
         :integer     => { :name => "NUMBER", :limit => 38 },
         :float       => { :name => "BINARY_FLOAT" },
         :decimal     => { :name => "DECIMAL" },
-        #TODO: Needs to consider to support :datetime as DATE 
         :datetime    => { :name => "TIMESTAMP" },
-        # changed to native TIMESTAMP type
-        # :timestamp   => { :name => "DATE" },
         :timestamp   => { :name => "TIMESTAMP" },
         :time        => { :name => "TIMESTAMP" },
         :date        => { :name => "DATE" },

data/spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb

@@ -72,7 +72,7 @@ describe "OracleEnhancedAdapter schema definition" do
 
     it "should return sequence name without truncating too much" do
       seq_name_length = ActiveRecord::Base.connection.sequence_name_length
-      tname = "#{DATABASE_USER}" + "." +"a"*(seq_name_length - DATABASE_USER.length) + "z"*(DATABASE_USER).length
+      tname = "#{DATABASE_USER}" + "." + "a"*(seq_name_length - DATABASE_USER.length) + "z"*(DATABASE_USER).length
       expect(ActiveRecord::Base.connection.default_sequence_name(tname)).to match (/z_seq$/)
     end
   end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.7.0.beta3
+  version: 1.7.0.beta4
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-22 00:00:00.000000000 Z
+date: 2016-07-27 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement