activerecord-oracle_enhanced-adapter 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fd6c2c33f02b87cf6022cfe64bf057a9ed992554
-  data.tar.gz: c7358edd06e352897de691eb71ed140ba6518b0b
+  metadata.gz: 7711c73f40b2ea4312ff8e5efe5ecdbc1e30521e
+  data.tar.gz: 42cb1cf7bf713ec2ad67818c78b8c07d24ea5f6f
 SHA512:
-  metadata.gz: c16fb1f0555c03526c8d0cd3c3fad645d1b905749f87dba95e5d7e4465be43a08a3f4766aa26a621f04ab9d3ca5856f831538e5127b97780f94e8b941e6f25ca
-  data.tar.gz: f8914aa9fc1ee082c39015f42c10e9edef0f32841b4d855e9b1da9d45d6ab6d80bddda6bb5b1cf0010b6b28b6b2af2d6feefb841acc7a8ca2618c143dd8f0cc8
+  metadata.gz: acbc9ace54d4da1b4d4ad53b4d989390539d6de99057aaf386880ad5f14df672d0e148e0779ab5285dde5849068b0a74b0b133e420123c2fc3fc6a43765cda3c
+  data.tar.gz: b4d28e7db4ba6cdb92fe8b65471027039157a96d80cb991554dbdcf7a1578ebc7e0a56db065351099a9696bac7f69c1f9747f7c75af52b721a7fd331dbb0740c

data/History.md

@@ -1,3 +1,13 @@
+## 1.6.1 / 2015-07-01
+
+* Changes and bug fixes since 1.6.0
+
+ * Oracle enhanced adapter v1.6 requires ActiveRecord 4.2.1 or higher, 
+   ActiveRecord 4.2.0 is not supported.[#651, #652]
+ * Fix serialized value becomes from yaml to string once saved [#655, #657]
+ * Update Ruby version in readme [#654]
+ * Update unit test matcher to skip sql statements to get `table` metadata [#653] 
+
 ## 1.6.0 / 2015-06-25
 
 * Changes and bug fixes since 1.6.0.beta1

data/README.md

@@ -10,12 +10,22 @@ Oracle enhanced ActiveRecord adapter provides Oracle database access from Ruby o
 
 INSTALLATION
 ------------
+### Rails 4.2
 
-### Rails 4
+Oracle enhanced adapter version 1.6 just supports Rails 4.2 and does not support Rails 4.1 or lower version of Rails.
+When using Ruby on Rails version 4.2 then in Gemfile include
 
-Oracle enhanced adapter version 1.5 just supports Rails 4 and does not support Rails 3.2 or lower version of Rails.
+```ruby
+gem 'activerecord-oracle_enhanced-adapter', '~> 1.6.0'
+```
+
+where instead of 1.6.0 you can specify any other desired version. It is recommended to specify version with `~>` which means that use specified version or later patch versions (in this example any later 1.5.x version but not 1.6.x version). Oracle enhanced adapter maintains API backwards compatibility during patch version upgrades and therefore it is safe to always upgrade to latest patch version.
+
+### Rails 4.0 and 4.1
+
+Oracle enhanced adapter version 1.5 supports Rails 4.0 and 4.1 and does not support Rails 3.2 or lower version of Rails.
 
-When using Ruby on Rails version 4 then in Gemfile include
+When using Ruby on Rails version 4.0 and 4.1 then in Gemfile include
 
 ```ruby
 gem 'activerecord-oracle_enhanced-adapter', '~> 1.5.0'
@@ -29,7 +39,7 @@ If you would like to use latest adapter version from github then specify
 gem 'activerecord-oracle_enhanced-adapter', :git => 'git://github.com/rsim/oracle-enhanced.git'
 ```
 
-If you are using CRuby 1.9.3 or 2.0 then you need to install ruby-oci8 gem as well as Oracle client, e.g. [Oracle Instant Client](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html). Include in Gemfile also ruby-oci8:
+If you are using CRuby >= 1.9.3 then you need to install ruby-oci8 gem as well as Oracle client, e.g. [Oracle Instant Client](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html). Include in Gemfile also ruby-oci8:
 
 ```ruby
 gem 'ruby-oci8', '~> 2.1.0'

data/VERSION

@@ -1 +1 @@
-1.6.0
+1.6.1

data/activerecord-oracle_enhanced-adapter.gemspec

@@ -5,12 +5,12 @@
 
 Gem::Specification.new do |s|
   s.name = %q{activerecord-oracle_enhanced-adapter}
-  s.version = "1.6.0"
+  s.version = "1.6.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.license = 'MIT'
   s.authors = [%q{Raimonds Simanovskis}]
-  s.date = %q{2015-06-25}
+  s.date = %q{2015-07-01}
   s.description = %q{Oracle "enhanced" ActiveRecord adapter contains useful additional methods for working with new and legacy Oracle databases.
 This adapter is superset of original ActiveRecord Oracle adapter.
 }
@@ -94,7 +94,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_development_dependency(%q<rspec>, ["~> 2.4"])
-      s.add_development_dependency(%q<activerecord>, [">= 0"])
+      s.add_development_dependency(%q<activerecord>, ["~> 4.2.1"])
       s.add_development_dependency(%q<activemodel>, [">= 0"])
       s.add_development_dependency(%q<activesupport>, [">= 0"])
       s.add_development_dependency(%q<actionpack>, [">= 0"])
@@ -106,7 +106,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
     else
       s.add_dependency(%q<jeweler>, ["~> 2.0"])
       s.add_dependency(%q<rspec>, ["~> 2.4"])
-      s.add_dependency(%q<activerecord>, [">= 0"])
+      s.add_dependency(%q<activerecord>, ["~> 4.2.1"])
       s.add_dependency(%q<activemodel>, [">= 0"])
       s.add_dependency(%q<activesupport>, [">= 0"])
       s.add_dependency(%q<actionpack>, [">= 0"])
@@ -120,7 +120,7 @@ This adapter is superset of original ActiveRecord Oracle adapter.
     s.add_dependency(%q<jeweler>, ["~> 2.0"])
     s.add_dependency(%q<rspec>, ["~> 2.4"])
     s.add_dependency(%q<activerecord>, [">= 0"])
-    s.add_dependency(%q<activemodel>, [">= 0"])
+    s.add_dependency(%q<activemodel>, ["~> 4.2.1"])
     s.add_dependency(%q<activesupport>, [">= 0"])
     s.add_dependency(%q<actionpack>, [">= 0"])
     s.add_dependency(%q<railties>, [">= 0"])

data/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

@@ -826,7 +826,7 @@ module ActiveRecord
           value = attributes[col.name]
           # changed sequence of next two lines - should check if value is nil before converting to yaml
           next if value.nil?  || (value == '')
-          value = value.to_yaml if value.is_a?(String) && klass.serialized_attributes[col.name]
+          value = value.to_yaml if klass.serialized_attributes[col.name]
           uncached do
             sql = is_with_cpk ? "SELECT #{quote_column_name(col.name)} FROM #{quote_table_name(table_name)} WHERE #{klass.composite_where_clause(id)} FOR UPDATE" :
               "SELECT #{quote_column_name(col.name)} FROM #{quote_table_name(table_name)} WHERE #{quote_column_name(klass.primary_key)} = #{id} FOR UPDATE"

data/spec/active_record/connection_adapters/oracle_enhanced_data_types_spec.rb

@@ -1087,6 +1087,18 @@ describe "OracleEnhancedAdapter handling of CLOB columns" do
     @employee.reload
     @employee.comments.should == "initial serialized data"
   end
+
+  it "should keep serialized data after save" do
+    @employee = Test2Employee.new
+    @employee.comments = {:length=>{:is=>1}}
+    @employee.save
+    @employee.reload
+    @employee.comments.should == {:length=>{:is=>1}}
+    @employee.comments = {:length=>{:is=>2}}
+    @employee.save
+    @employee.reload
+    @employee.comments.should == {:length=>{:is=>2}}
+  end
 end
 
 describe "OracleEnhancedAdapter handling of BLOB columns" do

data/spec/active_record/connection_adapters/oracle_enhanced_procedures_spec.rb

@@ -325,7 +325,8 @@ describe "OracleEnhancedAdapter custom methods for create, update and destroy" d
       :last_name => "Last",
       :hire_date => @today
     )
-    @logger.logged(:debug).last.should match(/^TestEmployee Create \(\d+\.\d+(ms)?\)  custom create method$/)
+    #TODO: dirty workaround to remove sql statement for `table` method
+    @logger.logged(:debug)[-2].should match(/^TestEmployee Create \(\d+\.\d+(ms)?\)  custom create method$/)
     clear_logger
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-oracle_enhanced-adapter
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-25 00:00:00.000000000 Z
+date: 2015-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jeweler