activerecord-nested_attribute_destruction 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ceaff9a731ffccd9d26e122b49d69936b6d4401c05f159740a455494dfecb9bf
-  data.tar.gz: 32cb47ef8c9efa02f89141952cf914bad2ce72b39408630283bca21ea3011429
+  metadata.gz: 6dac1a81884232bf32c0b31e8466dba5861865729c326fdf4eb12fe1624c8105
+  data.tar.gz: 3cb0131d79043d18371cb85070923d8231909122f96bdf292ea691c81297e277
 SHA512:
-  metadata.gz: 3fcb0ff80ca9b0e6af312ddb125f463e01a289eb9c8429f077a8540c96004c6d49d475bbff8b3b53a6a067e925f41dd5a231a54a61879a02efea2c3b64a7fe60
-  data.tar.gz: 4d1faccd22aaacbb84180d0100289dad76208684c9e06c769f531783ce921f929dd8968a13861d2f35203bec68f8203a86011a357baceea9b6ee71e6efbc3f72
+  metadata.gz: 3bb208ad070ef33d02fe41af242b0caef248d4fb37dc9a90f25e21360b88038422bb4699989296d5f109e0b98745589706d7c2af1b02392890dcd3abe13cdd50
+  data.tar.gz: 3be694ae9981724d5fb72a415c797d4ec63a8cb18eab22567e16d478b99f2976c1342578381fb734b00196d03c6abc059dac5f378ad125f1f6a4e67d6f993ce5

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 ## [Unreleased]
 
+## [0.2.0] - 2022-01-24
+
+**POSSIBLY BREAKING CHANGE**
+
+Use `around_update` instead of `before_update` and `after_commit, on: :update`.
+
+In some situations, our `after_commit` would be run after `after_commit`
+callbacks that were defined in the user application.
+
+By using `around_update`, our callback finishes before any `after_*` callbacks are called.
+
 ## [0.1.1] - 2022-01-17
 
 Fixed bug where the monitor might not have been created yet when it is accessed.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    activerecord-nested_attribute_destruction (0.1.1)
+    activerecord-nested_attribute_destruction (0.2.0)
       activerecord (>= 5.2.0)
 
 GEM

data/lib/nested_attribute_destruction/monitor.rb

@@ -30,11 +30,9 @@ module NestedAttributeDestruction
           @nested_attribute_destruction_monitor = NestedAttributeDestruction::Monitor.new
         end
 
-        klass.before_update do |obj|
+        klass.around_update do |obj, block|
           @nested_attribute_destruction_monitor.send(:store_attributes_marked_for_destruction, obj)
-        end
-
-        klass.after_commit(on: :update) do
+          block.call
           @nested_attribute_destruction_monitor.send(:save_succeeded)
         end
       end

data/lib/nested_attribute_destruction/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NestedAttributeDestruction
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-nested_attribute_destruction
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Brandon Conway
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-01-17 00:00:00.000000000 Z
+date: 2022-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord