activerecord-nested_attribute_destruction 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af843c559bcd2739db207cfb8f4ce7976d5fccb8b003af5693f1f875c2926cfd
-  data.tar.gz: bf2f1ca17b5b9af2114c360fbad1311f976a064a6d4521894ed8666f8a03a456
+  metadata.gz: ceaff9a731ffccd9d26e122b49d69936b6d4401c05f159740a455494dfecb9bf
+  data.tar.gz: 32cb47ef8c9efa02f89141952cf914bad2ce72b39408630283bca21ea3011429
 SHA512:
-  metadata.gz: a5197efe66c61cf0c9d1cfbe4bbc31c63d7250e16bf3849bfc884825739bc9623b1558aba9465ad7575b96aa5333a1abcfad56939982d408503b3c39c8fd6d76
-  data.tar.gz: 599de273a9aefa457d6370696f8f8a24539d109f84642787b8f9abd688b02585ebfceffda744def5baa0cf1efa25c126cb336901f23a9ec27abf6311e767605a
+  metadata.gz: 3fcb0ff80ca9b0e6af312ddb125f463e01a289eb9c8429f077a8540c96004c6d49d475bbff8b3b53a6a067e925f41dd5a231a54a61879a02efea2c3b64a7fe60
+  data.tar.gz: 4d1faccd22aaacbb84180d0100289dad76208684c9e06c769f531783ce921f929dd8968a13861d2f35203bec68f8203a86011a357baceea9b6ee71e6efbc3f72

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.1.1] - 2022-01-17
+
+Fixed bug where the monitor might not have been created yet when it is accessed.
+
 ## [0.1.0] - 2021-12-22
 
 - Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    activerecord-nested_attribute_destruction (0.1.0)
+    activerecord-nested_attribute_destruction (0.1.1)
       activerecord (>= 5.2.0)
 
 GEM
@@ -181,4 +181,4 @@ DEPENDENCIES
   sqlite3 (~> 1.4.2)
 
 BUNDLED WITH
-   2.3.2
+   2.3.4

data/README.md

@@ -1,5 +1,28 @@
 # activerecord-nested\_attribute\_destruction
 
+Build status for all matrix combinations listed in [compatibility](#compatibility)
+
+[![CircleCI](https://circleci.com/gh/brandoncc/activerecord-nested_attribute_destruction.svg?style=svg)](https://circleci.com/gh/brandoncc/activerecord-nested_attribute_destruction)
+
+## TL;DR
+
+```ruby
+class Harbor
+  has_many :ships
+
+  accepts_nested_attributes_for :ships, allow_destroy: true
+end
+
+harbor.ships_attributes = [harbor.ships.first.attributes.merge('_destroy': true)]
+harbor.save!
+
+harbor.ships_destroyed_during_save? # true
+```
+
+See that last line of code? That is what this gem adds :smiley:
+
+## Description
+
 Active Record offers introspection of saved changes for almost everything you
 could want. The one thing I have repeatedly found myself wishing for was a way
 to know if a nested attribute was destroyed during save via
@@ -89,8 +112,12 @@ To see more examples, take a look at [the tests](https://github.com/brandoncc/ac
 
 ## Compatibility
 
-This gem is built and its tests are run for the following ruby/active record
-combinations:
+This gem should be compatible with all versions of Ruby 2.3 and higher. It
+should be compatible with Active Record versions 5.2 and up.
+
+Because of rubocop dependencies and keyword arguments changes in Ruby 3.0 which
+affected the database setup code used in the test suite, it is only tested
+against the matrices displayed below.
 
 ### Sorted by Active Record version
 
@@ -126,6 +153,17 @@ combinations:
 | 3.0          | 6.1                   |
 | 3.0          | 7.0                   |
 
+### Specific requirements
+
+#### Ruby
+
+The safe navigation operator, introduced in Ruby 2.3, is used.
+
+#### Active Record
+
+The [API changes](https://www.fastruby.io/blog/rails/upgrades/active-record-5-1-api-changes.html)
+in Active Record 5.2 are necessary for the core functionality of the gem.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/nested_attribute_destruction/monitor.rb

@@ -19,7 +19,6 @@ module NestedAttributeDestruction
 
       def define_predicate(klass, assoc_name)
         klass.define_method("#{assoc_name}_destroyed_during_save?") do
-          @nested_attribute_destruction_monitor ||= NestedAttributeDestruction::Monitor.new
           @nested_attribute_destruction_monitor.send(:destroyed_during_save?, assoc_name.to_sym)
         end
       end
@@ -27,8 +26,11 @@ module NestedAttributeDestruction
       private
 
       def define_callbacks(klass)
+        klass.after_initialize do
+          @nested_attribute_destruction_monitor = NestedAttributeDestruction::Monitor.new
+        end
+
         klass.before_update do |obj|
-          @nested_attribute_destruction_monitor ||= NestedAttributeDestruction::Monitor.new
           @nested_attribute_destruction_monitor.send(:store_attributes_marked_for_destruction, obj)
         end
 

data/lib/nested_attribute_destruction/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NestedAttributeDestruction
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: activerecord-nested_attribute_destruction
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Brandon Conway
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-12-24 00:00:00.000000000 Z
+date: 2022-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord